You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2021/07/01 08:27:25 UTC

[GitHub] [echarts] pissang opened a new pull request #15271: fix: improve types in custom series and others.

pissang opened a new pull request #15271:
URL: https://github.com/apache/echarts/pull/15271


   <!-- Please fill in the following information to help us review your PR more efficiently. -->
   
   ## Brief Information
   
   This pull request is in the type of:
   
   - [x] bug fixing
   - [ ] new feature
   - [ ] others
   
   
   
   ### What does this PR do?
   
   This PR mainly focuses on fixing types in custom series. It includes:
   
   1. Add missing `dataIndex` and other properties in the `params` of `renderItem`
   2. Better return type inferring of `renderItem`. Now it will provide a precise `shape`, `style` type checking based on the type of element.
   3. More precise type in the methods of `apiDuring`. Remove `unknown` type in transform, style, shape getter/setter.
   
   This PR also updated typescript version to the latest and fix some properties are not optional.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] echarts-bot[bot] commented on pull request #15271: fix: improve types in custom series and others.

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #15271:
URL: https://github.com/apache/echarts/pull/15271#issuecomment-872050432


   Congratulations! Your PR has been merged. Thanks for your contribution! 👍


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] echarts-bot[bot] commented on pull request #15271: fix: improve types in custom series and others.

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #15271:
URL: https://github.com/apache/echarts/pull/15271#issuecomment-872039434


   Thanks for your contribution!
   The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).
   
   The pull request is marked to be `PR: author is committer` because you are a committer of this project.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] pissang merged pull request #15271: fix: improve types in custom series and others.

Posted by GitBox <gi...@apache.org>.
pissang merged pull request #15271:
URL: https://github.com/apache/echarts/pull/15271


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org