You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/01/20 10:38:43 UTC
[GitHub] [incubator-kyuubi] turboFei opened a new pull request #1813: Enable the internal secure authentication
turboFei opened a new pull request #1813:
URL: https://github.com/apache/incubator-kyuubi/pull/1813
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on a change in pull request #1813: [WIP] Enable the internal secure authentication
Posted by GitBox <gi...@apache.org>.
turboFei commented on a change in pull request #1813:
URL: https://github.com/apache/incubator-kyuubi/pull/1813#discussion_r788646549
##########
File path: kyuubi-common/src/main/scala/org/apache/kyuubi/service/authentication/SecureAccessor.scala
##########
@@ -0,0 +1,117 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.kyuubi.service.authentication
+
+import java.util.ServiceLoader
+import javax.crypto.Cipher
+import javax.crypto.spec.SecretKeySpec
+
+import scala.collection.JavaConverters._
+
+import org.apache.kyuubi.{KyuubiSQLException, Logging}
+import org.apache.kyuubi.config.KyuubiConf
+import org.apache.kyuubi.service.AbstractService
+
+class SecureAccessor(name: String) extends AbstractService(name) {
+ import SecureAccessor._
+
+ def this() = this(classOf[SecureAccessor].getName)
+
+ private var providerOpt: Option[SecureAccessProvider] = _
+ private var tokenMaxLifeTime: Long = _
+ private var encryptCipherInstance: Cipher = _
+ private var decryptCipherInstance: Cipher = _
+
+ override def initialize(conf: KyuubiConf): Unit = {
+ tokenMaxLifeTime = conf.get(KyuubiConf.ENGINE_ACCESS_TOKEN_MAX_LIFETIME)
+ providerOpt = loadProvider()
+ providerOpt.foreach(_.initialize(conf))
+ super.initialize(conf)
+ SecureAccessor._secureAccessor = this
+ }
+
+ def supportSecureAccess(): Boolean = {
+ providerOpt.exists(_.supportSecureAccess)
+ }
+
+ override def start(): Unit = {
+ super.start()
+ providerOpt.foreach { provider =>
+ val (secret, cipher) = provider.getSecretAndCipher()
+ val secretKeySpec = new SecretKeySpec(secret.getBytes, cipher)
+ encryptCipherInstance = Cipher.getInstance(cipher)
+ encryptCipherInstance.init(Cipher.ENCRYPT_MODE, secretKeySpec)
+ decryptCipherInstance = Cipher.getInstance(cipher)
+ decryptCipherInstance.init(Cipher.DECRYPT_MODE, secretKeySpec)
+ }
+ }
+
+ def issueToken(): String = {
+ if (supportSecureAccess()) {
+ encrypt(KyuubiInternalAccessIdentifier.newIdentifier(tokenMaxLifeTime).toJson)
+ } else {
+ throw new UnsupportedOperationException("Do not support issue secure token")
+ }
+ }
+
+ def authToken(tokenStr: String): Unit = {
+ if (supportSecureAccess()) {
+ val identifier = KyuubiInternalAccessIdentifier.fromJson(decrypt(tokenStr))
+ if (identifier.issueDate + identifier.maxDate > System.currentTimeMillis()) {
+ throw KyuubiSQLException("The engine access token is expired")
+ }
+ }
Review comment:
is it ok for the internal secure access mechanism?
It is still WIP.
cc @yaooqinn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1813: Enable the internal secure authentication between Kyuubi server and engine
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1813:
URL: https://github.com/apache/incubator-kyuubi/pull/1813#issuecomment-1018201691
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1813](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dbc9100) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/e4bf6003cda11a3b75648d59872378e3e9828096?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e4bf600) will **increase** coverage by `0.19%`.
> The diff coverage is `81.53%`.
> :exclamation: Current head dbc9100 differs from pull request most recent head 64dd712. Consider uploading reports for the commit 64dd712 to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1813 +/- ##
============================================
+ Coverage 59.80% 60.00% +0.19%
+ Complexity 263 262 -1
============================================
Files 274 279 +5
Lines 13655 13787 +132
Branches 1742 1750 +8
============================================
+ Hits 8167 8273 +106
- Misses 4792 4811 +19
- Partials 696 703 +7
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...apache/kyuubi/service/TBinaryFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL1RCaW5hcnlGcm9udGVuZFNlcnZpY2Uuc2NhbGE=) | `85.10% <ø> (-0.32%)` | :arrow_down: |
| [...authentication/AuthenticationProviderFactory.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0F1dGhlbnRpY2F0aW9uUHJvdmlkZXJGYWN0b3J5LnNjYWxh) | `53.84% <0.00%> (-7.03%)` | :arrow_down: |
| [...ation/EngineSecureAuthenticationProviderImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0VuZ2luZVNlY3VyZUF1dGhlbnRpY2F0aW9uUHJvdmlkZXJJbXBsLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...tion/ZooKeeperEngineSecureSecretProviderImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NlcnZpY2UvYXV0aGVudGljYXRpb24vWm9vS2VlcGVyRW5naW5lU2VjdXJlU2VjcmV0UHJvdmlkZXJJbXBsLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...e/authentication/KyuubiAuthenticationFactory.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0t5dXViaUF1dGhlbnRpY2F0aW9uRmFjdG9yeS5zY2FsYQ==) | `75.43% <33.33%> (-2.75%)` | :arrow_down: |
| [.../service/authentication/EngineSecureAccessor.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0VuZ2luZVNlY3VyZUFjY2Vzc29yLnNjYWxh) | `81.25% <81.25%> (ø)` | |
| [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `95.81% <100.00%> (+0.22%)` | :arrow_up: |
| [...a/org/apache/kyuubi/service/TFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL1RGcm9udGVuZFNlcnZpY2Uuc2NhbGE=) | `94.75% <100.00%> (+0.01%)` | :arrow_up: |
| [...ce/authentication/EngineSecureSecretProvider.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0VuZ2luZVNlY3VyZVNlY3JldFByb3ZpZGVyLnNjYWxh) | `100.00% <100.00%> (ø)` | |
| [...uthentication/KyuubiInternalAccessIdentifier.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0t5dXViaUludGVybmFsQWNjZXNzSWRlbnRpZmllci5zY2FsYQ==) | `100.00% <100.00%> (ø)` | |
| ... and [6 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e4bf600...64dd712](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on a change in pull request #1813: Enable the internal secure authentication between Kyuubi server and engine
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on a change in pull request #1813:
URL: https://github.com/apache/incubator-kyuubi/pull/1813#discussion_r792261717
##########
File path: kyuubi-common/src/main/scala/org/apache/kyuubi/service/authentication/EngineSecurityAccessor.scala
##########
@@ -0,0 +1,123 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.kyuubi.service.authentication
+
+import javax.crypto.Cipher
+import javax.crypto.spec.{IvParameterSpec, SecretKeySpec}
+
+import org.apache.kyuubi.{KyuubiSQLException, Logging}
+import org.apache.kyuubi.config.KyuubiConf
+import org.apache.kyuubi.config.KyuubiConf._
+
+class EngineSecurityAccessor(conf: KyuubiConf, val isServer: Boolean) {
+ val cryptoKeyLengthBytes = conf.get(ENGINE_SECURITY_CRYPTO_KEY_LENGTH) / java.lang.Byte.SIZE
+ val cryptoIvLength = conf.get(ENGINE_SECURITY_CRYPTO_IV_LENGTH)
+ val cryptoKeyAlgorithm = conf.get(ENGINE_SECURITY_CRYPTO_KEY_ALGORITHM)
+ val cryptoCipher = conf.get(ENGINE_SECURITY_CRYPTO_CIPHER_TRANSFORMATION)
+
+ private val tokenMaxLifeTime: Long = conf.get(ENGINE_SECURITY_TOKEN_MAX_LIFETIME)
+ private val provider: EngineSecuritySecretProvider = EngineSecuritySecretProvider.create(conf)
+ private val (encryptor, decryptor) =
+ initializeForAuth(cryptoCipher, normalizeSecret(provider.getSecret()))
+
+ private def initializeForAuth(cipher: String, secret: String): (Cipher, Cipher) = {
+ val secretKeySpec = new SecretKeySpec(secret.getBytes, cryptoKeyAlgorithm)
+ val nonce = new Array[Byte](cryptoIvLength)
+ val iv = new IvParameterSpec(nonce)
+
+ val _encryptor = Cipher.getInstance(cipher)
+ _encryptor.init(Cipher.ENCRYPT_MODE, secretKeySpec, iv)
+
+ val _decryptor = Cipher.getInstance(cipher)
+ _decryptor.init(Cipher.DECRYPT_MODE, secretKeySpec, iv)
+
+ (_encryptor, _decryptor)
+ }
+
+ def issueToken(): String = {
+ encrypt(KyuubiInternalAccessIdentifier.newIdentifier(tokenMaxLifeTime).toJson)
+ }
+
+ def authToken(tokenStr: String): Unit = {
+ val identifier =
+ try {
+ KyuubiInternalAccessIdentifier.fromJson(decrypt(tokenStr))
+ } catch {
+ case _: Exception =>
+ throw KyuubiSQLException("Invalid engine access token")
+ }
+ if (identifier.issueDate + identifier.maxDate < System.currentTimeMillis()) {
+ throw KyuubiSQLException("The engine access token is expired")
+ }
+ }
+
+ private[authentication] def encrypt(value: String): String = {
+ byteArrayToHexString(encryptor.doFinal(value.getBytes))
+ }
+
+ private[authentication] def decrypt(value: String): String = {
+ new String(decryptor.doFinal(hexStringToByteArray(value)))
+ }
+
+ private def normalizeSecret(secret: String): String = {
+ val normalizedSecret = new Array[Char](cryptoKeyLengthBytes)
+ val placeHolder = ' '
+ for (i <- 0 until cryptoKeyLengthBytes) {
+ if (i < secret.length) {
+ normalizedSecret.update(i, secret.charAt(i))
+ } else {
+ normalizedSecret.update(i, placeHolder)
+ }
+ }
+ new String(normalizedSecret)
+ }
+
+ private def hexStringToByteArray(str: String): Array[Byte] = {
+ val len = str.length
+ val data = new Array[Byte](len / 2)
Review comment:
assert(len % 2 == 0)
##########
File path: kyuubi-ha/src/main/scala/org/apache/kyuubi/service/authentication/ZooKeeperEngineSecuritySecretProviderImpl.scala
##########
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.kyuubi.service.authentication
+
+import java.nio.charset.StandardCharsets
+
+import org.apache.kyuubi.config.KyuubiConf
+import org.apache.kyuubi.ha.HighAvailabilityConf.HA_ZK_ENGINE_SECURE_SECRET_NODE
+import org.apache.kyuubi.ha.client.ZooKeeperClientProvider
+
+class ZooKeeperEngineSecuritySecretProviderImpl extends EngineSecuritySecretProvider {
+ import ZooKeeperClientProvider._
+
+ private var conf: KyuubiConf = _
+
+ override def initialize(conf: KyuubiConf): Unit = {
+ this.conf = conf
+ }
+
+ override def getSecret(): String = {
+ var secret: String = ""
+ conf.get(HA_ZK_ENGINE_SECURE_SECRET_NODE).map { zkNode =>
Review comment:
`assert (conf.get(HA_ZK_ENGINE_SECURE_SECRET_NODE).isDefined)`, avoid using `var secret` here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1813: Enable the internal secure authentication
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1813:
URL: https://github.com/apache/incubator-kyuubi/pull/1813#issuecomment-1018201691
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1813](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6043d2d) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/e4bf6003cda11a3b75648d59872378e3e9828096?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e4bf600) will **increase** coverage by `0.17%`.
> The diff coverage is `76.62%`.
> :exclamation: Current head 6043d2d differs from pull request most recent head 15ace65. Consider uploading reports for the commit 15ace65 to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1813 +/- ##
============================================
+ Coverage 59.80% 59.98% +0.17%
Complexity 263 263
============================================
Files 274 282 +8
Lines 13655 13811 +156
Branches 1742 1753 +11
============================================
+ Hits 8167 8285 +118
- Misses 4792 4820 +28
- Partials 696 706 +10
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...apache/kyuubi/service/TBinaryFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL1RCaW5hcnlGcm9udGVuZFNlcnZpY2Uuc2NhbGE=) | `85.10% <ø> (-0.32%)` | :arrow_down: |
| [...authentication/AuthenticationProviderFactory.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0F1dGhlbnRpY2F0aW9uUHJvdmlkZXJGYWN0b3J5LnNjYWxh) | `53.84% <0.00%> (-7.03%)` | :arrow_down: |
| [...he/kyuubi/service/authentication/CipherModes.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0NpcGhlck1vZGVzLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...ation/EngineSecureAuthenticationProviderImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0VuZ2luZVNlY3VyZUF1dGhlbnRpY2F0aW9uUHJvdmlkZXJJbXBsLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...tion/ZooKeeperEngineSecureSecretProviderImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NlcnZpY2UvYXV0aGVudGljYXRpb24vWm9vS2VlcGVyRW5naW5lU2VjdXJlU2VjcmV0UHJvdmlkZXJJbXBsLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...e/authentication/KyuubiAuthenticationFactory.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0t5dXViaUF1dGhlbnRpY2F0aW9uRmFjdG9yeS5zY2FsYQ==) | `74.13% <25.00%> (-4.05%)` | :arrow_down: |
| [.../org/apache/kyuubi/session/KyuubiSessionImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL0t5dXViaVNlc3Npb25JbXBsLnNjYWxh) | `80.00% <33.33%> (-4.22%)` | :arrow_down: |
| [.../service/authentication/EngineSecureAccessor.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0VuZ2luZVNlY3VyZUFjY2Vzc29yLnNjYWxh) | `78.84% <78.84%> (ø)` | |
| [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `95.68% <100.00%> (+0.09%)` | :arrow_up: |
| [...pache/kyuubi/security/EngineSecureCryptoConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZWN1cml0eS9FbmdpbmVTZWN1cmVDcnlwdG9Db25mLnNjYWxh) | `100.00% <100.00%> (ø)` | |
| ... and [9 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e4bf600...15ace65](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1813: [WIP] Enable the internal secure authentication
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1813:
URL: https://github.com/apache/incubator-kyuubi/pull/1813#issuecomment-1018201691
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1813](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b899731) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/e4bf6003cda11a3b75648d59872378e3e9828096?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e4bf600) will **increase** coverage by `0.09%`.
> The diff coverage is `71.30%`.
> :exclamation: Current head b899731 differs from pull request most recent head 3d937b0. Consider uploading reports for the commit 3d937b0 to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1813 +/- ##
============================================
+ Coverage 59.80% 59.90% +0.09%
Complexity 263 263
============================================
Files 274 279 +5
Lines 13655 13772 +117
Branches 1742 1750 +8
============================================
+ Hits 8167 8250 +83
- Misses 4792 4818 +26
- Partials 696 704 +8
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...apache/kyuubi/service/TBinaryFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL1RCaW5hcnlGcm9udGVuZFNlcnZpY2Uuc2NhbGE=) | `85.10% <ø> (-0.32%)` | :arrow_down: |
| [...authentication/AuthenticationProviderFactory.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0F1dGhlbnRpY2F0aW9uUHJvdmlkZXJGYWN0b3J5LnNjYWxh) | `53.84% <0.00%> (-7.03%)` | :arrow_down: |
| [...ation/EngineSecureAuthenticationProviderImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0VuZ2luZVNlY3VyZUF1dGhlbnRpY2F0aW9uUHJvdmlkZXJJbXBsLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...tion/ZooKeeperEngineSecureAccessProviderImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NlcnZpY2UvYXV0aGVudGljYXRpb24vWm9vS2VlcGVyRW5naW5lU2VjdXJlQWNjZXNzUHJvdmlkZXJJbXBsLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...e/authentication/KyuubiAuthenticationFactory.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0t5dXViaUF1dGhlbnRpY2F0aW9uRmFjdG9yeS5zY2FsYQ==) | `72.88% <20.00%> (-5.31%)` | :arrow_down: |
| [.../org/apache/kyuubi/session/KyuubiSessionImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL0t5dXViaVNlc3Npb25JbXBsLnNjYWxh) | `80.00% <33.33%> (-4.22%)` | :arrow_down: |
| [.../service/authentication/EngineSecureAccessor.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0VuZ2luZVNlY3VyZUFjY2Vzc29yLnNjYWxh) | `86.95% <86.95%> (ø)` | |
| [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `95.68% <100.00%> (+0.09%)` | :arrow_up: |
| [...a/org/apache/kyuubi/service/TFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL1RGcm9udGVuZFNlcnZpY2Uuc2NhbGE=) | `94.75% <100.00%> (+0.01%)` | :arrow_up: |
| [...uthentication/KyuubiInternalAccessIdentifier.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0t5dXViaUludGVybmFsQWNjZXNzSWRlbnRpZmllci5zY2FsYQ==) | `100.00% <100.00%> (ø)` | |
| ... and [5 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e4bf600...3d937b0](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1813: [WIP] Enable the internal secure authentication
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1813:
URL: https://github.com/apache/incubator-kyuubi/pull/1813#issuecomment-1018201691
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1813](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b899731) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/e4bf6003cda11a3b75648d59872378e3e9828096?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e4bf600) will **increase** coverage by `0.09%`.
> The diff coverage is `71.30%`.
> :exclamation: Current head b899731 differs from pull request most recent head 6043d2d. Consider uploading reports for the commit 6043d2d to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1813 +/- ##
============================================
+ Coverage 59.80% 59.90% +0.09%
Complexity 263 263
============================================
Files 274 279 +5
Lines 13655 13772 +117
Branches 1742 1750 +8
============================================
+ Hits 8167 8250 +83
- Misses 4792 4818 +26
- Partials 696 704 +8
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...apache/kyuubi/service/TBinaryFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL1RCaW5hcnlGcm9udGVuZFNlcnZpY2Uuc2NhbGE=) | `85.10% <ø> (-0.32%)` | :arrow_down: |
| [...authentication/AuthenticationProviderFactory.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0F1dGhlbnRpY2F0aW9uUHJvdmlkZXJGYWN0b3J5LnNjYWxh) | `53.84% <0.00%> (-7.03%)` | :arrow_down: |
| [...ation/EngineSecureAuthenticationProviderImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0VuZ2luZVNlY3VyZUF1dGhlbnRpY2F0aW9uUHJvdmlkZXJJbXBsLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...tion/ZooKeeperEngineSecureAccessProviderImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NlcnZpY2UvYXV0aGVudGljYXRpb24vWm9vS2VlcGVyRW5naW5lU2VjdXJlQWNjZXNzUHJvdmlkZXJJbXBsLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...e/authentication/KyuubiAuthenticationFactory.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0t5dXViaUF1dGhlbnRpY2F0aW9uRmFjdG9yeS5zY2FsYQ==) | `72.88% <20.00%> (-5.31%)` | :arrow_down: |
| [.../org/apache/kyuubi/session/KyuubiSessionImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL0t5dXViaVNlc3Npb25JbXBsLnNjYWxh) | `80.00% <33.33%> (-4.22%)` | :arrow_down: |
| [.../service/authentication/EngineSecureAccessor.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0VuZ2luZVNlY3VyZUFjY2Vzc29yLnNjYWxh) | `86.95% <86.95%> (ø)` | |
| [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `95.68% <100.00%> (+0.09%)` | :arrow_up: |
| [...a/org/apache/kyuubi/service/TFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL1RGcm9udGVuZFNlcnZpY2Uuc2NhbGE=) | `94.75% <100.00%> (+0.01%)` | :arrow_up: |
| [...uthentication/KyuubiInternalAccessIdentifier.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0t5dXViaUludGVybmFsQWNjZXNzSWRlbnRpZmllci5zY2FsYQ==) | `100.00% <100.00%> (ø)` | |
| ... and [5 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e4bf600...6043d2d](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1813: Enable the internal secure authentication between Kyuubi server and engine
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1813:
URL: https://github.com/apache/incubator-kyuubi/pull/1813#issuecomment-1018201691
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1813](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9e252fe) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/e4bf6003cda11a3b75648d59872378e3e9828096?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e4bf600) will **increase** coverage by `0.20%`.
> The diff coverage is `81.67%`.
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1813 +/- ##
============================================
+ Coverage 59.80% 60.01% +0.20%
Complexity 263 263
============================================
Files 274 279 +5
Lines 13655 13788 +133
Branches 1742 1750 +8
============================================
+ Hits 8167 8275 +108
- Misses 4792 4811 +19
- Partials 696 702 +6
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...apache/kyuubi/service/TBinaryFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL1RCaW5hcnlGcm9udGVuZFNlcnZpY2Uuc2NhbGE=) | `85.10% <ø> (-0.32%)` | :arrow_down: |
| [...authentication/AuthenticationProviderFactory.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0F1dGhlbnRpY2F0aW9uUHJvdmlkZXJGYWN0b3J5LnNjYWxh) | `53.84% <0.00%> (-7.03%)` | :arrow_down: |
| [...ation/EngineSecureAuthenticationProviderImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0VuZ2luZVNlY3VyZUF1dGhlbnRpY2F0aW9uUHJvdmlkZXJJbXBsLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...tion/ZooKeeperEngineSecureSecretProviderImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NlcnZpY2UvYXV0aGVudGljYXRpb24vWm9vS2VlcGVyRW5naW5lU2VjdXJlU2VjcmV0UHJvdmlkZXJJbXBsLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...e/authentication/KyuubiAuthenticationFactory.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0t5dXViaUF1dGhlbnRpY2F0aW9uRmFjdG9yeS5zY2FsYQ==) | `75.43% <33.33%> (-2.75%)` | :arrow_down: |
| [.../service/authentication/EngineSecureAccessor.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0VuZ2luZVNlY3VyZUFjY2Vzc29yLnNjYWxh) | `81.63% <81.63%> (ø)` | |
| [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `95.81% <100.00%> (+0.22%)` | :arrow_up: |
| [...a/org/apache/kyuubi/service/TFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL1RGcm9udGVuZFNlcnZpY2Uuc2NhbGE=) | `94.75% <100.00%> (+0.01%)` | :arrow_up: |
| [...ce/authentication/EngineSecureSecretProvider.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0VuZ2luZVNlY3VyZVNlY3JldFByb3ZpZGVyLnNjYWxh) | `100.00% <100.00%> (ø)` | |
| [...uthentication/KyuubiInternalAccessIdentifier.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0t5dXViaUludGVybmFsQWNjZXNzSWRlbnRpZmllci5zY2FsYQ==) | `100.00% <100.00%> (ø)` | |
| ... and [5 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e4bf600...9e252fe](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on pull request #1813: Enable the internal secure authentication between Kyuubi server and engine
Posted by GitBox <gi...@apache.org>.
turboFei commented on pull request #1813:
URL: https://github.com/apache/incubator-kyuubi/pull/1813#issuecomment-1021952413
> What happens if the token is outdate ? we don't have a renew process. Seems it will cause user can not use Kyuubi until the session timeout ?
Now we issue a new token for each kyuubiSession.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1813: [WIP] Enable the internal secure authentication
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1813:
URL: https://github.com/apache/incubator-kyuubi/pull/1813#issuecomment-1018201691
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1813](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6043d2d) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/e4bf6003cda11a3b75648d59872378e3e9828096?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e4bf600) will **increase** coverage by `0.17%`.
> The diff coverage is `76.62%`.
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1813 +/- ##
============================================
+ Coverage 59.80% 59.98% +0.17%
Complexity 263 263
============================================
Files 274 282 +8
Lines 13655 13811 +156
Branches 1742 1753 +11
============================================
+ Hits 8167 8285 +118
- Misses 4792 4820 +28
- Partials 696 706 +10
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...apache/kyuubi/service/TBinaryFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL1RCaW5hcnlGcm9udGVuZFNlcnZpY2Uuc2NhbGE=) | `85.10% <ø> (-0.32%)` | :arrow_down: |
| [...authentication/AuthenticationProviderFactory.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0F1dGhlbnRpY2F0aW9uUHJvdmlkZXJGYWN0b3J5LnNjYWxh) | `53.84% <0.00%> (-7.03%)` | :arrow_down: |
| [...he/kyuubi/service/authentication/CipherModes.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0NpcGhlck1vZGVzLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...ation/EngineSecureAuthenticationProviderImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0VuZ2luZVNlY3VyZUF1dGhlbnRpY2F0aW9uUHJvdmlkZXJJbXBsLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...tion/ZooKeeperEngineSecureSecretProviderImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NlcnZpY2UvYXV0aGVudGljYXRpb24vWm9vS2VlcGVyRW5naW5lU2VjdXJlU2VjcmV0UHJvdmlkZXJJbXBsLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...e/authentication/KyuubiAuthenticationFactory.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0t5dXViaUF1dGhlbnRpY2F0aW9uRmFjdG9yeS5zY2FsYQ==) | `74.13% <25.00%> (-4.05%)` | :arrow_down: |
| [.../org/apache/kyuubi/session/KyuubiSessionImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL0t5dXViaVNlc3Npb25JbXBsLnNjYWxh) | `80.00% <33.33%> (-4.22%)` | :arrow_down: |
| [.../service/authentication/EngineSecureAccessor.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0VuZ2luZVNlY3VyZUFjY2Vzc29yLnNjYWxh) | `78.84% <78.84%> (ø)` | |
| [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `95.68% <100.00%> (+0.09%)` | :arrow_up: |
| [...pache/kyuubi/security/EngineSecureCryptoConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZWN1cml0eS9FbmdpbmVTZWN1cmVDcnlwdG9Db25mLnNjYWxh) | `100.00% <100.00%> (ø)` | |
| ... and [9 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e4bf600...6043d2d](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] turboFei edited a comment on pull request #1813: Enable the internal secure authentication between Kyuubi server and engine
Posted by GitBox <gi...@apache.org>.
turboFei edited a comment on pull request #1813:
URL: https://github.com/apache/incubator-kyuubi/pull/1813#issuecomment-1021952413
> What happens if the token is outdate ? we don't have a renew process. Seems it will cause user can not use Kyuubi until the session timeout ?
Now we issue a new token for each kyuubiSession every time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] ulysses-you closed pull request #1813: Enable the internal secure authentication between Kyuubi server and engine
Posted by GitBox <gi...@apache.org>.
ulysses-you closed pull request #1813:
URL: https://github.com/apache/incubator-kyuubi/pull/1813
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1813: Enable the internal secure authentication between Kyuubi server and engine
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1813:
URL: https://github.com/apache/incubator-kyuubi/pull/1813#issuecomment-1018201691
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1813](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dbc9100) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/e4bf6003cda11a3b75648d59872378e3e9828096?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e4bf600) will **increase** coverage by `0.19%`.
> The diff coverage is `81.53%`.
> :exclamation: Current head dbc9100 differs from pull request most recent head 9e252fe. Consider uploading reports for the commit 9e252fe to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1813 +/- ##
============================================
+ Coverage 59.80% 60.00% +0.19%
+ Complexity 263 262 -1
============================================
Files 274 279 +5
Lines 13655 13787 +132
Branches 1742 1750 +8
============================================
+ Hits 8167 8273 +106
- Misses 4792 4811 +19
- Partials 696 703 +7
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...apache/kyuubi/service/TBinaryFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL1RCaW5hcnlGcm9udGVuZFNlcnZpY2Uuc2NhbGE=) | `85.10% <ø> (-0.32%)` | :arrow_down: |
| [...authentication/AuthenticationProviderFactory.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0F1dGhlbnRpY2F0aW9uUHJvdmlkZXJGYWN0b3J5LnNjYWxh) | `53.84% <0.00%> (-7.03%)` | :arrow_down: |
| [...ation/EngineSecureAuthenticationProviderImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0VuZ2luZVNlY3VyZUF1dGhlbnRpY2F0aW9uUHJvdmlkZXJJbXBsLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...tion/ZooKeeperEngineSecureSecretProviderImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NlcnZpY2UvYXV0aGVudGljYXRpb24vWm9vS2VlcGVyRW5naW5lU2VjdXJlU2VjcmV0UHJvdmlkZXJJbXBsLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...e/authentication/KyuubiAuthenticationFactory.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0t5dXViaUF1dGhlbnRpY2F0aW9uRmFjdG9yeS5zY2FsYQ==) | `75.43% <33.33%> (-2.75%)` | :arrow_down: |
| [.../service/authentication/EngineSecureAccessor.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0VuZ2luZVNlY3VyZUFjY2Vzc29yLnNjYWxh) | `81.25% <81.25%> (ø)` | |
| [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `95.81% <100.00%> (+0.22%)` | :arrow_up: |
| [...a/org/apache/kyuubi/service/TFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL1RGcm9udGVuZFNlcnZpY2Uuc2NhbGE=) | `94.75% <100.00%> (+0.01%)` | :arrow_up: |
| [...ce/authentication/EngineSecureSecretProvider.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0VuZ2luZVNlY3VyZVNlY3JldFByb3ZpZGVyLnNjYWxh) | `100.00% <100.00%> (ø)` | |
| [...uthentication/KyuubiInternalAccessIdentifier.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0t5dXViaUludGVybmFsQWNjZXNzSWRlbnRpZmllci5zY2FsYQ==) | `100.00% <100.00%> (ø)` | |
| ... and [6 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e4bf600...9e252fe](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1813: Enable the internal secure authentication between Kyuubi server and engine
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1813:
URL: https://github.com/apache/incubator-kyuubi/pull/1813#issuecomment-1018201691
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1813](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (64dd712) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/e4bf6003cda11a3b75648d59872378e3e9828096?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e4bf600) will **increase** coverage by `0.19%`.
> The diff coverage is `81.67%`.
> :exclamation: Current head 64dd712 differs from pull request most recent head e1266e3. Consider uploading reports for the commit e1266e3 to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1813 +/- ##
============================================
+ Coverage 59.80% 60.00% +0.19%
Complexity 263 263
============================================
Files 274 279 +5
Lines 13655 13788 +133
Branches 1742 1750 +8
============================================
+ Hits 8167 8274 +107
- Misses 4792 4811 +19
- Partials 696 703 +7
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...apache/kyuubi/service/TBinaryFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL1RCaW5hcnlGcm9udGVuZFNlcnZpY2Uuc2NhbGE=) | `85.10% <ø> (-0.32%)` | :arrow_down: |
| [...authentication/AuthenticationProviderFactory.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0F1dGhlbnRpY2F0aW9uUHJvdmlkZXJGYWN0b3J5LnNjYWxh) | `53.84% <0.00%> (-7.03%)` | :arrow_down: |
| [...ation/EngineSecureAuthenticationProviderImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0VuZ2luZVNlY3VyZUF1dGhlbnRpY2F0aW9uUHJvdmlkZXJJbXBsLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...tion/ZooKeeperEngineSecureSecretProviderImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NlcnZpY2UvYXV0aGVudGljYXRpb24vWm9vS2VlcGVyRW5naW5lU2VjdXJlU2VjcmV0UHJvdmlkZXJJbXBsLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...e/authentication/KyuubiAuthenticationFactory.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0t5dXViaUF1dGhlbnRpY2F0aW9uRmFjdG9yeS5zY2FsYQ==) | `75.43% <33.33%> (-2.75%)` | :arrow_down: |
| [.../service/authentication/EngineSecureAccessor.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0VuZ2luZVNlY3VyZUFjY2Vzc29yLnNjYWxh) | `81.63% <81.63%> (ø)` | |
| [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `95.81% <100.00%> (+0.22%)` | :arrow_up: |
| [...a/org/apache/kyuubi/service/TFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL1RGcm9udGVuZFNlcnZpY2Uuc2NhbGE=) | `94.75% <100.00%> (+0.01%)` | :arrow_up: |
| [...ce/authentication/EngineSecureSecretProvider.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0VuZ2luZVNlY3VyZVNlY3JldFByb3ZpZGVyLnNjYWxh) | `100.00% <100.00%> (ø)` | |
| [...uthentication/KyuubiInternalAccessIdentifier.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0t5dXViaUludGVybmFsQWNjZXNzSWRlbnRpZmllci5zY2FsYQ==) | `100.00% <100.00%> (ø)` | |
| ... and [6 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e4bf600...e1266e3](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on pull request #1813: Enable the internal secure authentication between Kyuubi server and engine
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on pull request #1813:
URL: https://github.com/apache/incubator-kyuubi/pull/1813#issuecomment-1022892235
thanks, merging to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1813: Enable the internal secure authentication between Kyuubi server and engine
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1813:
URL: https://github.com/apache/incubator-kyuubi/pull/1813#issuecomment-1018201691
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1813](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b545281) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/e4bf6003cda11a3b75648d59872378e3e9828096?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e4bf600) will **increase** coverage by `0.05%`.
> The diff coverage is `84.93%`.
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1813 +/- ##
============================================
+ Coverage 59.80% 59.86% +0.05%
- Complexity 263 271 +8
============================================
Files 274 280 +6
Lines 13655 13915 +260
Branches 1742 1771 +29
============================================
+ Hits 8167 8330 +163
- Misses 4792 4879 +87
- Partials 696 706 +10
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...apache/kyuubi/service/TBinaryFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL1RCaW5hcnlGcm9udGVuZFNlcnZpY2Uuc2NhbGE=) | `85.10% <ø> (-0.32%)` | :arrow_down: |
| [...ation/EngineSecureAuthenticationProviderImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0VuZ2luZVNlY3VyZUF1dGhlbnRpY2F0aW9uUHJvdmlkZXJJbXBsLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...on/ZooKeeperEngineSecuritySecretProviderImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NlcnZpY2UvYXV0aGVudGljYXRpb24vWm9vS2VlcGVyRW5naW5lU2VjdXJpdHlTZWNyZXRQcm92aWRlckltcGwuc2NhbGE=) | `0.00% <0.00%> (ø)` | |
| [...e/authentication/KyuubiAuthenticationFactory.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0t5dXViaUF1dGhlbnRpY2F0aW9uRmFjdG9yeS5zY2FsYQ==) | `75.86% <60.00%> (-2.32%)` | :arrow_down: |
| [...authentication/AuthenticationProviderFactory.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0F1dGhlbnRpY2F0aW9uUHJvdmlkZXJGYWN0b3J5LnNjYWxh) | `63.33% <71.42%> (+2.46%)` | :arrow_up: |
| [...ervice/authentication/EngineSecurityAccessor.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0VuZ2luZVNlY3VyaXR5QWNjZXNzb3Iuc2NhbGE=) | `83.67% <83.67%> (ø)` | |
| [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `95.81% <100.00%> (+0.22%)` | :arrow_up: |
| [...a/org/apache/kyuubi/service/TFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL1RGcm9udGVuZFNlcnZpY2Uuc2NhbGE=) | `94.75% <100.00%> (+0.01%)` | :arrow_up: |
| [.../authentication/EngineSecuritySecretProvider.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0VuZ2luZVNlY3VyaXR5U2VjcmV0UHJvdmlkZXIuc2NhbGE=) | `100.00% <100.00%> (ø)` | |
| [...uthentication/KyuubiInternalAccessIdentifier.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0t5dXViaUludGVybmFsQWNjZXNzSWRlbnRpZmllci5zY2FsYQ==) | `100.00% <100.00%> (ø)` | |
| ... and [13 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e4bf600...b545281](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1813: Enable the internal secure authentication between Kyuubi server and engine
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1813:
URL: https://github.com/apache/incubator-kyuubi/pull/1813#issuecomment-1018201691
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1813](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b545281) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/e4bf6003cda11a3b75648d59872378e3e9828096?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e4bf600) will **increase** coverage by `0.05%`.
> The diff coverage is `84.93%`.
> :exclamation: Current head b545281 differs from pull request most recent head 34354d9. Consider uploading reports for the commit 34354d9 to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1813 +/- ##
============================================
+ Coverage 59.80% 59.86% +0.05%
- Complexity 263 271 +8
============================================
Files 274 280 +6
Lines 13655 13915 +260
Branches 1742 1771 +29
============================================
+ Hits 8167 8330 +163
- Misses 4792 4879 +87
- Partials 696 706 +10
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...apache/kyuubi/service/TBinaryFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL1RCaW5hcnlGcm9udGVuZFNlcnZpY2Uuc2NhbGE=) | `85.10% <ø> (-0.32%)` | :arrow_down: |
| [...ation/EngineSecureAuthenticationProviderImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0VuZ2luZVNlY3VyZUF1dGhlbnRpY2F0aW9uUHJvdmlkZXJJbXBsLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...on/ZooKeeperEngineSecuritySecretProviderImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NlcnZpY2UvYXV0aGVudGljYXRpb24vWm9vS2VlcGVyRW5naW5lU2VjdXJpdHlTZWNyZXRQcm92aWRlckltcGwuc2NhbGE=) | `0.00% <0.00%> (ø)` | |
| [...e/authentication/KyuubiAuthenticationFactory.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0t5dXViaUF1dGhlbnRpY2F0aW9uRmFjdG9yeS5zY2FsYQ==) | `75.86% <60.00%> (-2.32%)` | :arrow_down: |
| [...authentication/AuthenticationProviderFactory.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0F1dGhlbnRpY2F0aW9uUHJvdmlkZXJGYWN0b3J5LnNjYWxh) | `63.33% <71.42%> (+2.46%)` | :arrow_up: |
| [...ervice/authentication/EngineSecurityAccessor.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0VuZ2luZVNlY3VyaXR5QWNjZXNzb3Iuc2NhbGE=) | `83.67% <83.67%> (ø)` | |
| [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `95.81% <100.00%> (+0.22%)` | :arrow_up: |
| [...a/org/apache/kyuubi/service/TFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL1RGcm9udGVuZFNlcnZpY2Uuc2NhbGE=) | `94.75% <100.00%> (+0.01%)` | :arrow_up: |
| [.../authentication/EngineSecuritySecretProvider.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0VuZ2luZVNlY3VyaXR5U2VjcmV0UHJvdmlkZXIuc2NhbGE=) | `100.00% <100.00%> (ø)` | |
| [...uthentication/KyuubiInternalAccessIdentifier.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0t5dXViaUludGVybmFsQWNjZXNzSWRlbnRpZmllci5zY2FsYQ==) | `100.00% <100.00%> (ø)` | |
| ... and [13 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e4bf600...34354d9](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1813: Enable the internal secure authentication between Kyuubi server and engine
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1813:
URL: https://github.com/apache/incubator-kyuubi/pull/1813#issuecomment-1018201691
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1813](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (64dd712) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/e4bf6003cda11a3b75648d59872378e3e9828096?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e4bf600) will **increase** coverage by `0.19%`.
> The diff coverage is `81.67%`.
> :exclamation: Current head 64dd712 differs from pull request most recent head 9e252fe. Consider uploading reports for the commit 9e252fe to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1813 +/- ##
============================================
+ Coverage 59.80% 60.00% +0.19%
Complexity 263 263
============================================
Files 274 279 +5
Lines 13655 13788 +133
Branches 1742 1750 +8
============================================
+ Hits 8167 8274 +107
- Misses 4792 4811 +19
- Partials 696 703 +7
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...apache/kyuubi/service/TBinaryFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL1RCaW5hcnlGcm9udGVuZFNlcnZpY2Uuc2NhbGE=) | `85.10% <ø> (-0.32%)` | :arrow_down: |
| [...authentication/AuthenticationProviderFactory.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0F1dGhlbnRpY2F0aW9uUHJvdmlkZXJGYWN0b3J5LnNjYWxh) | `53.84% <0.00%> (-7.03%)` | :arrow_down: |
| [...ation/EngineSecureAuthenticationProviderImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0VuZ2luZVNlY3VyZUF1dGhlbnRpY2F0aW9uUHJvdmlkZXJJbXBsLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...tion/ZooKeeperEngineSecureSecretProviderImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NlcnZpY2UvYXV0aGVudGljYXRpb24vWm9vS2VlcGVyRW5naW5lU2VjdXJlU2VjcmV0UHJvdmlkZXJJbXBsLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...e/authentication/KyuubiAuthenticationFactory.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0t5dXViaUF1dGhlbnRpY2F0aW9uRmFjdG9yeS5zY2FsYQ==) | `75.43% <33.33%> (-2.75%)` | :arrow_down: |
| [.../service/authentication/EngineSecureAccessor.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0VuZ2luZVNlY3VyZUFjY2Vzc29yLnNjYWxh) | `81.63% <81.63%> (ø)` | |
| [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `95.81% <100.00%> (+0.22%)` | :arrow_up: |
| [...a/org/apache/kyuubi/service/TFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL1RGcm9udGVuZFNlcnZpY2Uuc2NhbGE=) | `94.75% <100.00%> (+0.01%)` | :arrow_up: |
| [...ce/authentication/EngineSecureSecretProvider.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0VuZ2luZVNlY3VyZVNlY3JldFByb3ZpZGVyLnNjYWxh) | `100.00% <100.00%> (ø)` | |
| [...uthentication/KyuubiInternalAccessIdentifier.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0t5dXViaUludGVybmFsQWNjZXNzSWRlbnRpZmllci5zY2FsYQ==) | `100.00% <100.00%> (ø)` | |
| ... and [6 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e4bf600...9e252fe](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1813: [WIP] Enable the internal secure authentication
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1813:
URL: https://github.com/apache/incubator-kyuubi/pull/1813#issuecomment-1018201691
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1813](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b997095) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/e4bf6003cda11a3b75648d59872378e3e9828096?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e4bf600) will **increase** coverage by `0.09%`.
> The diff coverage is `74.19%`.
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1813 +/- ##
============================================
+ Coverage 59.80% 59.90% +0.09%
+ Complexity 263 262 -1
============================================
Files 274 279 +5
Lines 13655 13776 +121
Branches 1742 1749 +7
============================================
+ Hits 8167 8253 +86
- Misses 4792 4817 +25
- Partials 696 706 +10
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...apache/kyuubi/service/TBinaryFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL1RCaW5hcnlGcm9udGVuZFNlcnZpY2Uuc2NhbGE=) | `85.10% <ø> (-0.32%)` | :arrow_down: |
| [...ation/EngineSecureAuthenticationProviderImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0VuZ2luZVNlY3VyZUF1dGhlbnRpY2F0aW9uUHJvdmlkZXJJbXBsLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...tion/ZooKeeperEngineSecureAccessProviderImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NlcnZpY2UvYXV0aGVudGljYXRpb24vWm9vS2VlcGVyRW5naW5lU2VjdXJlQWNjZXNzUHJvdmlkZXJJbXBsLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...authentication/AuthenticationProviderFactory.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0F1dGhlbnRpY2F0aW9uUHJvdmlkZXJGYWN0b3J5LnNjYWxh) | `56.00% <33.33%> (-4.87%)` | :arrow_down: |
| [...e/authentication/KyuubiAuthenticationFactory.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0t5dXViaUF1dGhlbnRpY2F0aW9uRmFjdG9yeS5zY2FsYQ==) | `73.33% <33.33%> (-4.85%)` | :arrow_down: |
| [.../org/apache/kyuubi/session/KyuubiSessionImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL0t5dXViaVNlc3Npb25JbXBsLnNjYWxh) | `80.00% <33.33%> (-4.22%)` | :arrow_down: |
| [.../service/authentication/EngineSecureAccessor.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0VuZ2luZVNlY3VyZUFjY2Vzc29yLnNjYWxh) | `86.95% <86.95%> (ø)` | |
| [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `95.68% <100.00%> (+0.09%)` | :arrow_up: |
| [...la/org/apache/kyuubi/service/FrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL0Zyb250ZW5kU2VydmljZS5zY2FsYQ==) | `100.00% <100.00%> (ø)` | |
| [...a/org/apache/kyuubi/service/TFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL1RGcm9udGVuZFNlcnZpY2Uuc2NhbGE=) | `94.73% <100.00%> (ø)` | |
| ... and [9 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e4bf600...b997095](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1813: [WIP] Enable the internal secure authentication
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1813:
URL: https://github.com/apache/incubator-kyuubi/pull/1813#issuecomment-1018201691
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1813](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b899731) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/e4bf6003cda11a3b75648d59872378e3e9828096?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e4bf600) will **increase** coverage by `0.09%`.
> The diff coverage is `71.30%`.
> :exclamation: Current head b899731 differs from pull request most recent head ad777cb. Consider uploading reports for the commit ad777cb to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1813 +/- ##
============================================
+ Coverage 59.80% 59.90% +0.09%
Complexity 263 263
============================================
Files 274 279 +5
Lines 13655 13772 +117
Branches 1742 1750 +8
============================================
+ Hits 8167 8250 +83
- Misses 4792 4818 +26
- Partials 696 704 +8
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...apache/kyuubi/service/TBinaryFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL1RCaW5hcnlGcm9udGVuZFNlcnZpY2Uuc2NhbGE=) | `85.10% <ø> (-0.32%)` | :arrow_down: |
| [...authentication/AuthenticationProviderFactory.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0F1dGhlbnRpY2F0aW9uUHJvdmlkZXJGYWN0b3J5LnNjYWxh) | `53.84% <0.00%> (-7.03%)` | :arrow_down: |
| [...ation/EngineSecureAuthenticationProviderImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0VuZ2luZVNlY3VyZUF1dGhlbnRpY2F0aW9uUHJvdmlkZXJJbXBsLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...tion/ZooKeeperEngineSecureAccessProviderImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NlcnZpY2UvYXV0aGVudGljYXRpb24vWm9vS2VlcGVyRW5naW5lU2VjdXJlQWNjZXNzUHJvdmlkZXJJbXBsLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...e/authentication/KyuubiAuthenticationFactory.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0t5dXViaUF1dGhlbnRpY2F0aW9uRmFjdG9yeS5zY2FsYQ==) | `72.88% <20.00%> (-5.31%)` | :arrow_down: |
| [.../org/apache/kyuubi/session/KyuubiSessionImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL0t5dXViaVNlc3Npb25JbXBsLnNjYWxh) | `80.00% <33.33%> (-4.22%)` | :arrow_down: |
| [.../service/authentication/EngineSecureAccessor.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0VuZ2luZVNlY3VyZUFjY2Vzc29yLnNjYWxh) | `86.95% <86.95%> (ø)` | |
| [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `95.68% <100.00%> (+0.09%)` | :arrow_up: |
| [...a/org/apache/kyuubi/service/TFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL1RGcm9udGVuZFNlcnZpY2Uuc2NhbGE=) | `94.75% <100.00%> (+0.01%)` | :arrow_up: |
| [...uthentication/KyuubiInternalAccessIdentifier.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0t5dXViaUludGVybmFsQWNjZXNzSWRlbnRpZmllci5zY2FsYQ==) | `100.00% <100.00%> (ø)` | |
| ... and [5 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e4bf600...ad777cb](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on a change in pull request #1813: Enable the internal secure authentication between Kyuubi server and engine
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on a change in pull request #1813:
URL: https://github.com/apache/incubator-kyuubi/pull/1813#discussion_r791300041
##########
File path: kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala
##########
@@ -1070,6 +1070,59 @@ object KyuubiConf {
.stringConf
.createWithDefault("engine_operation_logs")
+ val ENGINE_SECURE_ENABLED: ConfigEntry[Boolean] =
+ buildConf("engine.secure.enabled")
+ .doc("Whether to enable the internal secure access between Kyuubi server and engine.")
+ .version("1.5.0")
+ .booleanConf
+ .createWithDefault(false)
+
+ val ENGINE_SECURE_TOKEN_MAX_LIFETIME: ConfigEntry[Long] =
+ buildConf("engine.secure.token.max.lifetime")
+ .doc("The max lifetime of the token used for secure access between Kyuubi server and engine.")
+ .version("1.5.0")
+ .timeConf
+ .createWithDefault(Duration.ofMinutes(10).toMillis)
+
+ val ENGINE_SECURE_SECRET_PROVIDER: ConfigEntry[String] =
+ buildConf("engine.secure.secret.provider")
+ .doc("The class used to manage the engine secure access secret. This class must be a " +
+ "subclass of EngineSecureAccessSecretProvider.")
Review comment:
seems the class name `EngineSecureAccessSecretProvider` is wrong.
##########
File path: kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala
##########
@@ -1070,6 +1070,59 @@ object KyuubiConf {
.stringConf
.createWithDefault("engine_operation_logs")
+ val ENGINE_SECURE_ENABLED: ConfigEntry[Boolean] =
+ buildConf("engine.secure.enabled")
Review comment:
security ?
##########
File path: kyuubi-common/src/main/scala/org/apache/kyuubi/service/authentication/AuthenticationProviderFactory.scala
##########
@@ -30,6 +30,10 @@ object AuthenticationProviderFactory {
def getAuthenticationProvider(
method: AuthMethod,
conf: KyuubiConf): PasswdAuthenticationProvider = method match {
+ case _
+ if conf.get(KyuubiConf.ENGINE_SECURE_ENABLED) &&
+ !EngineSecureAccessor.get().isServer =>
+ new EngineSecureAuthenticationProviderImpl
Review comment:
the key here is `isServer` so can we make it clearly like:
```
def getAuthenticationProvider(
method: AuthMethod,
conf: KyuubiConf): PasswdAuthenticationProvider = {
if (isServer) {
getAuthenticationProviderForServer()
} else {
getAuthenticationProviderForEngine()
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on a change in pull request #1813: Enable the internal secure authentication between Kyuubi server and engine
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on a change in pull request #1813:
URL: https://github.com/apache/incubator-kyuubi/pull/1813#discussion_r791300041
##########
File path: kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala
##########
@@ -1070,6 +1070,59 @@ object KyuubiConf {
.stringConf
.createWithDefault("engine_operation_logs")
+ val ENGINE_SECURE_ENABLED: ConfigEntry[Boolean] =
+ buildConf("engine.secure.enabled")
+ .doc("Whether to enable the internal secure access between Kyuubi server and engine.")
+ .version("1.5.0")
+ .booleanConf
+ .createWithDefault(false)
+
+ val ENGINE_SECURE_TOKEN_MAX_LIFETIME: ConfigEntry[Long] =
+ buildConf("engine.secure.token.max.lifetime")
+ .doc("The max lifetime of the token used for secure access between Kyuubi server and engine.")
+ .version("1.5.0")
+ .timeConf
+ .createWithDefault(Duration.ofMinutes(10).toMillis)
+
+ val ENGINE_SECURE_SECRET_PROVIDER: ConfigEntry[String] =
+ buildConf("engine.secure.secret.provider")
+ .doc("The class used to manage the engine secure access secret. This class must be a " +
+ "subclass of EngineSecureAccessSecretProvider.")
Review comment:
seems the class name `EngineSecureAccessSecretProvider` is wrong.
##########
File path: kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala
##########
@@ -1070,6 +1070,59 @@ object KyuubiConf {
.stringConf
.createWithDefault("engine_operation_logs")
+ val ENGINE_SECURE_ENABLED: ConfigEntry[Boolean] =
+ buildConf("engine.secure.enabled")
Review comment:
security ?
##########
File path: kyuubi-common/src/main/scala/org/apache/kyuubi/service/authentication/AuthenticationProviderFactory.scala
##########
@@ -30,6 +30,10 @@ object AuthenticationProviderFactory {
def getAuthenticationProvider(
method: AuthMethod,
conf: KyuubiConf): PasswdAuthenticationProvider = method match {
+ case _
+ if conf.get(KyuubiConf.ENGINE_SECURE_ENABLED) &&
+ !EngineSecureAccessor.get().isServer =>
+ new EngineSecureAuthenticationProviderImpl
Review comment:
the key here is `isServer` so can we make it clearly like:
```
def getAuthenticationProvider(
method: AuthMethod,
conf: KyuubiConf): PasswdAuthenticationProvider = {
if (isServer) {
getAuthenticationProviderForServer()
} else {
getAuthenticationProviderForEngine()
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1813: [WIP] Enable the internal secure authentication
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1813:
URL: https://github.com/apache/incubator-kyuubi/pull/1813#issuecomment-1018201691
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1813](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b997095) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/e4bf6003cda11a3b75648d59872378e3e9828096?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e4bf600) will **increase** coverage by `0.09%`.
> The diff coverage is `74.19%`.
> :exclamation: Current head b997095 differs from pull request most recent head 1e16364. Consider uploading reports for the commit 1e16364 to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1813 +/- ##
============================================
+ Coverage 59.80% 59.90% +0.09%
+ Complexity 263 262 -1
============================================
Files 274 279 +5
Lines 13655 13776 +121
Branches 1742 1749 +7
============================================
+ Hits 8167 8253 +86
- Misses 4792 4817 +25
- Partials 696 706 +10
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...apache/kyuubi/service/TBinaryFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL1RCaW5hcnlGcm9udGVuZFNlcnZpY2Uuc2NhbGE=) | `85.10% <ø> (-0.32%)` | :arrow_down: |
| [...ation/EngineSecureAuthenticationProviderImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0VuZ2luZVNlY3VyZUF1dGhlbnRpY2F0aW9uUHJvdmlkZXJJbXBsLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...tion/ZooKeeperEngineSecureAccessProviderImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NlcnZpY2UvYXV0aGVudGljYXRpb24vWm9vS2VlcGVyRW5naW5lU2VjdXJlQWNjZXNzUHJvdmlkZXJJbXBsLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...authentication/AuthenticationProviderFactory.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0F1dGhlbnRpY2F0aW9uUHJvdmlkZXJGYWN0b3J5LnNjYWxh) | `56.00% <33.33%> (-4.87%)` | :arrow_down: |
| [...e/authentication/KyuubiAuthenticationFactory.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0t5dXViaUF1dGhlbnRpY2F0aW9uRmFjdG9yeS5zY2FsYQ==) | `73.33% <33.33%> (-4.85%)` | :arrow_down: |
| [.../org/apache/kyuubi/session/KyuubiSessionImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL0t5dXViaVNlc3Npb25JbXBsLnNjYWxh) | `80.00% <33.33%> (-4.22%)` | :arrow_down: |
| [.../service/authentication/EngineSecureAccessor.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0VuZ2luZVNlY3VyZUFjY2Vzc29yLnNjYWxh) | `86.95% <86.95%> (ø)` | |
| [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `95.68% <100.00%> (+0.09%)` | :arrow_up: |
| [...la/org/apache/kyuubi/service/FrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL0Zyb250ZW5kU2VydmljZS5zY2FsYQ==) | `100.00% <100.00%> (ø)` | |
| [...a/org/apache/kyuubi/service/TFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL1RGcm9udGVuZFNlcnZpY2Uuc2NhbGE=) | `94.73% <100.00%> (ø)` | |
| ... and [9 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e4bf600...1e16364](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #1813: [WIP] Enable the internal secure authentication
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1813:
URL: https://github.com/apache/incubator-kyuubi/pull/1813#issuecomment-1018201691
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1813](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e05b47c) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/e4bf6003cda11a3b75648d59872378e3e9828096?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e4bf600) will **increase** coverage by `0.12%`.
> The diff coverage is `75.20%`.
> :exclamation: Current head e05b47c differs from pull request most recent head b997095. Consider uploading reports for the commit b997095 to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1813 +/- ##
============================================
+ Coverage 59.80% 59.93% +0.12%
Complexity 263 263
============================================
Files 274 279 +5
Lines 13655 13777 +122
Branches 1742 1749 +7
============================================
+ Hits 8167 8257 +90
- Misses 4792 4815 +23
- Partials 696 705 +9
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...apache/kyuubi/service/TBinaryFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL1RCaW5hcnlGcm9udGVuZFNlcnZpY2Uuc2NhbGE=) | `85.10% <ø> (-0.32%)` | :arrow_down: |
| [...ation/EngineSecureAuthenticationProviderImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0VuZ2luZVNlY3VyZUF1dGhlbnRpY2F0aW9uUHJvdmlkZXJJbXBsLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...tion/ZooKeeperEngineSecureAccessProviderImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NlcnZpY2UvYXV0aGVudGljYXRpb24vWm9vS2VlcGVyRW5naW5lU2VjdXJlQWNjZXNzUHJvdmlkZXJJbXBsLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...authentication/AuthenticationProviderFactory.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0F1dGhlbnRpY2F0aW9uUHJvdmlkZXJGYWN0b3J5LnNjYWxh) | `56.00% <33.33%> (-4.87%)` | :arrow_down: |
| [.../org/apache/kyuubi/session/KyuubiSessionImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL0t5dXViaVNlc3Npb25JbXBsLnNjYWxh) | `80.00% <33.33%> (-4.22%)` | :arrow_down: |
| [...pache/kyuubi/service/AbstractFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL0Fic3RyYWN0RnJvbnRlbmRTZXJ2aWNlLnNjYWxh) | `66.66% <40.00%> (-19.05%)` | :arrow_down: |
| [.../service/authentication/EngineSecureAccessor.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0VuZ2luZVNlY3VyZUFjY2Vzc29yLnNjYWxh) | `86.95% <86.95%> (ø)` | |
| [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `95.68% <100.00%> (+0.09%)` | :arrow_up: |
| [...la/org/apache/kyuubi/service/FrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL0Zyb250ZW5kU2VydmljZS5zY2FsYQ==) | `100.00% <100.00%> (ø)` | |
| [...a/org/apache/kyuubi/service/TFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL1RGcm9udGVuZFNlcnZpY2Uuc2NhbGE=) | `94.73% <100.00%> (ø)` | |
| ... and [8 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e4bf600...b997095](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1813: Enable the internal secure authentication between Kyuubi server and engine
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1813:
URL: https://github.com/apache/incubator-kyuubi/pull/1813#issuecomment-1018201691
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1813](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e1266e3) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/e4bf6003cda11a3b75648d59872378e3e9828096?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e4bf600) will **increase** coverage by `0.19%`.
> The diff coverage is `82.30%`.
> :exclamation: Current head e1266e3 differs from pull request most recent head d3263c0. Consider uploading reports for the commit d3263c0 to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1813 +/- ##
============================================
+ Coverage 59.80% 60.00% +0.19%
Complexity 263 263
============================================
Files 274 279 +5
Lines 13655 13787 +132
Branches 1742 1750 +8
============================================
+ Hits 8167 8273 +106
- Misses 4792 4810 +18
- Partials 696 704 +8
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...apache/kyuubi/service/TBinaryFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL1RCaW5hcnlGcm9udGVuZFNlcnZpY2Uuc2NhbGE=) | `85.10% <ø> (-0.32%)` | :arrow_down: |
| [...authentication/AuthenticationProviderFactory.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0F1dGhlbnRpY2F0aW9uUHJvdmlkZXJGYWN0b3J5LnNjYWxh) | `53.84% <0.00%> (-7.03%)` | :arrow_down: |
| [...ation/EngineSecureAuthenticationProviderImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0VuZ2luZVNlY3VyZUF1dGhlbnRpY2F0aW9uUHJvdmlkZXJJbXBsLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...tion/ZooKeeperEngineSecureSecretProviderImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NlcnZpY2UvYXV0aGVudGljYXRpb24vWm9vS2VlcGVyRW5naW5lU2VjdXJlU2VjcmV0UHJvdmlkZXJJbXBsLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...e/authentication/KyuubiAuthenticationFactory.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0t5dXViaUF1dGhlbnRpY2F0aW9uRmFjdG9yeS5zY2FsYQ==) | `75.43% <33.33%> (-2.75%)` | :arrow_down: |
| [.../service/authentication/EngineSecureAccessor.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0VuZ2luZVNlY3VyZUFjY2Vzc29yLnNjYWxh) | `83.33% <83.33%> (ø)` | |
| [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `95.81% <100.00%> (+0.22%)` | :arrow_up: |
| [...a/org/apache/kyuubi/service/TFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL1RGcm9udGVuZFNlcnZpY2Uuc2NhbGE=) | `94.75% <100.00%> (+0.01%)` | :arrow_up: |
| [...ce/authentication/EngineSecureSecretProvider.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0VuZ2luZVNlY3VyZVNlY3JldFByb3ZpZGVyLnNjYWxh) | `100.00% <100.00%> (ø)` | |
| [...uthentication/KyuubiInternalAccessIdentifier.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0t5dXViaUludGVybmFsQWNjZXNzSWRlbnRpZmllci5zY2FsYQ==) | `100.00% <100.00%> (ø)` | |
| ... and [7 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e4bf600...d3263c0](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1813: Enable the internal secure authentication between Kyuubi server and engine
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1813:
URL: https://github.com/apache/incubator-kyuubi/pull/1813#issuecomment-1018201691
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1813](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dbc9100) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/e4bf6003cda11a3b75648d59872378e3e9828096?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e4bf600) will **increase** coverage by `0.19%`.
> The diff coverage is `81.53%`.
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1813 +/- ##
============================================
+ Coverage 59.80% 60.00% +0.19%
+ Complexity 263 262 -1
============================================
Files 274 279 +5
Lines 13655 13787 +132
Branches 1742 1750 +8
============================================
+ Hits 8167 8273 +106
- Misses 4792 4811 +19
- Partials 696 703 +7
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...apache/kyuubi/service/TBinaryFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL1RCaW5hcnlGcm9udGVuZFNlcnZpY2Uuc2NhbGE=) | `85.10% <ø> (-0.32%)` | :arrow_down: |
| [...authentication/AuthenticationProviderFactory.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0F1dGhlbnRpY2F0aW9uUHJvdmlkZXJGYWN0b3J5LnNjYWxh) | `53.84% <0.00%> (-7.03%)` | :arrow_down: |
| [...ation/EngineSecureAuthenticationProviderImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0VuZ2luZVNlY3VyZUF1dGhlbnRpY2F0aW9uUHJvdmlkZXJJbXBsLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...tion/ZooKeeperEngineSecureSecretProviderImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NlcnZpY2UvYXV0aGVudGljYXRpb24vWm9vS2VlcGVyRW5naW5lU2VjdXJlU2VjcmV0UHJvdmlkZXJJbXBsLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...e/authentication/KyuubiAuthenticationFactory.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0t5dXViaUF1dGhlbnRpY2F0aW9uRmFjdG9yeS5zY2FsYQ==) | `75.43% <33.33%> (-2.75%)` | :arrow_down: |
| [.../service/authentication/EngineSecureAccessor.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0VuZ2luZVNlY3VyZUFjY2Vzc29yLnNjYWxh) | `81.25% <81.25%> (ø)` | |
| [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `95.81% <100.00%> (+0.22%)` | :arrow_up: |
| [...a/org/apache/kyuubi/service/TFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL1RGcm9udGVuZFNlcnZpY2Uuc2NhbGE=) | `94.75% <100.00%> (+0.01%)` | :arrow_up: |
| [...ce/authentication/EngineSecureSecretProvider.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0VuZ2luZVNlY3VyZVNlY3JldFByb3ZpZGVyLnNjYWxh) | `100.00% <100.00%> (ø)` | |
| [...uthentication/KyuubiInternalAccessIdentifier.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0t5dXViaUludGVybmFsQWNjZXNzSWRlbnRpZmllci5zY2FsYQ==) | `100.00% <100.00%> (ø)` | |
| ... and [6 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e4bf600...dbc9100](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1813: [WIP] Enable the internal secure authentication
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1813:
URL: https://github.com/apache/incubator-kyuubi/pull/1813#issuecomment-1018201691
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1813](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6043d2d) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/e4bf6003cda11a3b75648d59872378e3e9828096?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e4bf600) will **increase** coverage by `0.17%`.
> The diff coverage is `76.62%`.
> :exclamation: Current head 6043d2d differs from pull request most recent head 51fc8cd. Consider uploading reports for the commit 51fc8cd to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1813 +/- ##
============================================
+ Coverage 59.80% 59.98% +0.17%
Complexity 263 263
============================================
Files 274 282 +8
Lines 13655 13811 +156
Branches 1742 1753 +11
============================================
+ Hits 8167 8285 +118
- Misses 4792 4820 +28
- Partials 696 706 +10
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...apache/kyuubi/service/TBinaryFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL1RCaW5hcnlGcm9udGVuZFNlcnZpY2Uuc2NhbGE=) | `85.10% <ø> (-0.32%)` | :arrow_down: |
| [...authentication/AuthenticationProviderFactory.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0F1dGhlbnRpY2F0aW9uUHJvdmlkZXJGYWN0b3J5LnNjYWxh) | `53.84% <0.00%> (-7.03%)` | :arrow_down: |
| [...he/kyuubi/service/authentication/CipherModes.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0NpcGhlck1vZGVzLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...ation/EngineSecureAuthenticationProviderImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0VuZ2luZVNlY3VyZUF1dGhlbnRpY2F0aW9uUHJvdmlkZXJJbXBsLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...tion/ZooKeeperEngineSecureSecretProviderImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NlcnZpY2UvYXV0aGVudGljYXRpb24vWm9vS2VlcGVyRW5naW5lU2VjdXJlU2VjcmV0UHJvdmlkZXJJbXBsLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...e/authentication/KyuubiAuthenticationFactory.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0t5dXViaUF1dGhlbnRpY2F0aW9uRmFjdG9yeS5zY2FsYQ==) | `74.13% <25.00%> (-4.05%)` | :arrow_down: |
| [.../org/apache/kyuubi/session/KyuubiSessionImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL0t5dXViaVNlc3Npb25JbXBsLnNjYWxh) | `80.00% <33.33%> (-4.22%)` | :arrow_down: |
| [.../service/authentication/EngineSecureAccessor.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0VuZ2luZVNlY3VyZUFjY2Vzc29yLnNjYWxh) | `78.84% <78.84%> (ø)` | |
| [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `95.68% <100.00%> (+0.09%)` | :arrow_up: |
| [...pache/kyuubi/security/EngineSecureCryptoConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZWN1cml0eS9FbmdpbmVTZWN1cmVDcnlwdG9Db25mLnNjYWxh) | `100.00% <100.00%> (ø)` | |
| ... and [9 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e4bf600...51fc8cd](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1813: Enable the internal secure authentication between Kyuubi server and engine
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1813:
URL: https://github.com/apache/incubator-kyuubi/pull/1813#issuecomment-1018201691
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1813](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0e9273e) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/e4bf6003cda11a3b75648d59872378e3e9828096?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e4bf600) will **increase** coverage by `0.20%`.
> The diff coverage is `82.44%`.
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1813 +/- ##
============================================
+ Coverage 59.80% 60.01% +0.20%
Complexity 263 263
============================================
Files 274 279 +5
Lines 13655 13788 +133
Branches 1742 1750 +8
============================================
+ Hits 8167 8275 +108
- Misses 4792 4810 +18
- Partials 696 703 +7
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...apache/kyuubi/service/TBinaryFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL1RCaW5hcnlGcm9udGVuZFNlcnZpY2Uuc2NhbGE=) | `85.10% <ø> (-0.32%)` | :arrow_down: |
| [...authentication/AuthenticationProviderFactory.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0F1dGhlbnRpY2F0aW9uUHJvdmlkZXJGYWN0b3J5LnNjYWxh) | `53.84% <0.00%> (-7.03%)` | :arrow_down: |
| [...ation/EngineSecureAuthenticationProviderImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0VuZ2luZVNlY3VyZUF1dGhlbnRpY2F0aW9uUHJvdmlkZXJJbXBsLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...tion/ZooKeeperEngineSecureSecretProviderImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NlcnZpY2UvYXV0aGVudGljYXRpb24vWm9vS2VlcGVyRW5naW5lU2VjdXJlU2VjcmV0UHJvdmlkZXJJbXBsLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...e/authentication/KyuubiAuthenticationFactory.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0t5dXViaUF1dGhlbnRpY2F0aW9uRmFjdG9yeS5zY2FsYQ==) | `75.43% <33.33%> (-2.75%)` | :arrow_down: |
| [.../service/authentication/EngineSecureAccessor.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0VuZ2luZVNlY3VyZUFjY2Vzc29yLnNjYWxh) | `83.67% <83.67%> (ø)` | |
| [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `95.81% <100.00%> (+0.22%)` | :arrow_up: |
| [...a/org/apache/kyuubi/service/TFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL1RGcm9udGVuZFNlcnZpY2Uuc2NhbGE=) | `94.75% <100.00%> (+0.01%)` | :arrow_up: |
| [...ce/authentication/EngineSecureSecretProvider.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0VuZ2luZVNlY3VyZVNlY3JldFByb3ZpZGVyLnNjYWxh) | `100.00% <100.00%> (ø)` | |
| [...uthentication/KyuubiInternalAccessIdentifier.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0t5dXViaUludGVybmFsQWNjZXNzSWRlbnRpZmllci5zY2FsYQ==) | `100.00% <100.00%> (ø)` | |
| ... and [6 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e4bf600...0e9273e](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1813: Enable the internal secure authentication between Kyuubi server and engine
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1813:
URL: https://github.com/apache/incubator-kyuubi/pull/1813#issuecomment-1018201691
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1813](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e1266e3) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/e4bf6003cda11a3b75648d59872378e3e9828096?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e4bf600) will **increase** coverage by `0.19%`.
> The diff coverage is `82.30%`.
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1813 +/- ##
============================================
+ Coverage 59.80% 60.00% +0.19%
Complexity 263 263
============================================
Files 274 279 +5
Lines 13655 13787 +132
Branches 1742 1750 +8
============================================
+ Hits 8167 8273 +106
- Misses 4792 4810 +18
- Partials 696 704 +8
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...apache/kyuubi/service/TBinaryFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL1RCaW5hcnlGcm9udGVuZFNlcnZpY2Uuc2NhbGE=) | `85.10% <ø> (-0.32%)` | :arrow_down: |
| [...authentication/AuthenticationProviderFactory.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0F1dGhlbnRpY2F0aW9uUHJvdmlkZXJGYWN0b3J5LnNjYWxh) | `53.84% <0.00%> (-7.03%)` | :arrow_down: |
| [...ation/EngineSecureAuthenticationProviderImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0VuZ2luZVNlY3VyZUF1dGhlbnRpY2F0aW9uUHJvdmlkZXJJbXBsLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...tion/ZooKeeperEngineSecureSecretProviderImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NlcnZpY2UvYXV0aGVudGljYXRpb24vWm9vS2VlcGVyRW5naW5lU2VjdXJlU2VjcmV0UHJvdmlkZXJJbXBsLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...e/authentication/KyuubiAuthenticationFactory.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0t5dXViaUF1dGhlbnRpY2F0aW9uRmFjdG9yeS5zY2FsYQ==) | `75.43% <33.33%> (-2.75%)` | :arrow_down: |
| [.../service/authentication/EngineSecureAccessor.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0VuZ2luZVNlY3VyZUFjY2Vzc29yLnNjYWxh) | `83.33% <83.33%> (ø)` | |
| [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `95.81% <100.00%> (+0.22%)` | :arrow_up: |
| [...a/org/apache/kyuubi/service/TFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL1RGcm9udGVuZFNlcnZpY2Uuc2NhbGE=) | `94.75% <100.00%> (+0.01%)` | :arrow_up: |
| [...ce/authentication/EngineSecureSecretProvider.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0VuZ2luZVNlY3VyZVNlY3JldFByb3ZpZGVyLnNjYWxh) | `100.00% <100.00%> (ø)` | |
| [...uthentication/KyuubiInternalAccessIdentifier.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0t5dXViaUludGVybmFsQWNjZXNzSWRlbnRpZmllci5zY2FsYQ==) | `100.00% <100.00%> (ø)` | |
| ... and [7 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e4bf600...e1266e3](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1813: [WIP] Enable the internal secure authentication
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1813:
URL: https://github.com/apache/incubator-kyuubi/pull/1813#issuecomment-1018201691
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1813](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b997095) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/e4bf6003cda11a3b75648d59872378e3e9828096?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e4bf600) will **increase** coverage by `0.09%`.
> The diff coverage is `74.19%`.
> :exclamation: Current head b997095 differs from pull request most recent head b8aa924. Consider uploading reports for the commit b8aa924 to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1813 +/- ##
============================================
+ Coverage 59.80% 59.90% +0.09%
+ Complexity 263 262 -1
============================================
Files 274 279 +5
Lines 13655 13776 +121
Branches 1742 1749 +7
============================================
+ Hits 8167 8253 +86
- Misses 4792 4817 +25
- Partials 696 706 +10
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...apache/kyuubi/service/TBinaryFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL1RCaW5hcnlGcm9udGVuZFNlcnZpY2Uuc2NhbGE=) | `85.10% <ø> (-0.32%)` | :arrow_down: |
| [...ation/EngineSecureAuthenticationProviderImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0VuZ2luZVNlY3VyZUF1dGhlbnRpY2F0aW9uUHJvdmlkZXJJbXBsLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...tion/ZooKeeperEngineSecureAccessProviderImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NlcnZpY2UvYXV0aGVudGljYXRpb24vWm9vS2VlcGVyRW5naW5lU2VjdXJlQWNjZXNzUHJvdmlkZXJJbXBsLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...authentication/AuthenticationProviderFactory.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0F1dGhlbnRpY2F0aW9uUHJvdmlkZXJGYWN0b3J5LnNjYWxh) | `56.00% <33.33%> (-4.87%)` | :arrow_down: |
| [...e/authentication/KyuubiAuthenticationFactory.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0t5dXViaUF1dGhlbnRpY2F0aW9uRmFjdG9yeS5zY2FsYQ==) | `73.33% <33.33%> (-4.85%)` | :arrow_down: |
| [.../org/apache/kyuubi/session/KyuubiSessionImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL0t5dXViaVNlc3Npb25JbXBsLnNjYWxh) | `80.00% <33.33%> (-4.22%)` | :arrow_down: |
| [.../service/authentication/EngineSecureAccessor.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0VuZ2luZVNlY3VyZUFjY2Vzc29yLnNjYWxh) | `86.95% <86.95%> (ø)` | |
| [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `95.68% <100.00%> (+0.09%)` | :arrow_up: |
| [...la/org/apache/kyuubi/service/FrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL0Zyb250ZW5kU2VydmljZS5zY2FsYQ==) | `100.00% <100.00%> (ø)` | |
| [...a/org/apache/kyuubi/service/TFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL1RGcm9udGVuZFNlcnZpY2Uuc2NhbGE=) | `94.73% <100.00%> (ø)` | |
| ... and [9 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e4bf600...b8aa924](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1813: [WIP] Enable the internal secure authentication
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1813:
URL: https://github.com/apache/incubator-kyuubi/pull/1813#issuecomment-1018201691
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1813](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b899731) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/e4bf6003cda11a3b75648d59872378e3e9828096?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e4bf600) will **increase** coverage by `0.09%`.
> The diff coverage is `71.30%`.
> :exclamation: Current head b899731 differs from pull request most recent head 8eaf89b. Consider uploading reports for the commit 8eaf89b to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1813 +/- ##
============================================
+ Coverage 59.80% 59.90% +0.09%
Complexity 263 263
============================================
Files 274 279 +5
Lines 13655 13772 +117
Branches 1742 1750 +8
============================================
+ Hits 8167 8250 +83
- Misses 4792 4818 +26
- Partials 696 704 +8
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...apache/kyuubi/service/TBinaryFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL1RCaW5hcnlGcm9udGVuZFNlcnZpY2Uuc2NhbGE=) | `85.10% <ø> (-0.32%)` | :arrow_down: |
| [...authentication/AuthenticationProviderFactory.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0F1dGhlbnRpY2F0aW9uUHJvdmlkZXJGYWN0b3J5LnNjYWxh) | `53.84% <0.00%> (-7.03%)` | :arrow_down: |
| [...ation/EngineSecureAuthenticationProviderImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0VuZ2luZVNlY3VyZUF1dGhlbnRpY2F0aW9uUHJvdmlkZXJJbXBsLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...tion/ZooKeeperEngineSecureAccessProviderImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NlcnZpY2UvYXV0aGVudGljYXRpb24vWm9vS2VlcGVyRW5naW5lU2VjdXJlQWNjZXNzUHJvdmlkZXJJbXBsLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...e/authentication/KyuubiAuthenticationFactory.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0t5dXViaUF1dGhlbnRpY2F0aW9uRmFjdG9yeS5zY2FsYQ==) | `72.88% <20.00%> (-5.31%)` | :arrow_down: |
| [.../org/apache/kyuubi/session/KyuubiSessionImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL0t5dXViaVNlc3Npb25JbXBsLnNjYWxh) | `80.00% <33.33%> (-4.22%)` | :arrow_down: |
| [.../service/authentication/EngineSecureAccessor.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0VuZ2luZVNlY3VyZUFjY2Vzc29yLnNjYWxh) | `86.95% <86.95%> (ø)` | |
| [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `95.68% <100.00%> (+0.09%)` | :arrow_up: |
| [...a/org/apache/kyuubi/service/TFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL1RGcm9udGVuZFNlcnZpY2Uuc2NhbGE=) | `94.75% <100.00%> (+0.01%)` | :arrow_up: |
| [...uthentication/KyuubiInternalAccessIdentifier.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0t5dXViaUludGVybmFsQWNjZXNzSWRlbnRpZmllci5zY2FsYQ==) | `100.00% <100.00%> (ø)` | |
| ... and [5 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e4bf600...8eaf89b](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1813: [WIP] Enable the internal secure authentication
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1813:
URL: https://github.com/apache/incubator-kyuubi/pull/1813#issuecomment-1018201691
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1813](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b899731) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/e4bf6003cda11a3b75648d59872378e3e9828096?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e4bf600) will **increase** coverage by `0.09%`.
> The diff coverage is `71.30%`.
> :exclamation: Current head b899731 differs from pull request most recent head 7019ce7. Consider uploading reports for the commit 7019ce7 to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1813 +/- ##
============================================
+ Coverage 59.80% 59.90% +0.09%
Complexity 263 263
============================================
Files 274 279 +5
Lines 13655 13772 +117
Branches 1742 1750 +8
============================================
+ Hits 8167 8250 +83
- Misses 4792 4818 +26
- Partials 696 704 +8
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...apache/kyuubi/service/TBinaryFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL1RCaW5hcnlGcm9udGVuZFNlcnZpY2Uuc2NhbGE=) | `85.10% <ø> (-0.32%)` | :arrow_down: |
| [...authentication/AuthenticationProviderFactory.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0F1dGhlbnRpY2F0aW9uUHJvdmlkZXJGYWN0b3J5LnNjYWxh) | `53.84% <0.00%> (-7.03%)` | :arrow_down: |
| [...ation/EngineSecureAuthenticationProviderImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0VuZ2luZVNlY3VyZUF1dGhlbnRpY2F0aW9uUHJvdmlkZXJJbXBsLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...tion/ZooKeeperEngineSecureAccessProviderImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NlcnZpY2UvYXV0aGVudGljYXRpb24vWm9vS2VlcGVyRW5naW5lU2VjdXJlQWNjZXNzUHJvdmlkZXJJbXBsLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...e/authentication/KyuubiAuthenticationFactory.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0t5dXViaUF1dGhlbnRpY2F0aW9uRmFjdG9yeS5zY2FsYQ==) | `72.88% <20.00%> (-5.31%)` | :arrow_down: |
| [.../org/apache/kyuubi/session/KyuubiSessionImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL0t5dXViaVNlc3Npb25JbXBsLnNjYWxh) | `80.00% <33.33%> (-4.22%)` | :arrow_down: |
| [.../service/authentication/EngineSecureAccessor.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0VuZ2luZVNlY3VyZUFjY2Vzc29yLnNjYWxh) | `86.95% <86.95%> (ø)` | |
| [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `95.68% <100.00%> (+0.09%)` | :arrow_up: |
| [...a/org/apache/kyuubi/service/TFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL1RGcm9udGVuZFNlcnZpY2Uuc2NhbGE=) | `94.75% <100.00%> (+0.01%)` | :arrow_up: |
| [...uthentication/KyuubiInternalAccessIdentifier.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0t5dXViaUludGVybmFsQWNjZXNzSWRlbnRpZmllci5zY2FsYQ==) | `100.00% <100.00%> (ø)` | |
| ... and [5 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e4bf600...7019ce7](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1813: [WIP] Enable the internal secure authentication
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1813:
URL: https://github.com/apache/incubator-kyuubi/pull/1813#issuecomment-1018201691
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1813](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b899731) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/e4bf6003cda11a3b75648d59872378e3e9828096?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e4bf600) will **increase** coverage by `0.09%`.
> The diff coverage is `71.30%`.
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1813 +/- ##
============================================
+ Coverage 59.80% 59.90% +0.09%
Complexity 263 263
============================================
Files 274 279 +5
Lines 13655 13772 +117
Branches 1742 1750 +8
============================================
+ Hits 8167 8250 +83
- Misses 4792 4818 +26
- Partials 696 704 +8
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...apache/kyuubi/service/TBinaryFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL1RCaW5hcnlGcm9udGVuZFNlcnZpY2Uuc2NhbGE=) | `85.10% <ø> (-0.32%)` | :arrow_down: |
| [...authentication/AuthenticationProviderFactory.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0F1dGhlbnRpY2F0aW9uUHJvdmlkZXJGYWN0b3J5LnNjYWxh) | `53.84% <0.00%> (-7.03%)` | :arrow_down: |
| [...ation/EngineSecureAuthenticationProviderImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0VuZ2luZVNlY3VyZUF1dGhlbnRpY2F0aW9uUHJvdmlkZXJJbXBsLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...tion/ZooKeeperEngineSecureAccessProviderImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NlcnZpY2UvYXV0aGVudGljYXRpb24vWm9vS2VlcGVyRW5naW5lU2VjdXJlQWNjZXNzUHJvdmlkZXJJbXBsLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...e/authentication/KyuubiAuthenticationFactory.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0t5dXViaUF1dGhlbnRpY2F0aW9uRmFjdG9yeS5zY2FsYQ==) | `72.88% <20.00%> (-5.31%)` | :arrow_down: |
| [.../org/apache/kyuubi/session/KyuubiSessionImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL0t5dXViaVNlc3Npb25JbXBsLnNjYWxh) | `80.00% <33.33%> (-4.22%)` | :arrow_down: |
| [.../service/authentication/EngineSecureAccessor.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0VuZ2luZVNlY3VyZUFjY2Vzc29yLnNjYWxh) | `86.95% <86.95%> (ø)` | |
| [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `95.68% <100.00%> (+0.09%)` | :arrow_up: |
| [...a/org/apache/kyuubi/service/TFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL1RGcm9udGVuZFNlcnZpY2Uuc2NhbGE=) | `94.75% <100.00%> (+0.01%)` | :arrow_up: |
| [...uthentication/KyuubiInternalAccessIdentifier.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0t5dXViaUludGVybmFsQWNjZXNzSWRlbnRpZmllci5zY2FsYQ==) | `100.00% <100.00%> (ø)` | |
| ... and [5 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e4bf600...b899731](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1813: [WIP] Enable the internal secure authentication
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1813:
URL: https://github.com/apache/incubator-kyuubi/pull/1813#issuecomment-1018201691
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1813](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b997095) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/e4bf6003cda11a3b75648d59872378e3e9828096?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e4bf600) will **increase** coverage by `0.09%`.
> The diff coverage is `74.19%`.
> :exclamation: Current head b997095 differs from pull request most recent head b899731. Consider uploading reports for the commit b899731 to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1813 +/- ##
============================================
+ Coverage 59.80% 59.90% +0.09%
+ Complexity 263 262 -1
============================================
Files 274 279 +5
Lines 13655 13776 +121
Branches 1742 1749 +7
============================================
+ Hits 8167 8253 +86
- Misses 4792 4817 +25
- Partials 696 706 +10
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...apache/kyuubi/service/TBinaryFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL1RCaW5hcnlGcm9udGVuZFNlcnZpY2Uuc2NhbGE=) | `85.10% <ø> (-0.32%)` | :arrow_down: |
| [...ation/EngineSecureAuthenticationProviderImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0VuZ2luZVNlY3VyZUF1dGhlbnRpY2F0aW9uUHJvdmlkZXJJbXBsLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...tion/ZooKeeperEngineSecureAccessProviderImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NlcnZpY2UvYXV0aGVudGljYXRpb24vWm9vS2VlcGVyRW5naW5lU2VjdXJlQWNjZXNzUHJvdmlkZXJJbXBsLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...authentication/AuthenticationProviderFactory.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0F1dGhlbnRpY2F0aW9uUHJvdmlkZXJGYWN0b3J5LnNjYWxh) | `56.00% <33.33%> (-4.87%)` | :arrow_down: |
| [...e/authentication/KyuubiAuthenticationFactory.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0t5dXViaUF1dGhlbnRpY2F0aW9uRmFjdG9yeS5zY2FsYQ==) | `73.33% <33.33%> (-4.85%)` | :arrow_down: |
| [.../org/apache/kyuubi/session/KyuubiSessionImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL0t5dXViaVNlc3Npb25JbXBsLnNjYWxh) | `80.00% <33.33%> (-4.22%)` | :arrow_down: |
| [.../service/authentication/EngineSecureAccessor.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0VuZ2luZVNlY3VyZUFjY2Vzc29yLnNjYWxh) | `86.95% <86.95%> (ø)` | |
| [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `95.68% <100.00%> (+0.09%)` | :arrow_up: |
| [...la/org/apache/kyuubi/service/FrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL0Zyb250ZW5kU2VydmljZS5zY2FsYQ==) | `100.00% <100.00%> (ø)` | |
| [...a/org/apache/kyuubi/service/TFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL1RGcm9udGVuZFNlcnZpY2Uuc2NhbGE=) | `94.73% <100.00%> (ø)` | |
| ... and [9 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e4bf600...b899731](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1813: [WIP] Enable the internal secure authentication
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1813:
URL: https://github.com/apache/incubator-kyuubi/pull/1813#issuecomment-1018201691
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1813](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3d937b0) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/e4bf6003cda11a3b75648d59872378e3e9828096?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e4bf600) will **increase** coverage by `0.17%`.
> The diff coverage is `76.62%`.
> :exclamation: Current head 3d937b0 differs from pull request most recent head 6043d2d. Consider uploading reports for the commit 6043d2d to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1813 +/- ##
============================================
+ Coverage 59.80% 59.98% +0.17%
+ Complexity 263 262 -1
============================================
Files 274 282 +8
Lines 13655 13811 +156
Branches 1742 1752 +10
============================================
+ Hits 8167 8285 +118
- Misses 4792 4820 +28
- Partials 696 706 +10
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...apache/kyuubi/service/TBinaryFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL1RCaW5hcnlGcm9udGVuZFNlcnZpY2Uuc2NhbGE=) | `85.10% <ø> (-0.32%)` | :arrow_down: |
| [...authentication/AuthenticationProviderFactory.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0F1dGhlbnRpY2F0aW9uUHJvdmlkZXJGYWN0b3J5LnNjYWxh) | `53.84% <0.00%> (-7.03%)` | :arrow_down: |
| [...he/kyuubi/service/authentication/CipherModes.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0NpcGhlck1vZGVzLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...ation/EngineSecureAuthenticationProviderImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0VuZ2luZVNlY3VyZUF1dGhlbnRpY2F0aW9uUHJvdmlkZXJJbXBsLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...tion/ZooKeeperEngineSecureSecretProviderImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NlcnZpY2UvYXV0aGVudGljYXRpb24vWm9vS2VlcGVyRW5naW5lU2VjdXJlU2VjcmV0UHJvdmlkZXJJbXBsLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...e/authentication/KyuubiAuthenticationFactory.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0t5dXViaUF1dGhlbnRpY2F0aW9uRmFjdG9yeS5zY2FsYQ==) | `74.13% <25.00%> (-4.05%)` | :arrow_down: |
| [.../org/apache/kyuubi/session/KyuubiSessionImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL0t5dXViaVNlc3Npb25JbXBsLnNjYWxh) | `80.00% <33.33%> (-4.22%)` | :arrow_down: |
| [.../service/authentication/EngineSecureAccessor.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0VuZ2luZVNlY3VyZUFjY2Vzc29yLnNjYWxh) | `78.84% <78.84%> (ø)` | |
| [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `95.68% <100.00%> (+0.09%)` | :arrow_up: |
| [...pache/kyuubi/security/EngineSecureCryptoConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZWN1cml0eS9FbmdpbmVTZWN1cmVDcnlwdG9Db25mLnNjYWxh) | `100.00% <100.00%> (ø)` | |
| ... and [9 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e4bf600...6043d2d](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1813: Enable the internal secure authentication between Kyuubi server and engine
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1813:
URL: https://github.com/apache/incubator-kyuubi/pull/1813#issuecomment-1018201691
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1813](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d3263c0) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/e4bf6003cda11a3b75648d59872378e3e9828096?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e4bf600) will **increase** coverage by `0.20%`.
> The diff coverage is `82.44%`.
> :exclamation: Current head d3263c0 differs from pull request most recent head 0e9273e. Consider uploading reports for the commit 0e9273e to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1813 +/- ##
============================================
+ Coverage 59.80% 60.01% +0.20%
+ Complexity 263 262 -1
============================================
Files 274 279 +5
Lines 13655 13788 +133
Branches 1742 1750 +8
============================================
+ Hits 8167 8275 +108
- Misses 4792 4810 +18
- Partials 696 703 +7
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...apache/kyuubi/service/TBinaryFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL1RCaW5hcnlGcm9udGVuZFNlcnZpY2Uuc2NhbGE=) | `85.10% <ø> (-0.32%)` | :arrow_down: |
| [...authentication/AuthenticationProviderFactory.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0F1dGhlbnRpY2F0aW9uUHJvdmlkZXJGYWN0b3J5LnNjYWxh) | `53.84% <0.00%> (-7.03%)` | :arrow_down: |
| [...ation/EngineSecureAuthenticationProviderImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0VuZ2luZVNlY3VyZUF1dGhlbnRpY2F0aW9uUHJvdmlkZXJJbXBsLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...tion/ZooKeeperEngineSecureSecretProviderImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NlcnZpY2UvYXV0aGVudGljYXRpb24vWm9vS2VlcGVyRW5naW5lU2VjdXJlU2VjcmV0UHJvdmlkZXJJbXBsLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...e/authentication/KyuubiAuthenticationFactory.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0t5dXViaUF1dGhlbnRpY2F0aW9uRmFjdG9yeS5zY2FsYQ==) | `75.43% <33.33%> (-2.75%)` | :arrow_down: |
| [.../service/authentication/EngineSecureAccessor.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0VuZ2luZVNlY3VyZUFjY2Vzc29yLnNjYWxh) | `83.67% <83.67%> (ø)` | |
| [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `95.81% <100.00%> (+0.22%)` | :arrow_up: |
| [...a/org/apache/kyuubi/service/TFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL1RGcm9udGVuZFNlcnZpY2Uuc2NhbGE=) | `94.75% <100.00%> (+0.01%)` | :arrow_up: |
| [...ce/authentication/EngineSecureSecretProvider.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0VuZ2luZVNlY3VyZVNlY3JldFByb3ZpZGVyLnNjYWxh) | `100.00% <100.00%> (ø)` | |
| [...uthentication/KyuubiInternalAccessIdentifier.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0t5dXViaUludGVybmFsQWNjZXNzSWRlbnRpZmllci5zY2FsYQ==) | `100.00% <100.00%> (ø)` | |
| ... and [6 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e4bf600...0e9273e](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1813: Enable the internal secure authentication between Kyuubi server and engine
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1813:
URL: https://github.com/apache/incubator-kyuubi/pull/1813#issuecomment-1018201691
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1813](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0e9273e) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/e4bf6003cda11a3b75648d59872378e3e9828096?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e4bf600) will **increase** coverage by `0.20%`.
> The diff coverage is `82.44%`.
> :exclamation: Current head 0e9273e differs from pull request most recent head b545281. Consider uploading reports for the commit b545281 to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1813 +/- ##
============================================
+ Coverage 59.80% 60.01% +0.20%
Complexity 263 263
============================================
Files 274 279 +5
Lines 13655 13788 +133
Branches 1742 1750 +8
============================================
+ Hits 8167 8275 +108
- Misses 4792 4810 +18
- Partials 696 703 +7
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...apache/kyuubi/service/TBinaryFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL1RCaW5hcnlGcm9udGVuZFNlcnZpY2Uuc2NhbGE=) | `85.10% <ø> (-0.32%)` | :arrow_down: |
| [...authentication/AuthenticationProviderFactory.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0F1dGhlbnRpY2F0aW9uUHJvdmlkZXJGYWN0b3J5LnNjYWxh) | `53.84% <0.00%> (-7.03%)` | :arrow_down: |
| [...ation/EngineSecureAuthenticationProviderImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0VuZ2luZVNlY3VyZUF1dGhlbnRpY2F0aW9uUHJvdmlkZXJJbXBsLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...tion/ZooKeeperEngineSecureSecretProviderImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NlcnZpY2UvYXV0aGVudGljYXRpb24vWm9vS2VlcGVyRW5naW5lU2VjdXJlU2VjcmV0UHJvdmlkZXJJbXBsLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...e/authentication/KyuubiAuthenticationFactory.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0t5dXViaUF1dGhlbnRpY2F0aW9uRmFjdG9yeS5zY2FsYQ==) | `75.43% <33.33%> (-2.75%)` | :arrow_down: |
| [.../service/authentication/EngineSecureAccessor.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0VuZ2luZVNlY3VyZUFjY2Vzc29yLnNjYWxh) | `83.67% <83.67%> (ø)` | |
| [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `95.81% <100.00%> (+0.22%)` | :arrow_up: |
| [...a/org/apache/kyuubi/service/TFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL1RGcm9udGVuZFNlcnZpY2Uuc2NhbGE=) | `94.75% <100.00%> (+0.01%)` | :arrow_up: |
| [...ce/authentication/EngineSecureSecretProvider.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0VuZ2luZVNlY3VyZVNlY3JldFByb3ZpZGVyLnNjYWxh) | `100.00% <100.00%> (ø)` | |
| [...uthentication/KyuubiInternalAccessIdentifier.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0t5dXViaUludGVybmFsQWNjZXNzSWRlbnRpZmllci5zY2FsYQ==) | `100.00% <100.00%> (ø)` | |
| ... and [6 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e4bf600...b545281](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on pull request #1813: Enable the internal secure authentication between Kyuubi server and engine
Posted by GitBox <gi...@apache.org>.
turboFei commented on pull request #1813:
URL: https://github.com/apache/incubator-kyuubi/pull/1813#issuecomment-1019469009
have tested it in our dev environment, it works well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1813: Enable the internal secure authentication between Kyuubi server and engine
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1813:
URL: https://github.com/apache/incubator-kyuubi/pull/1813#issuecomment-1018201691
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1813](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d3263c0) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/e4bf6003cda11a3b75648d59872378e3e9828096?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e4bf600) will **increase** coverage by `0.20%`.
> The diff coverage is `82.44%`.
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1813 +/- ##
============================================
+ Coverage 59.80% 60.01% +0.20%
+ Complexity 263 262 -1
============================================
Files 274 279 +5
Lines 13655 13788 +133
Branches 1742 1750 +8
============================================
+ Hits 8167 8275 +108
- Misses 4792 4810 +18
- Partials 696 703 +7
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...apache/kyuubi/service/TBinaryFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL1RCaW5hcnlGcm9udGVuZFNlcnZpY2Uuc2NhbGE=) | `85.10% <ø> (-0.32%)` | :arrow_down: |
| [...authentication/AuthenticationProviderFactory.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0F1dGhlbnRpY2F0aW9uUHJvdmlkZXJGYWN0b3J5LnNjYWxh) | `53.84% <0.00%> (-7.03%)` | :arrow_down: |
| [...ation/EngineSecureAuthenticationProviderImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0VuZ2luZVNlY3VyZUF1dGhlbnRpY2F0aW9uUHJvdmlkZXJJbXBsLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...tion/ZooKeeperEngineSecureSecretProviderImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NlcnZpY2UvYXV0aGVudGljYXRpb24vWm9vS2VlcGVyRW5naW5lU2VjdXJlU2VjcmV0UHJvdmlkZXJJbXBsLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...e/authentication/KyuubiAuthenticationFactory.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0t5dXViaUF1dGhlbnRpY2F0aW9uRmFjdG9yeS5zY2FsYQ==) | `75.43% <33.33%> (-2.75%)` | :arrow_down: |
| [.../service/authentication/EngineSecureAccessor.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0VuZ2luZVNlY3VyZUFjY2Vzc29yLnNjYWxh) | `83.67% <83.67%> (ø)` | |
| [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `95.81% <100.00%> (+0.22%)` | :arrow_up: |
| [...a/org/apache/kyuubi/service/TFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL1RGcm9udGVuZFNlcnZpY2Uuc2NhbGE=) | `94.75% <100.00%> (+0.01%)` | :arrow_up: |
| [...ce/authentication/EngineSecureSecretProvider.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0VuZ2luZVNlY3VyZVNlY3JldFByb3ZpZGVyLnNjYWxh) | `100.00% <100.00%> (ø)` | |
| [...uthentication/KyuubiInternalAccessIdentifier.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0t5dXViaUludGVybmFsQWNjZXNzSWRlbnRpZmllci5zY2FsYQ==) | `100.00% <100.00%> (ø)` | |
| ... and [6 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e4bf600...d3263c0](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1813: [WIP] Enable the internal secure authentication
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1813:
URL: https://github.com/apache/incubator-kyuubi/pull/1813#issuecomment-1018201691
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1813](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b997095) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/e4bf6003cda11a3b75648d59872378e3e9828096?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e4bf600) will **increase** coverage by `0.09%`.
> The diff coverage is `74.19%`.
> :exclamation: Current head b997095 differs from pull request most recent head b44ac21. Consider uploading reports for the commit b44ac21 to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1813 +/- ##
============================================
+ Coverage 59.80% 59.90% +0.09%
+ Complexity 263 262 -1
============================================
Files 274 279 +5
Lines 13655 13776 +121
Branches 1742 1749 +7
============================================
+ Hits 8167 8253 +86
- Misses 4792 4817 +25
- Partials 696 706 +10
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...apache/kyuubi/service/TBinaryFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL1RCaW5hcnlGcm9udGVuZFNlcnZpY2Uuc2NhbGE=) | `85.10% <ø> (-0.32%)` | :arrow_down: |
| [...ation/EngineSecureAuthenticationProviderImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0VuZ2luZVNlY3VyZUF1dGhlbnRpY2F0aW9uUHJvdmlkZXJJbXBsLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...tion/ZooKeeperEngineSecureAccessProviderImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NlcnZpY2UvYXV0aGVudGljYXRpb24vWm9vS2VlcGVyRW5naW5lU2VjdXJlQWNjZXNzUHJvdmlkZXJJbXBsLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...authentication/AuthenticationProviderFactory.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0F1dGhlbnRpY2F0aW9uUHJvdmlkZXJGYWN0b3J5LnNjYWxh) | `56.00% <33.33%> (-4.87%)` | :arrow_down: |
| [...e/authentication/KyuubiAuthenticationFactory.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0t5dXViaUF1dGhlbnRpY2F0aW9uRmFjdG9yeS5zY2FsYQ==) | `73.33% <33.33%> (-4.85%)` | :arrow_down: |
| [.../org/apache/kyuubi/session/KyuubiSessionImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL0t5dXViaVNlc3Npb25JbXBsLnNjYWxh) | `80.00% <33.33%> (-4.22%)` | :arrow_down: |
| [.../service/authentication/EngineSecureAccessor.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0VuZ2luZVNlY3VyZUFjY2Vzc29yLnNjYWxh) | `86.95% <86.95%> (ø)` | |
| [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `95.68% <100.00%> (+0.09%)` | :arrow_up: |
| [...la/org/apache/kyuubi/service/FrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL0Zyb250ZW5kU2VydmljZS5zY2FsYQ==) | `100.00% <100.00%> (ø)` | |
| [...a/org/apache/kyuubi/service/TFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL1RGcm9udGVuZFNlcnZpY2Uuc2NhbGE=) | `94.73% <100.00%> (ø)` | |
| ... and [9 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e4bf600...b44ac21](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1813: Enable the internal secure authentication
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1813:
URL: https://github.com/apache/incubator-kyuubi/pull/1813#issuecomment-1018201691
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1813](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6043d2d) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/e4bf6003cda11a3b75648d59872378e3e9828096?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e4bf600) will **increase** coverage by `0.17%`.
> The diff coverage is `76.62%`.
> :exclamation: Current head 6043d2d differs from pull request most recent head 4ea020e. Consider uploading reports for the commit 4ea020e to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1813 +/- ##
============================================
+ Coverage 59.80% 59.98% +0.17%
Complexity 263 263
============================================
Files 274 282 +8
Lines 13655 13811 +156
Branches 1742 1753 +11
============================================
+ Hits 8167 8285 +118
- Misses 4792 4820 +28
- Partials 696 706 +10
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...apache/kyuubi/service/TBinaryFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL1RCaW5hcnlGcm9udGVuZFNlcnZpY2Uuc2NhbGE=) | `85.10% <ø> (-0.32%)` | :arrow_down: |
| [...authentication/AuthenticationProviderFactory.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0F1dGhlbnRpY2F0aW9uUHJvdmlkZXJGYWN0b3J5LnNjYWxh) | `53.84% <0.00%> (-7.03%)` | :arrow_down: |
| [...he/kyuubi/service/authentication/CipherModes.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0NpcGhlck1vZGVzLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...ation/EngineSecureAuthenticationProviderImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0VuZ2luZVNlY3VyZUF1dGhlbnRpY2F0aW9uUHJvdmlkZXJJbXBsLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...tion/ZooKeeperEngineSecureSecretProviderImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NlcnZpY2UvYXV0aGVudGljYXRpb24vWm9vS2VlcGVyRW5naW5lU2VjdXJlU2VjcmV0UHJvdmlkZXJJbXBsLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...e/authentication/KyuubiAuthenticationFactory.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0t5dXViaUF1dGhlbnRpY2F0aW9uRmFjdG9yeS5zY2FsYQ==) | `74.13% <25.00%> (-4.05%)` | :arrow_down: |
| [.../org/apache/kyuubi/session/KyuubiSessionImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL0t5dXViaVNlc3Npb25JbXBsLnNjYWxh) | `80.00% <33.33%> (-4.22%)` | :arrow_down: |
| [.../service/authentication/EngineSecureAccessor.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL2F1dGhlbnRpY2F0aW9uL0VuZ2luZVNlY3VyZUFjY2Vzc29yLnNjYWxh) | `78.84% <78.84%> (ø)` | |
| [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `95.68% <100.00%> (+0.09%)` | :arrow_up: |
| [...pache/kyuubi/security/EngineSecureCryptoConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZWN1cml0eS9FbmdpbmVTZWN1cmVDcnlwdG9Db25mLnNjYWxh) | `100.00% <100.00%> (ø)` | |
| ... and [9 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e4bf600...4ea020e](https://codecov.io/gh/apache/incubator-kyuubi/pull/1813?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1813: Enable the internal secure authentication between Kyuubi server and engine
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1813:
URL: https://github.com/apache/incubator-kyuubi/pull/1813#issuecomment-1018201691
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org