You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/11/22 21:13:33 UTC

[GitHub] [nifi] ChrisSamo632 opened a new pull request, #6708: NIFI-10865 allow RecordPath's unescapeJson to convert de-serialised JSON Objects into Records

ChrisSamo632 opened a new pull request, #6708:
URL: https://github.com/apache/nifi/pull/6708

   # Summary
   
   [NIFI-10865](https://issues.apache.org/jira/browse/NIFI-10865) allow RecordPath's unescapeJson to convert de-serialised JSON Objects into Records
   
   NIFI-10865 allow UpdateRecord to replace the Record root for relative paths, e.g. when a RecordPath function is used to modify selected field(s)
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
   
   ### Pull Request Tracking
   
   - [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
   - [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
   
   ### Pull Request Formatting
   
   - [x] Pull Request based on current revision of the `main` branch
   - [x] Pull Request refers to a feature branch with one commit containing changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request creation.
   
   ### Build
   
   - [x] Build completed using `mvn clean install -P contrib-check`
     - [ ] JDK 8
     - [ ] JDK 11
     - [x] JDK 17
   
   ### Licensing
   
   - ~[ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)~
   - ~[ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files~
   
   ### Documentation
   
   - [x] Documentation formatting appears as expected in rendered files`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] ChrisSamo632 commented on pull request #6708: NIFI-10865 allow RecordPath's unescapeJson to convert de-serialised JSON Objects into Records

Posted by GitBox <gi...@apache.org>.
ChrisSamo632 commented on PR #6708:
URL: https://github.com/apache/nifi/pull/6708#issuecomment-1382912833

   @MikeThomsen I rebased on `main` latest and added a new `TestUpdateRecord` unit test (`testSetNestedRecordWithUnescapeJsonCall`) based on the example you provided and it seems to work without issue. Can you take a look and see whether the test is setup any differently to what you were trying?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] MikeThomsen commented on pull request #6708: NIFI-10865 allow RecordPath's unescapeJson to convert de-serialised JSON Objects into Records

Posted by "MikeThomsen (via GitHub)" <gi...@apache.org>.
MikeThomsen commented on PR #6708:
URL: https://github.com/apache/nifi/pull/6708#issuecomment-1528823742

   I don't know what I did that first round, but you were right. I went back and did it over from scratch, and it worked.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] asfgit closed pull request #6708: NIFI-10865 allow RecordPath's unescapeJson to convert de-serialised JSON Objects into Records

Posted by "asfgit (via GitHub)" <gi...@apache.org>.
asfgit closed pull request #6708: NIFI-10865 allow RecordPath's unescapeJson to convert de-serialised JSON Objects into Records
URL: https://github.com/apache/nifi/pull/6708


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org