[Impala-CR](cdh5-2.5.0_5.7.0) IMPALA-2987: Distinguish between already-closed and never-seen data stream receivers

["Marcel Kornacker (Code Review)" <ge...@cloudera.org>]

Marcel Kornacker has posted comments on this change.

Change subject: IMPALA-2987: Distinguish between already-closed and never-seen data stream receivers
......................................................................


Patch Set 6:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/2305/6/be/src/runtime/data-stream-mgr.cc
File be/src/runtime/data-stream-mgr.cc:

Line 38: DEFINE_int32(datastream_timeout_ms, 120000, "(Advanced) The time, in ms, that can elapse"
datastream_sender_timeout? just to disambiguate.


Line 48: const int32_t STREAM_EXPIRATION_TIME_MS = 300 * 1000;
do we need ms resolution here?


Line 187:   bool already_unregistered;
call this dummy


Line 191:     DCHECK(!already_unregistered);
you shouldn't rely on already_unregistered to be set to anything in particular if the find call comes back with a non-null (note that the function comment in the .h file doesn't make any promises in this case, and i don't think it should)


http://gerrit.cloudera.org:8080/#/c/2305/6/be/src/runtime/data-stream-mgr.h
File be/src/runtime/data-stream-mgr.h:

Line 170:   /// 1. *already_unregistered == true: the receiver has previously arrived and was
should it be 'had previously arrived'? i'm sometimes a bit unclear about english tenses as well.


-- 
To view, visit http://gerrit.cloudera.org:8080/2305
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib1734992c7199b9dd4b03afca5372022051b6fbd
Gerrit-PatchSet: 6
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.5.0_5.7.0
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Skye Wanderman-Milne <sk...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: Yes