You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2017/09/01 15:57:00 UTC
[jira] [Commented] (HADOOP-14414) Calling maven-site-plugin
directly for docs profile is unnecessary
[ https://issues.apache.org/jira/browse/HADOOP-14414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16150759#comment-16150759 ]
Hudson commented on HADOOP-14414:
---------------------------------
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12299 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/12299/])
HADOOP-14414. Calling maven-site-plugin directly for docs profile is (aw: rev a3fee475f72c8548aafd8574da1d3f1745f0471d)
* (edit) hadoop-tools/hadoop-sls/pom.xml
* (edit) hadoop-common-project/hadoop-auth/pom.xml
* (edit) hadoop-common-project/hadoop-kms/pom.xml
* (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/pom.xml
> Calling maven-site-plugin directly for docs profile is unnecessary
> ------------------------------------------------------------------
>
> Key: HADOOP-14414
> URL: https://issues.apache.org/jira/browse/HADOOP-14414
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Andras Bokor
> Assignee: Andras Bokor
> Priority: Minor
> Fix For: 3.0.0-beta1
>
> Attachments: HADOOP-14414.01.patch, HADOOP-14414.02.patch, missingFiles
>
>
> For a few modules:
> * hadoop-auth
> * hadoop-kms
> * hadoop-hdfs-httpfs
> * hadoop-sls
> we call {{mave-site-plugin}} directly when docs profile is active.
> In main pom we use {{excludeDefaults}} in reporting section and allow only javadoc and dependency-plugin for the report. Since javadoc plugin is set to {{inherited}} false it won't be called on individual child modules. So actually {{maven-dependency-plugin:analyze-report}} is the only additional goal which will run.
> I debugged the process with {{mvn clean package -DskipTests -Dmaven.javadoc.skip=true -DskipShade -Pdocs -X}} command and in all the 4 affected modules I found the following configuration for site plugin:
> {code}<reportPlugins>
> <reportPlugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-dependency-plugin</artifactId>
> <version>2.10</version>
> <reportSets>
> <reportSet>
> <id>default</id>
> <reports>
> <report>analyze-report</report>
> </reports>
> </reportSet>
> </reportSets>
> </reportPlugin>
> </reportPlugins>{code}
> At this point I do not see the purpose of calling {{mave-site-plugin}} for docs profile. It does not contain useful information. Or if it does why don't we call for other modules? It's inconsistent.
> Considering to remove.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org