You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jan Schlicht <ja...@mesosphere.io> on 2018/03/22 09:37:01 UTC
Review Request 66210: Added OS_LINUX guard for 'test_csi_plugin'.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66210/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, and Jie Yu.
Bugs: MESOS-8719
https://issues.apache.org/jira/browse/MESOS-8719
Repository: mesos
Description
-------
As 'test_csi_plugin' uses functionality that will only compile on Linux,
we have to make sure that it isn't build on non-Linux systems.
Diffs
-----
src/Makefile.am 56ce55480553c08450830987f217d0abedd5b2b8
Diff: https://reviews.apache.org/r/66210/diff/1/
Testing
-------
make check (on macOS, configured with `--enable-grpc`)
Thanks,
Jan Schlicht
Re: Review Request 66210: Added OS_LINUX guard for 'test_csi_plugin'.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66210/#review199767
-----------------------------------------------------------
Ship it!
Ship It!
- Chun-Hung Hsiao
On March 22, 2018, 9:37 a.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66210/
> -----------------------------------------------------------
>
> (Updated March 22, 2018, 9:37 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, and Jie Yu.
>
>
> Bugs: MESOS-8719
> https://issues.apache.org/jira/browse/MESOS-8719
>
>
> Repository: mesos
>
>
> Description
> -------
>
> As 'test_csi_plugin' uses functionality that will only compile on Linux,
> we have to make sure that it isn't build on non-Linux systems.
>
>
> Diffs
> -----
>
> src/Makefile.am 56ce55480553c08450830987f217d0abedd5b2b8
>
>
> Diff: https://reviews.apache.org/r/66210/diff/1/
>
>
> Testing
> -------
>
> make check (on macOS, configured with `--enable-grpc`)
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 66210: Added OS_LINUX guard for 'test_csi_plugin'.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66210/#review199808
-----------------------------------------------------------
Patch looks great!
Reviews applied: [66210]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 22, 2018, 9:37 a.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66210/
> -----------------------------------------------------------
>
> (Updated March 22, 2018, 9:37 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, and Jie Yu.
>
>
> Bugs: MESOS-8719
> https://issues.apache.org/jira/browse/MESOS-8719
>
>
> Repository: mesos
>
>
> Description
> -------
>
> As 'test_csi_plugin' uses functionality that will only compile on Linux,
> we have to make sure that it isn't build on non-Linux systems.
>
>
> Diffs
> -----
>
> src/Makefile.am 56ce55480553c08450830987f217d0abedd5b2b8
>
>
> Diff: https://reviews.apache.org/r/66210/diff/1/
>
>
> Testing
> -------
>
> make check (on macOS, configured with `--enable-grpc`)
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 66210: Added OS_LINUX guard for 'test_csi_plugin'.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66210/#review199750
-----------------------------------------------------------
PASS: Mesos patch 66210 was successfully built and tested.
Reviews applied: `['66210']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66210
- Mesos Reviewbot Windows
On March 22, 2018, 9:37 a.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66210/
> -----------------------------------------------------------
>
> (Updated March 22, 2018, 9:37 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, and Jie Yu.
>
>
> Bugs: MESOS-8719
> https://issues.apache.org/jira/browse/MESOS-8719
>
>
> Repository: mesos
>
>
> Description
> -------
>
> As 'test_csi_plugin' uses functionality that will only compile on Linux,
> we have to make sure that it isn't build on non-Linux systems.
>
>
> Diffs
> -----
>
> src/Makefile.am 56ce55480553c08450830987f217d0abedd5b2b8
>
>
> Diff: https://reviews.apache.org/r/66210/diff/1/
>
>
> Testing
> -------
>
> make check (on macOS, configured with `--enable-grpc`)
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 66210: Added OS_LINUX guard for 'test_csi_plugin'.
Posted by Jan Schlicht <ja...@mesosphere.io>.
> On March 22, 2018, 3:27 p.m., Alexander Rukletsov wrote:
> > What about CMake?
There isn't CMake support for CSI yet. Patches for that are still in review. See my comments on https://reviews.apache.org/r/66163/ for making sure the this is addressed in the CMake patches.
- Jan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66210/#review199764
-----------------------------------------------------------
On March 22, 2018, 10:37 a.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66210/
> -----------------------------------------------------------
>
> (Updated March 22, 2018, 10:37 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, and Jie Yu.
>
>
> Bugs: MESOS-8719
> https://issues.apache.org/jira/browse/MESOS-8719
>
>
> Repository: mesos
>
>
> Description
> -------
>
> As 'test_csi_plugin' uses functionality that will only compile on Linux,
> we have to make sure that it isn't build on non-Linux systems.
>
>
> Diffs
> -----
>
> src/Makefile.am 56ce55480553c08450830987f217d0abedd5b2b8
>
>
> Diff: https://reviews.apache.org/r/66210/diff/1/
>
>
> Testing
> -------
>
> make check (on macOS, configured with `--enable-grpc`)
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 66210: Added OS_LINUX guard for 'test_csi_plugin'.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66210/#review199764
-----------------------------------------------------------
What about CMake?
- Alexander Rukletsov
On March 22, 2018, 9:37 a.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66210/
> -----------------------------------------------------------
>
> (Updated March 22, 2018, 9:37 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, and Jie Yu.
>
>
> Bugs: MESOS-8719
> https://issues.apache.org/jira/browse/MESOS-8719
>
>
> Repository: mesos
>
>
> Description
> -------
>
> As 'test_csi_plugin' uses functionality that will only compile on Linux,
> we have to make sure that it isn't build on non-Linux systems.
>
>
> Diffs
> -----
>
> src/Makefile.am 56ce55480553c08450830987f217d0abedd5b2b8
>
>
> Diff: https://reviews.apache.org/r/66210/diff/1/
>
>
> Testing
> -------
>
> make check (on macOS, configured with `--enable-grpc`)
>
>
> Thanks,
>
> Jan Schlicht
>
>