You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/11/06 18:48:16 UTC

[GitHub] [incubator-mxnet] Zha0q1 commented on a change in pull request #18625: Enable Large Tensor Support: Stage 1

Zha0q1 commented on a change in pull request #18625:
URL: https://github.com/apache/incubator-mxnet/pull/18625#discussion_r518938823



##########
File path: cmake/Modules/FindMKL.cmake
##########
@@ -53,7 +53,12 @@ set(INTEL_OPT_ROOT "/opt/intel" CACHE PATH "Folder contains root-installed intel
   endif()
   cmake_dependent_option(MKL_USE_STATIC_LIBS "Use static libraries" ON "NOT MKL_USE_SINGLE_DYNAMIC_LIBRARY" OFF)
   cmake_dependent_option(MKL_MULTI_THREADED  "Use multi-threading"  ON "NOT MKL_USE_SINGLE_DYNAMIC_LIBRARY" OFF)
-  option(MKL_USE_ILP64 "Use ilp64 data model" OFF)
+  if(DEFINED USE_INT64_TENSOR_SIZE AND USE_INT64_TENSOR_SIZE)
+    message(STATUS "Enabling ILP64")
+    option(MKL_USE_ILP64 "Use ilp64 data model" ON)

Review comment:
       I think we should comment those out for now too. Andrzej includes this in his pr https://github.com/apache/incubator-mxnet/pull/19067/files#diff-192b252a8f0dda2d71d74cc9798f285340d597b8792a0cef1628d2fcaa13c26cR49
   
   This is causing some build failures
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org