You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Frederic Müller (JIRA)" <ji...@codehaus.org> on 2010/02/15 18:15:57 UTC

[jira] Created: (MCHECKSTYLE-131) Plugin can't use configLocation from parent.

Plugin can't use configLocation from parent.
--------------------------------------------

                 Key: MCHECKSTYLE-131
                 URL: http://jira.codehaus.org/browse/MCHECKSTYLE-131
             Project: Maven 2.x Checkstyle Plugin
          Issue Type: Bug
    Affects Versions: 2.5
            Reporter: Frederic Müller
            Priority: Critical


Since Version 2.5 the checkstyle plugin no longer uses a configLocation that is located in the parent project but fails the build because of a missing resource.

Version 2.4 is working as expected.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] Commented: (MCHECKSTYLE-131) Plugin can't use configLocation from parent.

Posted by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MCHECKSTYLE-131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=210810#action_210810 ] 

Benjamin Bentmann commented on MCHECKSTYLE-131:
-----------------------------------------------

I think "worked by fluke" and "supported" are not the same.

> Plugin can't use configLocation from parent.
> --------------------------------------------
>
>                 Key: MCHECKSTYLE-131
>                 URL: http://jira.codehaus.org/browse/MCHECKSTYLE-131
>             Project: Maven 2.x Checkstyle Plugin
>          Issue Type: Bug
>    Affects Versions: 2.5
>            Reporter: Frederic Müller
>            Assignee: Olivier Lamy
>            Priority: Critical
>             Fix For: 2.6
>
>         Attachments: example.zip
>
>
> Since Version 2.5 the checkstyle plugin no longer uses a configLocation that is located in the parent project but fails the build because of a missing resource.
> Version 2.4 is working as expected.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] Commented: (MCHECKSTYLE-131) Plugin can't use configLocation from parent.

Posted by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MCHECKSTYLE-131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=210808#action_210808 ] 

Benjamin Bentmann commented on MCHECKSTYLE-131:
-----------------------------------------------

Out of curiosity, where did the plugin documentation state that one can use a relative path like "checkstyle.xml" in the plugin configuration and have the plugin resolve this to the parent's project instead of the current project as the rest of Maven does?

IMHO, the example project is simply invalid, illustrated by the fact that it fails to run "checkstyle:check" directly from the module directory. The proper way to share the configuration in a multi-module build is documented in [Multimodule Configuration|http://maven.apache.org/plugins/maven-checkstyle-plugin/examples/multi-module-config.html]

> Plugin can't use configLocation from parent.
> --------------------------------------------
>
>                 Key: MCHECKSTYLE-131
>                 URL: http://jira.codehaus.org/browse/MCHECKSTYLE-131
>             Project: Maven 2.x Checkstyle Plugin
>          Issue Type: Bug
>    Affects Versions: 2.5
>            Reporter: Frederic Müller
>            Assignee: Olivier Lamy
>            Priority: Critical
>             Fix For: 2.6
>
>         Attachments: example.zip
>
>
> Since Version 2.5 the checkstyle plugin no longer uses a configLocation that is located in the parent project but fails the build because of a missing resource.
> Version 2.4 is working as expected.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] Updated: (MCHECKSTYLE-131) Plugin can't use configLocation from parent.

Posted by "Olivier Lamy (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MCHECKSTYLE-131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Olivier Lamy updated MCHECKSTYLE-131:
-------------------------------------

    Fix Version/s: 2.6
         Assignee: Olivier Lamy

> Plugin can't use configLocation from parent.
> --------------------------------------------
>
>                 Key: MCHECKSTYLE-131
>                 URL: http://jira.codehaus.org/browse/MCHECKSTYLE-131
>             Project: Maven 2.x Checkstyle Plugin
>          Issue Type: Bug
>    Affects Versions: 2.5
>            Reporter: Frederic Müller
>            Assignee: Olivier Lamy
>            Priority: Critical
>             Fix For: 2.6
>
>
> Since Version 2.5 the checkstyle plugin no longer uses a configLocation that is located in the parent project but fails the build because of a missing resource.
> Version 2.4 is working as expected.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] Closed: (MCHECKSTYLE-131) Plugin can't use configLocation from parent.

Posted by "Olivier Lamy (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MCHECKSTYLE-131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Olivier Lamy closed MCHECKSTYLE-131.
------------------------------------

    Resolution: Fixed

thanks for the it.
[rev 911998|http://svn.apache.org/viewvc?rev=911998&view=rev]
I have re added the hack.


> Plugin can't use configLocation from parent.
> --------------------------------------------
>
>                 Key: MCHECKSTYLE-131
>                 URL: http://jira.codehaus.org/browse/MCHECKSTYLE-131
>             Project: Maven 2.x Checkstyle Plugin
>          Issue Type: Bug
>    Affects Versions: 2.5
>            Reporter: Frederic Müller
>            Assignee: Olivier Lamy
>            Priority: Critical
>             Fix For: 2.6
>
>         Attachments: example.zip
>
>
> Since Version 2.5 the checkstyle plugin no longer uses a configLocation that is located in the parent project but fails the build because of a missing resource.
> Version 2.4 is working as expected.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] Commented: (MCHECKSTYLE-131) Plugin can't use configLocation from parent.

Posted by "Olivier Lamy (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MCHECKSTYLE-131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=210734#action_210734 ] 

Olivier Lamy commented on MCHECKSTYLE-131:
------------------------------------------

could you provide a sample projet which works in 2.4 and not in 2.5 ?
Thanks

> Plugin can't use configLocation from parent.
> --------------------------------------------
>
>                 Key: MCHECKSTYLE-131
>                 URL: http://jira.codehaus.org/browse/MCHECKSTYLE-131
>             Project: Maven 2.x Checkstyle Plugin
>          Issue Type: Bug
>    Affects Versions: 2.5
>            Reporter: Frederic Müller
>            Assignee: Olivier Lamy
>            Priority: Critical
>             Fix For: 2.6
>
>
> Since Version 2.5 the checkstyle plugin no longer uses a configLocation that is located in the parent project but fails the build because of a missing resource.
> Version 2.4 is working as expected.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] Commented: (MCHECKSTYLE-131) Plugin can't use configLocation from parent.

Posted by "Frederic Müller (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MCHECKSTYLE-131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=210824#action_210824 ] 

Frederic Müller commented on MCHECKSTYLE-131:
---------------------------------------------

Actually I really like the way it work. Although I understand why it isn't by design. But since the checkstyle configuration is inherited by the modules it really helps if the config file is "inherited" as well. Being able to include the config in the pom itself would be great although this would most likely bloat the pom.

> Plugin can't use configLocation from parent.
> --------------------------------------------
>
>                 Key: MCHECKSTYLE-131
>                 URL: http://jira.codehaus.org/browse/MCHECKSTYLE-131
>             Project: Maven 2.x Checkstyle Plugin
>          Issue Type: Bug
>    Affects Versions: 2.5
>            Reporter: Frederic Müller
>            Assignee: Olivier Lamy
>            Priority: Critical
>             Fix For: 2.6
>
>         Attachments: example.zip
>
>
> Since Version 2.5 the checkstyle plugin no longer uses a configLocation that is located in the parent project but fails the build because of a missing resource.
> Version 2.4 is working as expected.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] Updated: (MCHECKSTYLE-131) Plugin can't use configLocation from parent.

Posted by "Frederic Müller (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MCHECKSTYLE-131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Frederic Müller updated MCHECKSTYLE-131:
----------------------------------------

    Attachment: example.zip

This is an example project. Using the maven-checkstyle-plugin version 2.5 the build fails:

Embedded error: Failed during checkstyle execution
Could not find resource 'checkstyle.xml'.

Version 2.4 works just as expected.

> Plugin can't use configLocation from parent.
> --------------------------------------------
>
>                 Key: MCHECKSTYLE-131
>                 URL: http://jira.codehaus.org/browse/MCHECKSTYLE-131
>             Project: Maven 2.x Checkstyle Plugin
>          Issue Type: Bug
>    Affects Versions: 2.5
>            Reporter: Frederic Müller
>            Assignee: Olivier Lamy
>            Priority: Critical
>             Fix For: 2.6
>
>         Attachments: example.zip
>
>
> Since Version 2.5 the checkstyle plugin no longer uses a configLocation that is located in the parent project but fails the build because of a missing resource.
> Version 2.4 is working as expected.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] Issue Comment Edited: (MCHECKSTYLE-131) Plugin can't use configLocation from parent.

Posted by "Olivier Lamy (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MCHECKSTYLE-131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=210230#action_210230 ] 

Olivier Lamy edited comment on MCHECKSTYLE-131 at 2/15/10 2:39 PM:
-------------------------------------------------------------------

please provide a sample project in order to reproduce the issue.
Thanks !

      was (Author: olamy):
    it test please.
Thanks !
  
> Plugin can't use configLocation from parent.
> --------------------------------------------
>
>                 Key: MCHECKSTYLE-131
>                 URL: http://jira.codehaus.org/browse/MCHECKSTYLE-131
>             Project: Maven 2.x Checkstyle Plugin
>          Issue Type: Bug
>    Affects Versions: 2.5
>            Reporter: Frederic Müller
>            Assignee: Olivier Lamy
>            Priority: Critical
>             Fix For: 2.6
>
>
> Since Version 2.5 the checkstyle plugin no longer uses a configLocation that is located in the parent project but fails the build because of a missing resource.
> Version 2.4 is working as expected.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] Commented: (MCHECKSTYLE-131) Plugin can't use configLocation from parent.

Posted by "Olivier Lamy (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MCHECKSTYLE-131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=210809#action_210809 ] 

Olivier Lamy commented on MCHECKSTYLE-131:
------------------------------------------

sure I can't find this documentation.
I should have prefered remove this hack. But as it was supported before...

> Plugin can't use configLocation from parent.
> --------------------------------------------
>
>                 Key: MCHECKSTYLE-131
>                 URL: http://jira.codehaus.org/browse/MCHECKSTYLE-131
>             Project: Maven 2.x Checkstyle Plugin
>          Issue Type: Bug
>    Affects Versions: 2.5
>            Reporter: Frederic Müller
>            Assignee: Olivier Lamy
>            Priority: Critical
>             Fix For: 2.6
>
>         Attachments: example.zip
>
>
> Since Version 2.5 the checkstyle plugin no longer uses a configLocation that is located in the parent project but fails the build because of a missing resource.
> Version 2.4 is working as expected.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] Commented: (MCHECKSTYLE-131) Plugin can't use configLocation from parent.

Posted by "Olivier Lamy (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MCHECKSTYLE-131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=210230#action_210230 ] 

Olivier Lamy commented on MCHECKSTYLE-131:
------------------------------------------

it test please.
Thanks !

> Plugin can't use configLocation from parent.
> --------------------------------------------
>
>                 Key: MCHECKSTYLE-131
>                 URL: http://jira.codehaus.org/browse/MCHECKSTYLE-131
>             Project: Maven 2.x Checkstyle Plugin
>          Issue Type: Bug
>    Affects Versions: 2.5
>            Reporter: Frederic Müller
>            Priority: Critical
>             Fix For: 2.6
>
>
> Since Version 2.5 the checkstyle plugin no longer uses a configLocation that is located in the parent project but fails the build because of a missing resource.
> Version 2.4 is working as expected.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira