[GitHub] [iceberg] rdblue commented on a diff in pull request #4246: Flink: Add support for ResolvedSchema

[GitBox <gi...@apache.org>]

rdblue commented on code in PR #4246:
URL: https://github.com/apache/iceberg/pull/4246#discussion_r878407072


##########
flink/v1.14/flink/src/main/java/org/apache/iceberg/flink/FlinkDynamicTableFactory.java:
##########
@@ -71,14 +69,6 @@
           .noDefaultValue()
           .withDescription("Table name managed in the underlying iceberg catalog and database.");
 
-  // Flink 1.13.x change the return type from CatalogTable interface to ResolvedCatalogTable which extends the
-  // CatalogTable. Here we use the dynamic method loading approach to avoid adding explicit CatalogTable or
-  // ResolvedCatalogTable class into the iceberg-flink-runtime jar for compatibility purpose.
-  private static final DynMethods.UnboundMethod GET_CATALOG_TABLE = DynMethods.builder("getCatalogTable")
-      .impl(Context.class, "getCatalogTable")
-      .orNoop()
-      .build();

Review Comment:
   I think this was done in a separate PR. Can you rebase?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org