You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by clebertsuconic <gi...@git.apache.org> on 2017/02/20 17:00:30 UTC
[GitHub] qpid-proton-j pull request #7: PROTON-1409 Exposing delivery length
GitHub user clebertsuconic opened a pull request:
https://github.com/apache/qpid-proton-j/pull/7
PROTON-1409 Exposing delivery length
This is to expose the delivery length to allow creating the buffer with the required bytes only
https://issues.apache.org/jira/browse/PROTON-1409
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/clebertsuconic/qpid-proton-j proton-1409
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/qpid-proton-j/pull/7.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #7
----
commit 953f0aee9cc5ce95f80cb2a9c1f3628c07429605
Author: Clebert Suconic <cl...@apache.org>
Date: 2017-02-17T03:29:02Z
PROTON-1409 Exposing delivery length
This is to expose the delivery length to allow creating the buffer with the required bytes only
https://issues.apache.org/jira/browse/PROTON-1409
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-proton-j issue #7: PROTON-1409 Exposing delivery length
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/qpid-proton-j/pull/7
@gemmellr since the current method is not part of the api, I renamed it to getReadableBytes, changed a test to allocate the exact number of bytes available before the recv was called, and added some javadoc.
Let me know if you see any edits on the javadoc I wrote. Or feel free to commit on top of that of course.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-proton-j issue #7: PROTON-1409 Exposing delivery length
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/qpid-proton-j/pull/7
getReadableBytes is in line with other buffers.. I thought it would be more intuitive.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-proton-j issue #7: PROTON-1409 Exposing delivery length
Posted by gemmellr <gi...@git.apache.org>.
Github user gemmellr commented on the issue:
https://github.com/apache/qpid-proton-j/pull/7
I've pushed a change to expose the currently available bytes length. I went with 'available()' since it felt natural for what its indicating, and applying to both send/recv cases. In hindsight, 'remaining' could also be good, as thats what proton uses for actual buffers, though I think I still prefer 'available' here.
I've just left the existing method unchanged for now, keeping it aligned with the various other related impl methods and as a bonus delays screwing with anyone who had been reflecting access to it thus far, we can consolidate them as and when the impl changes otherwise.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-proton-j issue #7: PROTON-1409 Exposing delivery length
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/qpid-proton-j/pull/7
@gemmellr if you could help me by fixing this any way you like and get it by next release? I'm currently having to allocate a bigger Netty buffer than required when receiving Deliveries through my loop on Artemis.
I'm about to make a big commit, and if this was release it would be great.
Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-proton-j pull request #7: PROTON-1409 Exposing delivery length
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/qpid-proton-j/pull/7
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-proton-j issue #7: PROTON-1409 Exposing delivery length
Posted by gemmellr <gi...@git.apache.org>.
Github user gemmellr commented on the issue:
https://github.com/apache/qpid-proton-j/pull/7
The javadoc could do with making a little clearer that it returns the currently unread length of the existing payload for the delivery, and is not the length of the delivery (which might not be complete yet) or the buffer containing the contents, which both may differ at any given time.
A test would be nice so the new public method is at used and folks can see how it is.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-proton-j issue #7: PROTON-1409 Exposing delivery length
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/qpid-proton-j/pull/7
This supersedes #5
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org