You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@giraph.apache.org by Alessandro Presta <al...@fb.com> on 2013/07/11 01:03:40 UTC

Re: Review Request 12455: GIRAPH-714: Add specialized message stores for int/long ids and generic combinable message type

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12455/
-----------------------------------------------------------

(Updated July 10, 2013, 11:03 p.m.)


Review request for giraph.


Changes
-------

- Added a version for int ids
- Updated factory


Summary (updated)
-----------------

GIRAPH-714: Add specialized message stores for int/long ids and generic combinable message type


Repository: giraph-git


Description (updated)
-------

Similar to Int/LongDoubleMessageStore, but the message type can be anything (as long as it can be combined).


Diffs (updated)
-----

  giraph-core/src/main/java/org/apache/giraph/comm/messages/InMemoryMessageStoreFactory.java 40674e1c74ede0c39a5a55f5eb0e2f114aecb481 
  giraph-core/src/main/java/org/apache/giraph/comm/messages/primitives/IntObjectMessageStore.java PRE-CREATION 
  giraph-core/src/main/java/org/apache/giraph/comm/messages/primitives/LongObjectMessageStore.java PRE-CREATION 
  giraph-core/src/test/java/org/apache/giraph/comm/messages/TestIntFloatPrimitiveMessageStores.java a8f6f70cdb59edf55e2eb441564e9c7ff5376ae5 
  giraph-core/src/test/java/org/apache/giraph/comm/messages/TestLongDoublePrimitiveMessageStores.java 065926092bc886d680ad07849ad1b614e82b5bab 

Diff: https://reviews.apache.org/r/12455/diff/


Testing
-------

mvn clean verify


Thanks,

Alessandro Presta