You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Ian Boston (JIRA)" <ji...@apache.org> on 2012/10/29 00:39:12 UTC

[jira] [Comment Edited] (SLING-2538) Remove fallback code for old resource implementations

    [ https://issues.apache.org/jira/browse/SLING-2538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485745#comment-13485745 ] 

Ian Boston edited comment on SLING-2538 at 10/28/12 11:38 PM:
--------------------------------------------------------------

Appears to be caused[1] by an unclosed session after JcrResourceListenerTest[2] which passed.

Since I think this is not related to the changes made in this issue and I can't reproduce locally, I am going to re-close and see if its reported elsewhere.

1 https://builds.apache.org/job/sling-trunk-1.5/org.apache.sling$org.apache.sling.jcr.resource/1835/testReport/org.apache.sling.jcr.resource.internal/JcrModifiablePropertyMapTest/testInputStream/
2 https://builds.apache.org/job/sling-trunk-1.5/org.apache.sling$org.apache.sling.jcr.resource/1835/testReport/org.apache.sling.jcr.resource.internal/JcrResourceListenerTest/
                
      was (Author: ianeboston):
    Appears to be caused[1] by an unclosed session after JcrResourceListenerTest[2] which passed.

Since I think this is not related to the changes made in this issue and I can reproduce locally, I am going to re-close and see if its reported elsewhere.

1 https://builds.apache.org/job/sling-trunk-1.5/org.apache.sling$org.apache.sling.jcr.resource/1835/testReport/org.apache.sling.jcr.resource.internal/JcrModifiablePropertyMapTest/testInputStream/
2 https://builds.apache.org/job/sling-trunk-1.5/org.apache.sling$org.apache.sling.jcr.resource/1835/testReport/org.apache.sling.jcr.resource.internal/JcrResourceListenerTest/
                  
> Remove fallback code for old resource implementations
> -----------------------------------------------------
>
>                 Key: SLING-2538
>                 URL: https://issues.apache.org/jira/browse/SLING-2538
>             Project: Sling
>          Issue Type: Improvement
>          Components: API
>    Affects Versions: API 2.2.4
>            Reporter: Carsten Ziegeler
>            Assignee: Ian Boston
>             Fix For: API 2.2.6
>
>         Attachments: SLING-2538.patch
>
>
> See SLING-2457 for some examples, we currently have some "unusal" handling of some ResourceUtil/AbstractResource methods which are basically there to support very old implementations of the resource api which predate the 2.1.0 release.
> As we now extended the resource interface as well as resource resolver and other stuff, I think it's time to not support this old stuff anymore and clean up the code

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira