You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "rohityadavcloud (via GitHub)" <gi...@apache.org> on 2024/08/28 06:15:14 UTC
[PR] systemvm: have flags to check x86_64 to install specifics for amd64 arch [cloudstack]
rohityadavcloud opened a new pull request, #9600:
URL: https://github.com/apache/cloudstack/pull/9600
This flips conditional checks to check specifically for x86_64/amd64 to install dependencies in systemvm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] systemvm: have flags to check x86_64 to install specifics for amd64 arch [cloudstack]
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud merged PR #9600:
URL: https://github.com/apache/cloudstack/pull/9600
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] systemvm: have flags to check x86_64 to install specifics for amd64 arch [cloudstack]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #9600:
URL: https://github.com/apache/cloudstack/pull/9600#issuecomment-2314413924
## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9600?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 4.16%. Comparing base [(`70131be`)](https://app.codecov.io/gh/apache/cloudstack/commit/70131be8c22b7c22c3cd97d5b74390d280797d41?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`8a08491`)](https://app.codecov.io/gh/apache/cloudstack/commit/8a08491faf4d051b6d23f6c3beeced64f241b043?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> :exclamation: There is a different number of reports uploaded between BASE (70131be) and HEAD (8a08491). Click for more details.
>
> <details><summary>HEAD has 1 upload less than BASE</summary>
>
>| Flag | BASE (70131be) | HEAD (8a08491) |
>|------|------|------|
>|unittests|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #9600 +/- ##
============================================
- Coverage 15.58% 4.16% -11.42%
============================================
Files 5504 377 -5127
Lines 482331 30889 -451442
Branches 60328 5466 -54862
============================================
- Hits 75148 1288 -73860
+ Misses 398879 29455 -369424
+ Partials 8304 146 -8158
```
| [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/9600/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/9600/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.16% <ø> (ø)` | |
| [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/9600/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/9600?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] systemvm: have flags to check x86_64 to install specifics for amd64 arch [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #9600:
URL: https://github.com/apache/cloudstack/pull/9600#issuecomment-2314921637
> @DaanHoogland kicked build using Jenkins, to see arm64 & x86_64 template building okay which should be enough to validate this PR: https://build.yadav.cloud/systemvm/
>
> Build logs: [build-arm64.txt](https://github.com/user-attachments/files/16781435/build-arm64.txt) [build-x86.txt](https://github.com/user-attachments/files/16781436/build-x86.txt)
agree on those two @rohityadavcloud . I was just wondering about the s390x arch; is it used anywhere and do we know anybody willing to test that one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] systemvm: have flags to check x86_64 to install specifics for amd64 arch [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #9600:
URL: https://github.com/apache/cloudstack/pull/9600#issuecomment-2314702341
@rohityadavcloud , how do we test s390x? do we know a guy ;) ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] systemvm: have flags to check x86_64 to install specifics for amd64 arch [cloudstack]
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #9600:
URL: https://github.com/apache/cloudstack/pull/9600#issuecomment-2314862275
@DaanHoogland kicked build using Jenkins, to see arm64 & x86_64 template building okay: https://build.yadav.cloud/systemvm/
Build logs:
[build-arm64.txt](https://github.com/user-attachments/files/16781435/build-arm64.txt)
[build-x86.txt](https://github.com/user-attachments/files/16781436/build-x86.txt)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org