You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/05/20 08:17:26 UTC

[GitHub] [activemq-artemis] gtully commented on a change in pull request #3589: ARTEMIS-3294 Fix testTextMessageAttributeLimits

gtully commented on a change in pull request #3589:
URL: https://github.com/apache/activemq-artemis/pull/3589#discussion_r635878475



##########
File path: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/QueueControlTest.java
##########
@@ -579,7 +579,8 @@ public void testTextMessageAttributeLimits() throws Exception {
 
       final String twentyBytes = new String(new char[20]).replace("\0", "#");
 
-      ClientMessage clientMessage = createTextMessage(session, twentyBytes, true);

Review comment:
       is there any value in the existing test?
   
   I guess it is possible to put anything into a core message, it is up to the reader to know that it will be possibly nullable, no? Or was the assumption just wrong. It is an error to encode a plain string?
   
   if it is not an error, then maybe we need to include both test variants.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org