You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/31 17:28:07 UTC

[GitHub] [spark] MaxGekk opened a new pull request #32016: [SPARK-34903][SQL] Return day-time interval from timestamps subtraction

MaxGekk opened a new pull request #32016:
URL: https://github.com/apache/spark/pull/32016


   ### What changes were proposed in this pull request?
   Modify the `SubtractTimestamps` expression to return values of `DayTimeIntervalType` when `spark.sql.legacy.interval.enabled` is set to `false` (which is the default).
   
   ### Why are the changes needed?
   To conform to the ANSI SQL standard which requires ANSI intervals as the result of timestamps subtraction, see
   <img width="656" alt="Screenshot 2021-03-29 at 19 09 34" src="https://user-images.githubusercontent.com/1580697/112866455-7e2f0d00-90c2-11eb-96e6-3feb7eea7e09.png">
   
   
   ### Does this PR introduce _any_ user-facing change?
   Yes.
   
   ### How was this patch tested?
   By running new tests:
   ```
   $ build/sbt "test:testOnly *DateTimeUtilsSuite"
   $ build/sbt "test:testOnly *DateExpressionsSuite"
   $ build/sbt "test:testOnly *ColumnExpressionSuite"
   ```
   and some tests from `SQLQueryTestSuite`:
   ```
   $ build/sbt "sql/testOnly *SQLQueryTestSuite -- -z timestamp.sql"
   $ build/sbt "sql/testOnly *SQLQueryTestSuite -- -z datetime.sql"
   $ build/sbt "sql/testOnly *SQLQueryTestSuite -- -z interval.sql"
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #32016: [SPARK-34903][SQL] Return day-time interval from timestamps subtraction

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32016:
URL: https://github.com/apache/spark/pull/32016#issuecomment-811282998


   **[Test build #136779 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136779/testReport)** for PR 32016 at commit [`960b23f`](https://github.com/apache/spark/commit/960b23f0bea6a0254329d397e526f9f34010b0b0).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32016: [SPARK-34903][SQL] Return day-time interval from timestamps subtraction

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32016:
URL: https://github.com/apache/spark/pull/32016#issuecomment-811485537


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41365/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #32016: [SPARK-34903][SQL] Return day-time interval from timestamps subtraction

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32016:
URL: https://github.com/apache/spark/pull/32016#issuecomment-811481725


   Kubernetes integration test unable to build dist.
   
   exiting with code: 1
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41365/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #32016: [SPARK-34903][SQL] Return day-time interval from timestamps subtraction

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32016:
URL: https://github.com/apache/spark/pull/32016#issuecomment-811566126


   **[Test build #136782 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136782/testReport)** for PR 32016 at commit [`bf63532`](https://github.com/apache/spark/commit/bf635327b756b343cb0c80e8cbfeb848401b6403).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32016: [SPARK-34903][SQL] Return day-time interval from timestamps subtraction

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32016:
URL: https://github.com/apache/spark/pull/32016#issuecomment-811577360


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136782/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #32016: [SPARK-34903][SQL] Return day-time interval from timestamps subtraction

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32016:
URL: https://github.com/apache/spark/pull/32016#issuecomment-811333871


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41362/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #32016: [SPARK-34903][SQL] Return day-time interval from timestamps subtraction

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32016:
URL: https://github.com/apache/spark/pull/32016#issuecomment-811577360


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136782/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #32016: [SPARK-34903][SQL] Return day-time interval from timestamps subtraction

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32016:
URL: https://github.com/apache/spark/pull/32016#issuecomment-811459947


   **[Test build #136782 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136782/testReport)** for PR 32016 at commit [`bf63532`](https://github.com/apache/spark/commit/bf635327b756b343cb0c80e8cbfeb848401b6403).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #32016: [SPARK-34903][SQL] Return day-time interval from timestamps subtraction

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32016:
URL: https://github.com/apache/spark/pull/32016#issuecomment-811314008


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41362/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #32016: [SPARK-34903][SQL] Return day-time interval from timestamps subtraction

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32016:
URL: https://github.com/apache/spark/pull/32016#issuecomment-811459947


   **[Test build #136782 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136782/testReport)** for PR 32016 at commit [`bf63532`](https://github.com/apache/spark/commit/bf635327b756b343cb0c80e8cbfeb848401b6403).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] MaxGekk commented on pull request #32016: [SPARK-34903][SQL] Return day-time interval from timestamps subtraction

Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #32016:
URL: https://github.com/apache/spark/pull/32016#issuecomment-811706658


   Merging to master. Failed GAs are not related to changes.
   Thank you @yaooqinn @cloud-fan for your review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #32016: [SPARK-34903][SQL] Return day-time interval from timestamps subtraction

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32016:
URL: https://github.com/apache/spark/pull/32016#issuecomment-811326960


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41362/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #32016: [SPARK-34903][SQL] Return day-time interval from timestamps subtraction

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32016:
URL: https://github.com/apache/spark/pull/32016#issuecomment-811513471


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136779/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #32016: [SPARK-34903][SQL] Return day-time interval from timestamps subtraction

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32016:
URL: https://github.com/apache/spark/pull/32016#issuecomment-811497427


   **[Test build #136779 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136779/testReport)** for PR 32016 at commit [`960b23f`](https://github.com/apache/spark/commit/960b23f0bea6a0254329d397e526f9f34010b0b0).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #32016: [SPARK-34903][SQL] Return day-time interval from timestamps subtraction

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32016:
URL: https://github.com/apache/spark/pull/32016#issuecomment-811485537


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41365/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #32016: [SPARK-34903][SQL] Return day-time interval from timestamps subtraction

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32016:
URL: https://github.com/apache/spark/pull/32016#issuecomment-811282998


   **[Test build #136779 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136779/testReport)** for PR 32016 at commit [`960b23f`](https://github.com/apache/spark/commit/960b23f0bea6a0254329d397e526f9f34010b0b0).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32016: [SPARK-34903][SQL] Return day-time interval from timestamps subtraction

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32016:
URL: https://github.com/apache/spark/pull/32016#issuecomment-811333871


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41362/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] MaxGekk closed pull request #32016: [SPARK-34903][SQL] Return day-time interval from timestamps subtraction

Posted by GitBox <gi...@apache.org>.
MaxGekk closed pull request #32016:
URL: https://github.com/apache/spark/pull/32016


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32016: [SPARK-34903][SQL] Return day-time interval from timestamps subtraction

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32016:
URL: https://github.com/apache/spark/pull/32016#issuecomment-811513471


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136779/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org