You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@echarts.apache.org by ni...@bliq.se.INVALID on 2024/06/14 10:08:18 UTC
Re: Omit columns from dataset in aria?
Hi Ovilia,
Can you take a look at:
https://github.com/semla/echarts/commit/ad1d4878dc1e4efec4ce102a7ca9ca0c9ba1d251
Is that a good start?
On 18.02.2024 09:07, Ovilia wrote:
> Hi Nicke,
>
> Thanks for being interested in making a PR.
> No, it's not related. preprocessor.ts#L36 is compatibility related
> code.
>
> You probably need to change
> https://github.com/apache/echarts/blob/031a908fafaa57e2277b2f720087195925ec38cf/src/visual/aria.ts#L141
> .
> Add a new option under "aria.label" to let developers set which columns
> to
> include/exclude.
>
> Another way to do this is not to change the code but to use
> https://echarts.apache.org/en/option.html#aria.label.description to
> manually generate the description so that you have full control over
> it.
>
> Thanks
>
> *Ovilia*
>
>
> On Wed, Feb 14, 2024 at 4:47 AM <ni...@bliq.se.invalid> wrote:
>
>> Any idea how that code would look like?
>> After taking a very brief look I guess this:
>>
>> https://github.com/apache/echarts/blob/031a908fafaa57e2277b2f720087195925ec38cf/src/component/aria/preprocessor.ts#L36
>> has something to do with it?
>>
>> On 05.02.2024 02:53, Ovilia wrote:
>> > Hi,
>> >
>> > Currently, Apache ECharts doesn't have such abilities. If you are
>> > interested in making a pull request, please checkout
>> > https://github.com/apache/echarts/wiki/How-to-make-a-pull-request
>> >
>> > Thanks
>> >
>> > *Ovilia*
>> >
>> >
>> > On Mon, Feb 5, 2024 at 3:14 AM <ni...@bliq.se.invalid> wrote:
>> >
>> >> iiuc the aria-label describes all of the data in the dataset. Is it
>> >> possible to only show some columns?
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@echarts.apache.org
>> For additional commands, e-mail: dev-help@echarts.apache.org
>>
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@echarts.apache.org
For additional commands, e-mail: dev-help@echarts.apache.org
Re: Omit columns from dataset in aria?
Posted by Ovilia <ov...@gmail.com>.
Yes, Niche, thank you for your contribution. I believe this should work. We
just need to add a few test cases (
https://github.com/apache/echarts/wiki/How-to-make-a-pull-request#test) and
then submit a pull request to Apache ECharts.
Thanks
*Ovilia*
On Fri, Jun 14, 2024 at 6:08 PM <ni...@bliq.se.invalid> wrote:
> Hi Ovilia,
> Can you take a look at:
>
> https://github.com/semla/echarts/commit/ad1d4878dc1e4efec4ce102a7ca9ca0c9ba1d251
> Is that a good start?
>
> On 18.02.2024 09:07, Ovilia wrote:
> > Hi Nicke,
> >
> > Thanks for being interested in making a PR.
> > No, it's not related. preprocessor.ts#L36 is compatibility related
> > code.
> >
> > You probably need to change
> >
> https://github.com/apache/echarts/blob/031a908fafaa57e2277b2f720087195925ec38cf/src/visual/aria.ts#L141
> > .
> > Add a new option under "aria.label" to let developers set which columns
> > to
> > include/exclude.
> >
> > Another way to do this is not to change the code but to use
> > https://echarts.apache.org/en/option.html#aria.label.description to
> > manually generate the description so that you have full control over
> > it.
> >
> > Thanks
> >
> > *Ovilia*
> >
> >
> > On Wed, Feb 14, 2024 at 4:47 AM <ni...@bliq.se.invalid> wrote:
> >
> >> Any idea how that code would look like?
> >> After taking a very brief look I guess this:
> >>
> >>
> https://github.com/apache/echarts/blob/031a908fafaa57e2277b2f720087195925ec38cf/src/component/aria/preprocessor.ts#L36
> >> has something to do with it?
> >>
> >> On 05.02.2024 02:53, Ovilia wrote:
> >> > Hi,
> >> >
> >> > Currently, Apache ECharts doesn't have such abilities. If you are
> >> > interested in making a pull request, please checkout
> >> > https://github.com/apache/echarts/wiki/How-to-make-a-pull-request
> >> >
> >> > Thanks
> >> >
> >> > *Ovilia*
> >> >
> >> >
> >> > On Mon, Feb 5, 2024 at 3:14 AM <ni...@bliq.se.invalid> wrote:
> >> >
> >> >> iiuc the aria-label describes all of the data in the dataset. Is it
> >> >> possible to only show some columns?
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@echarts.apache.org
> >> For additional commands, e-mail: dev-help@echarts.apache.org
> >>
> >>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@echarts.apache.org
> For additional commands, e-mail: dev-help@echarts.apache.org
>
>