[GitHub] [cloudstack] davidjumani commented on a change in pull request #5307: Filter disk / service offerings by domain at DB level

[GitBox <gi...@apache.org>]

davidjumani commented on a change in pull request #5307:
URL: https://github.com/apache/cloudstack/pull/5307#discussion_r700893129



##########
File path: engine/schema/src/main/java/com/cloud/service/dao/ServiceOfferingDetailsDaoImpl.java
##########
@@ -67,4 +71,23 @@ public String getDetail(Long serviceOfferingId, String key) {
         }
         return detailValue;
     }
+
+    @Override
+    public List<Long> findOfferingIdsByDomainIds(List<Long> domainIds) {
+        Object[] dIds = domainIds.stream().map(s -> String.valueOf(s)).collect(Collectors.toList()).toArray();

Review comment:
       Refactored and updated

##########
File path: engine/schema/src/main/java/org/apache/cloudstack/resourcedetail/dao/DiskOfferingDetailsDaoImpl.java
##########
@@ -66,4 +71,25 @@ public String getDetail(Long diskOfferingId, String key) {
         }
         return detailValue;
     }
-}
\ No newline at end of file
+
+    @Override
+    public List<Long> findOfferingIdsByDomainIds(List<Long> domainIds) {

Review comment:
       Refactored and updated




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org