You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Sergey Shelukhin <se...@hortonworks.com> on 2013/12/14 02:38:41 UTC
Review Request 16269: HIVE-6034 vectorized % doesn't handle zeroes the same
way as non-vectorized
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16269/
-----------------------------------------------------------
Review request for hive and Jitendra Pandey.
Repository: hive-git
Description
-------
see JIRA
Diffs
-----
ant/src/org/apache/hadoop/hive/ant/GenVectorCode.java a286024
ql/src/gen/vectorization/ExpressionTemplates/ColumnDivideColumn.txt 218ab6f
ql/src/gen/vectorization/ExpressionTemplates/ScalarDivideColumn.txt c969b2f
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/NullUtil.java e4ee372
ql/src/test/queries/clientpositive/vectorization_12.q 78af086
ql/src/test/queries/clientpositive/vectorization_14.q bc7730d
ql/src/test/results/clientpositive/vectorization_12.q.out 01e2506
ql/src/test/results/clientpositive/vectorization_14.q.out 247197a
Diff: https://reviews.apache.org/r/16269/diff/
Testing
-------
Thanks,
Sergey Shelukhin
Re: Review Request 16269: HIVE-6034 vectorized % doesn't handle zeroes the
same way as non-vectorized
Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16269/
-----------------------------------------------------------
(Updated Dec. 16, 2013, 7:18 p.m.)
Review request for hive and Jitendra Pandey.
Repository: hive-git
Description
-------
see JIRA
Diffs (updated)
-----
ant/src/org/apache/hadoop/hive/ant/GenVectorCode.java a286024
ql/src/gen/vectorization/ExpressionTemplates/ColumnDivideColumn.txt 218ab6f
ql/src/gen/vectorization/ExpressionTemplates/ScalarDivideColumn.txt c969b2f
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/NullUtil.java e4ee372
ql/src/test/queries/clientpositive/vectorization_12.q 78af086
ql/src/test/queries/clientpositive/vectorization_14.q bc7730d
ql/src/test/results/clientpositive/vectorization_12.q.out 01e2506
ql/src/test/results/clientpositive/vectorization_14.q.out 247197a
Diff: https://reviews.apache.org/r/16269/diff/
Testing
-------
Thanks,
Sergey Shelukhin
Re: Review Request 16269: HIVE-6034 vectorized % doesn't handle zeroes the
same way as non-vectorized
Posted by Eric Hanson <eh...@microsoft.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16269/#review30454
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/NullUtil.java
<https://reviews.apache.org/r/16269/#comment58256>
Instead of NaN say "the null data value". NaN is only for double.
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/NullUtil.java
<https://reviews.apache.org/r/16269/#comment58258>
Can we remove this statement about infinities? The code does not check for infinities, just 0 denoms. The point here is that zero divide is supposed to yield NULL.
It is worth thinking about whether infinity, NaN, etc. can be found in the stored data and if that causes any correctness issues elsewhere.
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/NullUtil.java
<https://reviews.apache.org/r/16269/#comment58257>
Again, NaN is only for double, not long
- Eric Hanson
On Dec. 14, 2013, 1:38 a.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16269/
> -----------------------------------------------------------
>
> (Updated Dec. 14, 2013, 1:38 a.m.)
>
>
> Review request for hive and Jitendra Pandey.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> see JIRA
>
>
> Diffs
> -----
>
> ant/src/org/apache/hadoop/hive/ant/GenVectorCode.java a286024
> ql/src/gen/vectorization/ExpressionTemplates/ColumnDivideColumn.txt 218ab6f
> ql/src/gen/vectorization/ExpressionTemplates/ScalarDivideColumn.txt c969b2f
> ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/NullUtil.java e4ee372
> ql/src/test/queries/clientpositive/vectorization_12.q 78af086
> ql/src/test/queries/clientpositive/vectorization_14.q bc7730d
> ql/src/test/results/clientpositive/vectorization_12.q.out 01e2506
> ql/src/test/results/clientpositive/vectorization_14.q.out 247197a
>
> Diff: https://reviews.apache.org/r/16269/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>