You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "asbachb (via GitHub)" <gi...@apache.org> on 2023/06/27 09:39:15 UTC

[GitHub] [netbeans] asbachb opened a new pull request, #6129: Jakarta EE Entitiy and EJB support

asbachb opened a new pull request, #6129:
URL: https://github.com/apache/netbeans/pull/6129

   Added ability for Jakarta EE projects to:
   * Create entities from database tables
   * Create message driven, stateful, stateless and session beans
   
   This should fix #4827 #4828


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] matthiasblaesing commented on pull request #6129: Jakarta EE Entitiy and EJB support

Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on PR #6129:
URL: https://github.com/apache/netbeans/pull/6129#issuecomment-1622279469

   If noone objects, I'll merge on the weekend. @juneau001 you might want to have a look.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] juneau001 commented on a diff in pull request #6129: Jakarta EE Entitiy and EJB support

Posted by "juneau001 (via GitHub)" <gi...@apache.org>.
juneau001 commented on code in PR #6129:
URL: https://github.com/apache/netbeans/pull/6129#discussion_r1255055306


##########
enterprise/j2ee.ejbcore/src/org/netbeans/modules/j2ee/ejbcore/ejb/wizard/session/SessionEJBWizard.java:
##########


Review Comment:
   Does this need to support Jakarta EE 9+?  I am testing on a Jakarta EE 10 project and javax.* entities are being generated.



##########
java/j2ee.persistence/src/org/netbeans/modules/j2ee/persistence/wizard/entity/EntityWizard.java:
##########


Review Comment:
   I'm not 100% if this needs to be adjusted at all for Jakarta EE 9+...looks great with the new enterprisePrefix, but my entities are still being generated with javax.* on a Jakarta EE 10 project



##########
enterprise/j2ee.ejbcore/src/org/netbeans/modules/j2ee/ejbcore/ejb/wizard/jpa/dao/AppServerValidationPanel.java:
##########


Review Comment:
   Does this need to support Jakarta EE 9+?  I am testing on a Jakarta EE 10 project and javax.* entities are being generated.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] asbachb commented on pull request #6129: Jakarta EE Entitiy and EJB support

Posted by "asbachb (via GitHub)" <gi...@apache.org>.
asbachb commented on PR #6129:
URL: https://github.com/apache/netbeans/pull/6129#issuecomment-1610999806

   Added files to `licenseinfo.xml`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] asbachb commented on pull request #6129: Jakarta EE Entitiy and EJB support

Posted by "asbachb (via GitHub)" <gi...@apache.org>.
asbachb commented on PR #6129:
URL: https://github.com/apache/netbeans/pull/6129#issuecomment-1638172572

   Pushed fixed for that use case. Tested with steps mentioned in https://github.com/apache/netbeans/pull/6129#pullrequestreview-1531768724
   
   * Jakarta EE 10 application
   * Jakarta EE 8 application


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] mbien commented on pull request #6129: Jakarta EE Entitiy and EJB support

Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #6129:
URL: https://github.com/apache/netbeans/pull/6129#issuecomment-1638109970

   can we merge this and fix the remaining issue during RC1?
   
   my understanding is:
    - this PR causes no known regression
    - it improves the current situation
    - the remaining problem is fixable without having to rewrite everything
    
    deadline is today night UTC


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] asbachb commented on pull request #6129: Jakarta EE Entitiy and EJB support

Posted by "asbachb (via GitHub)" <gi...@apache.org>.
asbachb commented on PR #6129:
URL: https://github.com/apache/netbeans/pull/6129#issuecomment-1636994144

   @juneau001 @matthiasblaesing @mbien can we get this back to move somehow? Would be nice to have it in NB19.
   
   I created two maven web applications one with jakarta ee 10 and one with jakarta ee 9 in NetBeans 18 and opened it with the PR. Stateful and stateless session beans were created with the correct imports.
   So I'm currently unable to reproduce the mentioned behavior without further details. @juneau001 can you double check?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] matthiasblaesing commented on a diff in pull request #6129: Jakarta EE Entitiy and EJB support

Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on code in PR #6129:
URL: https://github.com/apache/netbeans/pull/6129#discussion_r1244269706


##########
java/j2ee.persistence/src/org/netbeans/modules/j2ee/persistence/wizard/entity/EntityWizard.java:
##########
@@ -135,17 +138,26 @@ public void initialize(WizardDescriptor wizardDescriptor) {
     
     @Override
     public Set instantiate() throws IOException {
+        Project project = Templates.getProject(wiz);
+        
+        JPAModuleInfo moduleInfo = project.getLookup().lookup(JPAModuleInfo.class);
+        Double webXmlVersion = Double.parseDouble(moduleInfo.getVersion());
+
+        String enterprisePrefix = "jakarta";
+        if (webXmlVersion < JAKARTA_EE_9_WEB_APP_DD_VERSION) {

Review Comment:
   Wouldn't it make sense to use the mechanism modified in `PersistentenceClientEntitySelectionVisual.java` (Classpath checking) to decide which variant to use? `JPAModuleInfo` might not represent a web, but an EJB module, not sure how the versionioning is currently, but you might have to check `type` in addtion to `version`.



##########
enterprise/j2ee.ejbcore/nbproject/org-netbeans-modules-j2ee-ejbcore.sig:
##########
@@ -159,6 +159,8 @@ meth public java.awt.im.InputMethodRequests getInputMethodRequests()
 meth public java.awt.image.ColorModel getColorModel()
 meth public java.awt.image.VolatileImage createVolatileImage(int,int)
 meth public java.awt.image.VolatileImage createVolatileImage(int,int,java.awt.ImageCapabilities) throws java.awt.AWTException
+meth public java.awt.peer.ComponentPeer getPeer()

Review Comment:
   This is surprising. And checking history, yes it should not be there. Don't know why it was removed, but we should not regress.
   
   https://github.com/apache/netbeans/commit/53a7a7594f77d68584acd94aeee9ff6c206e82cd



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] asbachb commented on a diff in pull request #6129: Jakarta EE Entitiy and EJB support

Posted by "asbachb (via GitHub)" <gi...@apache.org>.
asbachb commented on code in PR #6129:
URL: https://github.com/apache/netbeans/pull/6129#discussion_r1244880853


##########
enterprise/j2ee.ejbcore/nbproject/org-netbeans-modules-j2ee-ejbcore.sig:
##########
@@ -159,6 +159,8 @@ meth public java.awt.im.InputMethodRequests getInputMethodRequests()
 meth public java.awt.image.ColorModel getColorModel()
 meth public java.awt.image.VolatileImage createVolatileImage(int,int)
 meth public java.awt.image.VolatileImage createVolatileImage(int,int,java.awt.ImageCapabilities) throws java.awt.AWTException
+meth public java.awt.peer.ComponentPeer getPeer()

Review Comment:
   Removed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] asbachb commented on a diff in pull request #6129: Jakarta EE Entitiy and EJB support

Posted by "asbachb (via GitHub)" <gi...@apache.org>.
asbachb commented on code in PR #6129:
URL: https://github.com/apache/netbeans/pull/6129#discussion_r1244881872


##########
java/j2ee.persistence/src/org/netbeans/modules/j2ee/persistence/wizard/entity/EntityWizard.java:
##########
@@ -135,17 +138,26 @@ public void initialize(WizardDescriptor wizardDescriptor) {
     
     @Override
     public Set instantiate() throws IOException {
+        Project project = Templates.getProject(wiz);
+        
+        JPAModuleInfo moduleInfo = project.getLookup().lookup(JPAModuleInfo.class);
+        Double webXmlVersion = Double.parseDouble(moduleInfo.getVersion());
+
+        String enterprisePrefix = "jakarta";
+        if (webXmlVersion < JAKARTA_EE_9_WEB_APP_DD_VERSION) {

Review Comment:
   I double checked with an EJB Module project which you're right does not match the logic.
   
   Replaced it with a classpath check as suggested.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] matthiasblaesing merged pull request #6129: Jakarta EE Entitiy and EJB support

Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing merged PR #6129:
URL: https://github.com/apache/netbeans/pull/6129


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] asbachb commented on pull request #6129: Jakarta EE Entitiy and EJB support

Posted by "asbachb (via GitHub)" <gi...@apache.org>.
asbachb commented on PR #6129:
URL: https://github.com/apache/netbeans/pull/6129#issuecomment-1638114028

   I fixed the mentioned use case, currently in testing phase.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] matthiasblaesing commented on pull request #6129: Jakarta EE Entitiy and EJB support

Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on PR #6129:
URL: https://github.com/apache/netbeans/pull/6129#issuecomment-1638482914

   Thanks for the update, I'm doing a local sanity build and if  ok, I'll merge.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists