[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #310: Add more automation to release candidate container

[GitBox <gi...@apache.org>]

mbeckerle commented on a change in pull request #310: Add more automation to release candidate container
URL: https://github.com/apache/incubator-daffodil/pull/310#discussion_r362499177
 
 

 ##########
 File path: containers/release-candidate/daffodil-release-candidate
 ##########
 @@ -170,6 +165,8 @@ sbt \
   "daffodil-japi/genjavadoc:doc" \
   "daffodil-sapi/doc" \
 
+echo "Removing old release candidates..."
+svn delete --force $DAFFODIL_DIST_DIR/$VERSION-* 2> /dev/null
 
 Review comment:
   All this piping errors to dev null seems very problematic to me. Under maintenance if one goofs up the pushd/popd pairings,  or goof up the definitions of things like $DAFFODIL_DIST_DIR you won't get any diagnostics.  At least not from these commands that will fail. So long as that's not a problem (because the errors would be obvious elsewhere in the script) then I'm ok with it I guess. 
   
   If the script is mostly straight line code, then there's little once can mess up under maintenance, so my concern may be unwarranted. 
   
   Is there a less fragile way to do this? E.g., just redirect to a temp file,.....
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services