[jira] [Updated] (OFBIZ-4838) Party Manager Party StatusId Update Fails

["Deepak Dixit (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OFBIZ-4838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Deepak Dixit updated OFBIZ-4838:
--------------------------------
    Attachment: OFBIZ-4838.patch

Applied the patch and tested it on ofbiz trunk, it is working fine but made some following changes   

1) Done some improvement in code to set status for party with statusId = null.

2) I don't think that there is any need to update demo data to set party statusId as this case is handled in setPartyStatus service (i.e if statusId is empty then it is considered as "PARTY_ENABLED")

3) Removed out-parameter newStatusId from service definition as it is not required anywhere other than test-suite created to test "update party status" functionality, so done modifications in test-case itself to fetch party and check its status. Tested it on trunk and it is working as expected.

> Party Manager Party StatusId Update Fails
> -----------------------------------------
>
>                 Key: OFBIZ-4838
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4838
>             Project: OFBiz
>          Issue Type: Bug
>          Components: party
>    Affects Versions: Release 10.04, Release Branch 11.04, Trunk
>         Environment: demo-trunk
>            Reporter: Jacopo Cappellato
>            Priority: Minor
>         Attachments: Analysis Notes from OFBIZ-4838.txt, OFBIZ-4838 Party Entity Set Status Enabled.patch, OFBIZ-4838 Party Group Status Change Test.patch, OFBIZ-4838 Party Group Status Change.patch, OFBIZ-4838.patch
>
>
> Party Manager does not update the party status id correctly.
> To reproduce:
> First:
> In Party Manager lookup party id "Company"
> Click "Update" In Profile > Party Group Information
> Note: Status Id drop-down field displays Enabled
> Click "Save"
> Then:
> In Web Tools Interactive version lookup Party party_id = "Company"
> Expect: StatusId = "Enabled"
> Actual: StatusId = NULL
> PartyServices setPartyStatus is not updating the party status.
> The question before fixing, is there any reason to allow null status id's on a party?
> Shouldn't every party either be Enabled or Disabled? 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)