You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/05/03 07:43:22 UTC

[GitHub] [airflow] c-thiel opened a new pull request, #23441: Add backward compatibility for core__sql_alchemy_conn__cmd

c-thiel opened a new pull request, #23441:
URL: https://github.com/apache/airflow/pull/23441

   This adds backwards compatibility to use the __cmd option on core__sql_alchemy_conn which was lost in the 2.3.0 update.
   
   closes: [#23408]
   related: [#23408]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] eladkal commented on a diff in pull request #23441: Add backward compatibility for core__sql_alchemy_conn__cmd

Posted by GitBox <gi...@apache.org>.

eladkal commented on code in PR #23441:
URL: https://github.com/apache/airflow/pull/23441#discussion_r863676302


##########
airflow/configuration.py:
##########
@@ -140,6 +140,8 @@ class AirflowConfigParser(ConfigParser):
         ('atlas', 'password'),
         ('smtp', 'smtp_password'),
         ('webserver', 'secret_key'),
+        # The following options are deprecated
+        ('core', 'sql_alchemy_conn')

Review Comment:
   ```suggestion
           ('core', 'sql_alchemy_conn'),
   ```
   To fix static checks



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #23441: Add backward compatibility for core__sql_alchemy_conn__cmd

Posted by GitBox <gi...@apache.org>.

github-actions[bot] commented on PR #23441:
URL: https://github.com/apache/airflow/pull/23441#issuecomment-1115951685

   The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #23441: Add backward compatibility for core__sql_alchemy_conn__cmd

Posted by GitBox <gi...@apache.org>.

boring-cyborg[bot] commented on PR #23441:
URL: https://github.com/apache/airflow/pull/23441#issuecomment-1116060140

   Awesome work, congrats on your first merged pull request!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #23441: Add backward compatibility for core__sql_alchemy_conn__cmd

Posted by GitBox <gi...@apache.org>.

potiuk commented on PR #23441:
URL: https://github.com/apache/airflow/pull/23441#issuecomment-1115951542

   Thanks for submitting that BTW! 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk merged pull request #23441: Add backward compatibility for core__sql_alchemy_conn__cmd

Posted by GitBox <gi...@apache.org>.

potiuk merged PR #23441:
URL: https://github.com/apache/airflow/pull/23441


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #23441: Add backward compatibility for core__sql_alchemy_conn__cmd

Posted by GitBox <gi...@apache.org>.

boring-cyborg[bot] commented on PR #23441:
URL: https://github.com/apache/airflow/pull/23441#issuecomment-1115821418

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #23441: Add backward compatibility for core__sql_alchemy_conn__cmd

Posted by GitBox <gi...@apache.org>.

potiuk commented on PR #23441:
URL: https://github.com/apache/airflow/pull/23441#issuecomment-1115951384

   Small static check probiem :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org