[GitHub] [arrow] felipecrv commented on a diff in pull request #36401: GH-35636: [C++] Extract two expensive test suites from compute-vector-test

["felipecrv (via GitHub)" <gi...@apache.org>]

felipecrv commented on code in PR #36401:
URL: https://github.com/apache/arrow/pull/36401#discussion_r1247915334


##########
cpp/src/arrow/compute/kernels/CMakeLists.txt:
##########
@@ -72,12 +72,20 @@ add_arrow_compute_test(vector_test
                        vector_hash_test.cc
                        vector_nested_test.cc
                        vector_replace_test.cc
-                       vector_selection_test.cc
-                       vector_sort_test.cc
                        vector_run_end_encode_test.cc
                        select_k_test.cc
                        test_util.cc)
 
+add_arrow_compute_test(vector_sort_test
+                       SOURCES
+                       vector_sort_test.cc
+                       test_util.cc)
+
+add_arrow_compute_test(vector_selection_test
+                       SOURCES
+                       vector_selection_test.cc
+                       test_util.cc)

Review Comment:
   I was tempted to do it, but I was afraid it would make things worse because `test_util.cc` is so small.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org