[GitHub] [airflow] alexkruc commented on a diff in pull request #25675: Adding a parameter for exclusion of trashed files in GoogleDriveHook

[GitBox <gi...@apache.org>]

alexkruc commented on code in PR #25675:
URL: https://github.com/apache/airflow/pull/25675#discussion_r943793043


##########
airflow/providers/google/suite/hooks/drive.py:
##########
@@ -128,31 +128,45 @@ def get_media_request(self, file_id: str) -> HttpRequest:
         request = service.files().get_media(fileId=file_id)
         return request
 
-    def exists(self, folder_id: str, file_name: str, drive_id: Optional[str] = None):
+    def exists(
+        self, folder_id: str, file_name: str, include_trashed: bool = True, drive_id: Optional[str] = None

Review Comment:
   It is :) this is why we set it with a default value..
   Setting is with `Optional[]` and with default value is redundant, as I'd we don't pass it, it's passed with it's default value..
   
   Am I missing something?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org