You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samza.apache.org by Yan Fang <ya...@gmail.com> on 2014/04/22 01:54:09 UTC
Review Request 20542: Samza-64
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20542/
-----------------------------------------------------------
Review request for samza.
Repository: samza
Description
-------
Fail the samza job when unrecoverable Kafka exception occurs.
Diffs
-----
samza-kafka/src/main/scala/org/apache/samza/checkpoint/kafka/KafkaCheckpointManager.scala fed6eee
samza-kafka/src/test/scala/org/apache/samza/checkpoint/kafka/TestKafkaCheckpointManager.scala f1a8f8a
Diff: https://reviews.apache.org/r/20542/diff/
Testing
-------
Thanks,
Yan Fang
Re: Review Request 20542: Samza-64
Posted by Chris Riccomini <cr...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20542/#review41050
-----------------------------------------------------------
Ship it!
Ship It!
- Chris Riccomini
On April 22, 2014, 7:10 p.m., Yan Fang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20542/
> -----------------------------------------------------------
>
> (Updated April 22, 2014, 7:10 p.m.)
>
>
> Review request for samza.
>
>
> Repository: samza
>
>
> Description
> -------
>
> Fail the samza job when unrecoverable Kafka exception occurs.
>
>
> Diffs
> -----
>
> samza-kafka/src/main/scala/org/apache/samza/checkpoint/kafka/KafkaCheckpointManager.scala fed6eee
> samza-kafka/src/test/scala/org/apache/samza/checkpoint/kafka/TestKafkaCheckpointManager.scala f1a8f8a
>
> Diff: https://reviews.apache.org/r/20542/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Yan Fang
>
>
Re: Review Request 20542: Samza-64
Posted by Yan Fang <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20542/
-----------------------------------------------------------
(Updated April 22, 2014, 7:10 p.m.)
Review request for samza.
Changes
-------
1. Added throwable e to the KafkaCheckpointException
2. Changed checkpointTopic and clientId in getKafkaCheckpointManagerWithInvalidSerde of TestKafkaCheckpintException to make them different from those in getKafkaCheckpointManager. Otherwise, it would fail the test if testUnrecovableKafkaErrorShouldThrowKafkaCheckpointManagerException is run before testCheckpointShouldBeNullIfcheckpointTopicDoesNotExistShouldBeCreatedOnWriteAndShouldBeReadableAfterWrite.
3. Fixed the typo of getKafkaCheckpointManagerWithInvalideSerde to getKafkaCheckpointManagerWithInvalidSerde (removed the e after Invalid)
Repository: samza
Description
-------
Fail the samza job when unrecoverable Kafka exception occurs.
Diffs (updated)
-----
samza-kafka/src/main/scala/org/apache/samza/checkpoint/kafka/KafkaCheckpointManager.scala fed6eee
samza-kafka/src/test/scala/org/apache/samza/checkpoint/kafka/TestKafkaCheckpointManager.scala f1a8f8a
Diff: https://reviews.apache.org/r/20542/diff/
Testing
-------
Thanks,
Yan Fang
Re: Review Request 20542: Samza-64
Posted by Chris Riccomini <cr...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20542/#review41025
-----------------------------------------------------------
samza-kafka/src/main/scala/org/apache/samza/checkpoint/kafka/KafkaCheckpointManager.scala
<https://reviews.apache.org/r/20542/#comment74381>
Could you include e (the throwable) in the KafkaCheckpointException for all three of these, as well?
- Chris Riccomini
On April 21, 2014, 11:54 p.m., Yan Fang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20542/
> -----------------------------------------------------------
>
> (Updated April 21, 2014, 11:54 p.m.)
>
>
> Review request for samza.
>
>
> Repository: samza
>
>
> Description
> -------
>
> Fail the samza job when unrecoverable Kafka exception occurs.
>
>
> Diffs
> -----
>
> samza-kafka/src/main/scala/org/apache/samza/checkpoint/kafka/KafkaCheckpointManager.scala fed6eee
> samza-kafka/src/test/scala/org/apache/samza/checkpoint/kafka/TestKafkaCheckpointManager.scala f1a8f8a
>
> Diff: https://reviews.apache.org/r/20542/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Yan Fang
>
>