You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jason Huynh <hu...@gmail.com> on 2016/03/09 22:58:46 UTC
Review Request 44596: GEODE-562 - Attempt #2: Modify some dependencies
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44596/
-----------------------------------------------------------
Review request for geode, anilkumar gingade, Barry Oglesby, nabarun nag, Dan Smith, and xiaojian zhou.
Repository: geode
Description
-------
The first attempt caused failures in geode-assembly. This one moves the needed dependencies to geode-pulse, geode-web and geode-web-api. It also is less aggressive in reducing scope for hbase and readds sl4j to geode-core (without it, tests in assembly would also fail.) It may be possible to add sl4j to pulse, web, web-api instead but I had not tried that out just yet.
Diffs
-----
extensions/geode-modules/build.gradle f96fde6
geode-core/build.gradle 1aa07ee
geode-pulse/build.gradle 0cd1ef4
geode-rebalancer/build.gradle 9efdff2
geode-web-api/build.gradle 51848c2
geode-web/build.gradle 8ffd9b8
gradle/java.gradle 06fb766
Diff: https://reviews.apache.org/r/44596/diff/
Testing
-------
Thanks,
Jason Huynh
Re: Review Request 44596: GEODE-562 - Attempt #2: Modify some
dependencies
Posted by Dan Smith <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44596/#review122821
-----------------------------------------------------------
Ship it!
Ship It!
- Dan Smith
On March 9, 2016, 9:58 p.m., Jason Huynh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44596/
> -----------------------------------------------------------
>
> (Updated March 9, 2016, 9:58 p.m.)
>
>
> Review request for geode, anilkumar gingade, Barry Oglesby, nabarun nag, Dan Smith, and xiaojian zhou.
>
>
> Repository: geode
>
>
> Description
> -------
>
> The first attempt caused failures in geode-assembly. This one moves the needed dependencies to geode-pulse, geode-web and geode-web-api. It also is less aggressive in reducing scope for hbase and readds sl4j to geode-core (without it, tests in assembly would also fail.) It may be possible to add sl4j to pulse, web, web-api instead but I had not tried that out just yet.
>
>
> Diffs
> -----
>
> extensions/geode-modules/build.gradle f96fde6
> geode-core/build.gradle 1aa07ee
> geode-pulse/build.gradle 0cd1ef4
> geode-rebalancer/build.gradle 9efdff2
> geode-web-api/build.gradle 51848c2
> geode-web/build.gradle 8ffd9b8
> gradle/java.gradle 06fb766
>
> Diff: https://reviews.apache.org/r/44596/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jason Huynh
>
>