You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2020/01/12 03:02:21 UTC

[GitHub] [cordova-plugin-geolocation] andreszs commented on issue #171: Added ANDROID_GPS_REQUIRED parameter for optional GPS

andreszs commented on issue #171: Added ANDROID_GPS_REQUIRED parameter for optional GPS
URL: https://github.com/apache/cordova-plugin-geolocation/pull/171#issuecomment-573377013
 
 
   > 
   > To keep consistency with other plugins, I think the preference should be `GeolocationRequired` instead of `ANDROID_GPS_REQUIRED`. (You can see [StatusBar preferences](https://github.com/apache/cordova-plugin-statusbar#preferences) as an example.
   
   To reflect the fact that this setting applies **only to the Android platform**, I added the _ANDROID_ prefix to the variable. Just to make sure iOS developers don't get confused with it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org