You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by djKooks <gi...@git.apache.org> on 2017/02/12 11:29:29 UTC
[GitHub] incubator-rocketmq pull request #59: Add test case for LocalFileOffsetStore
GitHub user djKooks opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/59
Add test case for LocalFileOffsetStore
I'm reviewing code by testing example and looking on test case. I add some test case which is missing in. If it is okay, I'll keep adding on while review. Don't hesitate to tell me if there is other rule about adding tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/djKooks/incubator-rocketmq add-test-case
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-rocketmq/pull/59.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #59
----
commit 63bc605189bce828236d94c585a197e6cb97df52
Author: kwangin <in...@gmail.com>
Date: 2017-02-12T11:27:04Z
Add test case for LocalFileOffsetStore
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #59: Add test case for LocalFileOffsetStore
Posted by djKooks <gi...@git.apache.org>.
Github user djKooks commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/59
@zhouxinyu Thanks! I'll look on.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #59: Add test case for LocalFileOffsetStore
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/59
[](https://coveralls.io/builds/10113720)
Coverage decreased (-0.08%) to 31.44% when pulling **63bc605189bce828236d94c585a197e6cb97df52 on djKooks:add-test-case** into **573b22c37806a21543b90707bcce6022243a62da on apache:master**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #59: Add test case for LocalFileOffsetStore
Posted by lizhanhui <gi...@git.apache.org>.
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/59
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #59: Add test case for LocalFileOffsetStore
Posted by djKooks <gi...@git.apache.org>.
Github user djKooks commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/59
@dongeforever Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #59: Add test case for LocalFileOffsetStore
Posted by zhouxinyu <gi...@git.apache.org>.
Github user zhouxinyu commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/59
Hi, @djKooks
We would appreciate your any contribution, please feel free to let us know if you have any question.
Some docs may be for your reference:
[1]. http://rocketmq.incubator.apache.org/docs/code-guidelines/
[2]. http://rocketmq.incubator.apache.org/docs/pull-request/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #59: Add test case for LocalFileOffsetStore
Posted by zhouxinyu <gi...@git.apache.org>.
Github user zhouxinyu commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/59
LGTM, please @vongosling @lizhanhui help review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq pull request #59: Add test case for LocalFileOffsetStore
Posted by djKooks <gi...@git.apache.org>.
Github user djKooks closed the pull request at:
https://github.com/apache/incubator-rocketmq/pull/59
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #59: Add test case for LocalFileOffsetStore
Posted by dongeforever <gi...@git.apache.org>.
Github user dongeforever commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/59
+1. This PR has been merged. @djKooks you may want to close it now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---