You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by su...@apache.org on 2021/08/06 23:03:28 UTC
[superset] branch chore/improve-dash-api-speed created (now f3a9acf)
This is an automated email from the ASF dual-hosted git repository.
suddjian pushed a change to branch chore/improve-dash-api-speed
in repository https://gitbox.apache.org/repos/asf/superset.git.
at f3a9acf remove datasource from dashboard/:id/charts
This branch includes the following new commits:
new 7726274 remove unused expensive field
new f3a9acf remove datasource from dashboard/:id/charts
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
[superset] 01/02: remove unused expensive field
Posted by su...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
suddjian pushed a commit to branch chore/improve-dash-api-speed
in repository https://gitbox.apache.org/repos/asf/superset.git
commit 77262741fa81fb69cac1821df763cbae77830a3c
Author: David Aaron Suddjian <aa...@gmail.com>
AuthorDate: Fri Aug 6 12:09:08 2021 -0700
remove unused expensive field
---
.../src/dashboard/components/PropertiesModal/PropertiesModal.test.tsx | 2 --
superset/dashboards/schemas.py | 1 -
tests/integration_tests/dashboards/api_tests.py | 1 -
3 files changed, 4 deletions(-)
diff --git a/superset-frontend/src/dashboard/components/PropertiesModal/PropertiesModal.test.tsx b/superset-frontend/src/dashboard/components/PropertiesModal/PropertiesModal.test.tsx
index e377308..7448877 100644
--- a/superset-frontend/src/dashboard/components/PropertiesModal/PropertiesModal.test.tsx
+++ b/superset-frontend/src/dashboard/components/PropertiesModal/PropertiesModal.test.tsx
@@ -113,8 +113,6 @@ fetchMock.get('http://localhost/api/v1/dashboard/26', {
published: false,
roles: [],
slug: null,
- table_names:
- '[examples].[covid_vaccines], [examples].[covid_vaccines], [examples].[covid_vaccines], [examples].[covid_vaccines], [examples].[covid_vaccines], [examples].[covid_vaccines], [examples].[covid_vaccines], [examples].[covid_vaccines]',
thumbnail_url:
'/api/v1/dashboard/26/thumbnail/b24805e98d90116da8c0974d24f5c533/',
url: '/superset/dashboard/26/',
diff --git a/superset/dashboards/schemas.py b/superset/dashboards/schemas.py
index 7ca592e..00888b3 100644
--- a/superset/dashboards/schemas.py
+++ b/superset/dashboards/schemas.py
@@ -158,7 +158,6 @@ class DashboardGetResponseSchema(Schema):
charts = fields.List(fields.String(description=charts_description))
owners = fields.List(fields.Nested(UserSchema))
roles = fields.List(fields.Nested(RolesSchema))
- table_names = fields.String() # legacy nonsense
changed_on_humanized = fields.String(data_key="changed_on_delta_humanized")
diff --git a/tests/integration_tests/dashboards/api_tests.py b/tests/integration_tests/dashboards/api_tests.py
index cfb65d3..30eaffd 100644
--- a/tests/integration_tests/dashboards/api_tests.py
+++ b/tests/integration_tests/dashboards/api_tests.py
@@ -339,7 +339,6 @@ class TestDashboardApi(SupersetTestCase, ApiOwnersTestCaseMixin, InsertChartMixi
"published": False,
"url": "/superset/dashboard/slug1/",
"slug": "slug1",
- "table_names": "",
"thumbnail_url": dashboard.thumbnail_url,
}
data = json.loads(rv.data.decode("utf-8"))
[superset] 02/02: remove datasource from dashboard/:id/charts
Posted by su...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
suddjian pushed a commit to branch chore/improve-dash-api-speed
in repository https://gitbox.apache.org/repos/asf/superset.git
commit f3a9acfc11502faa2ef68a3e439fb68d8c387531
Author: David Aaron Suddjian <aa...@gmail.com>
AuthorDate: Fri Aug 6 15:44:24 2021 -0700
remove datasource from dashboard/:id/charts
---
superset/charts/schemas.py | 1 -
1 file changed, 1 deletion(-)
diff --git a/superset/charts/schemas.py b/superset/charts/schemas.py
index bef857d..726cf25 100644
--- a/superset/charts/schemas.py
+++ b/superset/charts/schemas.py
@@ -145,7 +145,6 @@ class ChartEntityResponseSchema(Schema):
cache_timeout = fields.Integer(description=cache_timeout_description)
changed_on = fields.String(description=changed_on_description)
modified = fields.String()
- datasource = fields.String(description=datasource_name_description)
description = fields.String(description=description_description)
description_markeddown = fields.String(
description=description_markeddown_description