[GitHub] seanyinx commented on a change in pull request #508: [SCB-150] Add Status(success/failed) dimension to operation call count and tps

[GitBox <gi...@apache.org>]

seanyinx commented on a change in pull request #508: [SCB-150] Add Status(success/failed) dimension to operation call count and tps
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/508#discussion_r161936069
 
 

 ##########
 File path: metrics/metrics-common/src/main/java/org/apache/servicecomb/metrics/common/MetricsDimension.java
 ##########
 @@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.metrics.common;
+
+import org.apache.servicecomb.foundation.common.exceptions.ServiceCombException;
+
+public class MetricsDimension {
+  public static final String DIMENSION_STATUS = "Status";
+
+  public static final String DIMENSION_STATUS_ALL = "all";
+
+  public static final String DIMENSION_STATUS_SUCCESS = "success";
+
+  public static final String DIMENSION_STATUS_FAILED = "failed";
+
+  public static String[] getDimensionOptions(String dimension) {
+    if (DIMENSION_STATUS.equals(dimension)) {
+      return new String[] {MetricsDimension.DIMENSION_STATUS_ALL,
+          MetricsDimension.DIMENSION_STATUS_SUCCESS,
+          MetricsDimension.DIMENSION_STATUS_FAILED};
+    }
+    throw new ServiceCombException("illegal dimension key : " + dimension);
 
 Review comment:
   if there's only one dimension, there's no need to pass in the parameter. if there are multiple, returning an empty array is preferable

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services