You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "David Medinets (JIRA)" <ji...@apache.org> on 2012/11/08 06:14:12 UTC
[jira] [Created] (ACCUMULO-845) Handle method.include calls
consistently in TraceWrap class.
David Medinets created ACCUMULO-845:
---------------------------------------
Summary: Handle method.include calls consistently in TraceWrap class.
Key: ACCUMULO-845
URL: https://issues.apache.org/jira/browse/ACCUMULO-845
Project: Accumulo
Issue Type: Bug
Reporter: David Medinets
Priority: Minor
One call ignores exceptions and one call handles exceptions.
{{noformat}}
if (args == null || args.length < 1 || args[0] == null || !(args[0] instanceof TInfo)) {
return method.invoke(instance, args);
}
Span span = Trace.trace((TInfo) args[0], method.getName());
try {
return method.invoke(instance, args);
} catch (InvocationTargetException ex) {
throw ex.getCause();
} finally {
span.stop();
}
{{noformat}}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ACCUMULO-845) Handle method.include calls
consistently in TraceWrap class.
Posted by "Mike Drob (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ACCUMULO-845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Drob updated ACCUMULO-845:
-------------------------------
Description:
One call ignores exceptions and one call handles exceptions.
{code}
if (args == null || args.length < 1 || args[0] == null || !(args[0] instanceof TInfo)) {
return method.invoke(instance, args);
}
Span span = Trace.trace((TInfo) args[0], method.getName());
try {
return method.invoke(instance, args);
} catch (InvocationTargetException ex) {
throw ex.getCause();
} finally {
span.stop();
}
{code}
was:
One call ignores exceptions and one call handles exceptions.
{{noformat}}
if (args == null || args.length < 1 || args[0] == null || !(args[0] instanceof TInfo)) {
return method.invoke(instance, args);
}
Span span = Trace.trace((TInfo) args[0], method.getName());
try {
return method.invoke(instance, args);
} catch (InvocationTargetException ex) {
throw ex.getCause();
} finally {
span.stop();
}
{{noformat}}
> Handle method.include calls consistently in TraceWrap class.
> ------------------------------------------------------------
>
> Key: ACCUMULO-845
> URL: https://issues.apache.org/jira/browse/ACCUMULO-845
> Project: Accumulo
> Issue Type: Bug
> Reporter: David Medinets
> Priority: Minor
>
> One call ignores exceptions and one call handles exceptions.
> {code}
> if (args == null || args.length < 1 || args[0] == null || !(args[0] instanceof TInfo)) {
> return method.invoke(instance, args);
> }
> Span span = Trace.trace((TInfo) args[0], method.getName());
> try {
> return method.invoke(instance, args);
> } catch (InvocationTargetException ex) {
> throw ex.getCause();
> } finally {
> span.stop();
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ACCUMULO-845) Handle method.include calls
consistently in TraceWrap class.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ACCUMULO-845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13498849#comment-13498849 ]
Hudson commented on ACCUMULO-845:
---------------------------------
Integrated in Accumulo-Trunk #555 (See [https://builds.apache.org/job/Accumulo-Trunk/555/])
ACCUMULO-845 make error handling consistent in the Proxy (Revision 1410378)
Result = SUCCESS
ecn :
Files :
* /accumulo/trunk/trace/src/main/java/org/apache/accumulo/cloudtrace/instrument/thrift/TraceWrap.java
> Handle method.include calls consistently in TraceWrap class.
> ------------------------------------------------------------
>
> Key: ACCUMULO-845
> URL: https://issues.apache.org/jira/browse/ACCUMULO-845
> Project: Accumulo
> Issue Type: Bug
> Reporter: David Medinets
> Assignee: Eric Newton
> Priority: Minor
> Fix For: 1.5.0
>
>
> One call ignores exceptions and one call handles exceptions.
> {noformat}
> if (args == null || args.length < 1 || args[0] == null || !(args[0] instanceof TInfo)) {
> return method.invoke(instance, args);
> }
> Span span = Trace.trace((TInfo) args[0], method.getName());
> try {
> return method.invoke(instance, args);
> } catch (InvocationTargetException ex) {
> throw ex.getCause();
> } finally {
> span.stop();
> }
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ACCUMULO-845) Handle method.include calls
consistently in TraceWrap class.
Posted by "Eric Newton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ACCUMULO-845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13498839#comment-13498839 ]
Eric Newton commented on ACCUMULO-845:
--------------------------------------
I'm going to fix this in trunk. Do you think this should be back-ported to 1.4?
> Handle method.include calls consistently in TraceWrap class.
> ------------------------------------------------------------
>
> Key: ACCUMULO-845
> URL: https://issues.apache.org/jira/browse/ACCUMULO-845
> Project: Accumulo
> Issue Type: Bug
> Reporter: David Medinets
> Priority: Minor
>
> One call ignores exceptions and one call handles exceptions.
> {noformat}
> if (args == null || args.length < 1 || args[0] == null || !(args[0] instanceof TInfo)) {
> return method.invoke(instance, args);
> }
> Span span = Trace.trace((TInfo) args[0], method.getName());
> try {
> return method.invoke(instance, args);
> } catch (InvocationTargetException ex) {
> throw ex.getCause();
> } finally {
> span.stop();
> }
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ACCUMULO-845) Handle method.include calls
consistently in TraceWrap class.
Posted by "David Medinets (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ACCUMULO-845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Medinets updated ACCUMULO-845:
------------------------------------
Description:
One call ignores exceptions and one call handles exceptions.
{noformat}
if (args == null || args.length < 1 || args[0] == null || !(args[0] instanceof TInfo)) {
return method.invoke(instance, args);
}
Span span = Trace.trace((TInfo) args[0], method.getName());
try {
return method.invoke(instance, args);
} catch (InvocationTargetException ex) {
throw ex.getCause();
} finally {
span.stop();
}
{noformat}
was:
One call ignores exceptions and one call handles exceptions.
{code}
if (args == null || args.length < 1 || args[0] == null || !(args[0] instanceof TInfo)) {
return method.invoke(instance, args);
}
Span span = Trace.trace((TInfo) args[0], method.getName());
try {
return method.invoke(instance, args);
} catch (InvocationTargetException ex) {
throw ex.getCause();
} finally {
span.stop();
}
{code}
> Handle method.include calls consistently in TraceWrap class.
> ------------------------------------------------------------
>
> Key: ACCUMULO-845
> URL: https://issues.apache.org/jira/browse/ACCUMULO-845
> Project: Accumulo
> Issue Type: Bug
> Reporter: David Medinets
> Priority: Minor
>
> One call ignores exceptions and one call handles exceptions.
> {noformat}
> if (args == null || args.length < 1 || args[0] == null || !(args[0] instanceof TInfo)) {
> return method.invoke(instance, args);
> }
> Span span = Trace.trace((TInfo) args[0], method.getName());
> try {
> return method.invoke(instance, args);
> } catch (InvocationTargetException ex) {
> throw ex.getCause();
> } finally {
> span.stop();
> }
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (ACCUMULO-845) Handle method.include calls
consistently in TraceWrap class.
Posted by "Eric Newton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ACCUMULO-845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric Newton resolved ACCUMULO-845.
----------------------------------
Resolution: Fixed
Fix Version/s: 1.5.0
Assignee: Eric Newton
> Handle method.include calls consistently in TraceWrap class.
> ------------------------------------------------------------
>
> Key: ACCUMULO-845
> URL: https://issues.apache.org/jira/browse/ACCUMULO-845
> Project: Accumulo
> Issue Type: Bug
> Reporter: David Medinets
> Assignee: Eric Newton
> Priority: Minor
> Fix For: 1.5.0
>
>
> One call ignores exceptions and one call handles exceptions.
> {noformat}
> if (args == null || args.length < 1 || args[0] == null || !(args[0] instanceof TInfo)) {
> return method.invoke(instance, args);
> }
> Span span = Trace.trace((TInfo) args[0], method.getName());
> try {
> return method.invoke(instance, args);
> } catch (InvocationTargetException ex) {
> throw ex.getCause();
> } finally {
> span.stop();
> }
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira