[GitHub] [mesos] cf-natali commented on a diff in pull request #423: Cleanup: git >= 2.32 does not support gitignore as symlink.

[GitBox <gi...@apache.org>]

cf-natali commented on code in PR #423:
URL: https://github.com/apache/mesos/pull/423#discussion_r843294024


##########
support/setup-dev.sh:
##########
@@ -27,7 +27,7 @@ __EOF__
 fi
 
 if test ! -e .gitignore; then

Review Comment:
   Maybe add a comment explaining why a copy is necessary, pointing to https://github.com/git/git/blob/master/Documentation/RelNotes/2.32.0.txt ?



##########
support/gitignore:
##########
@@ -39,3 +39,27 @@ CPPLINT.cfg
 .deps/
 .libs/
 *-stamp
+
+.clang-format
+.clang-tidy
+.gitlint
+.pre-commit-config.yaml
+.reviewboardrc
+*/**/Makefile.in
+CPPLINT.cfg
+Makefile.in
+aclocal.m4
+ar-lib
+autom4te.cache/
+build/
+centos7/
+compile
+config.guess
+config.sub
+configure
+*~

Review Comment:
   This `*~` will catch many files, are there many such files which can't be listed individually?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@mesos.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org