You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2022/11/23 17:14:43 UTC
[GitHub] [accumulo-proxy] DomGarguilo opened a new pull request, #54: Add python generated files to be excluded from rat check
DomGarguilo opened a new pull request, #54:
URL: https://github.com/apache/accumulo-proxy/pull/54
This directory, `src/main/python/AccumuloProxy.egg-info/`, is generated automatically when I run through the steps to set up the test client for python. It is already in the gitignore but it fails the rat check step of the build if I do not manually delete it. The changes in this PR make it so that the files within this directory are ignored by rat check which will not fail the build if it is present.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-proxy] DomGarguilo merged pull request #54: Add python generated files to be excluded from rat check
Posted by GitBox <gi...@apache.org>.
DomGarguilo merged PR #54:
URL: https://github.com/apache/accumulo-proxy/pull/54
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-proxy] ctubbsii commented on a diff in pull request #54: Add python generated files to be excluded from rat check
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on code in PR #54:
URL: https://github.com/apache/accumulo-proxy/pull/54#discussion_r1030951061
##########
pom.xml:
##########
@@ -416,6 +416,7 @@
<configuration>
<excludes>
<exclude>src/main/resources/META-INF/services/*</exclude>
+ <exclude>src/main/python/AccumuloProxy.egg-info/*</exclude>
Review Comment:
It's fine if these are ignored, but another option might be to add the license header automatically, like the main accumulo repo does.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-proxy] DomGarguilo commented on a diff in pull request #54: Add python generated files to be excluded from rat check
Posted by GitBox <gi...@apache.org>.
DomGarguilo commented on code in PR #54:
URL: https://github.com/apache/accumulo-proxy/pull/54#discussion_r1033736640
##########
pom.xml:
##########
@@ -416,6 +416,7 @@
<configuration>
<excludes>
<exclude>src/main/resources/META-INF/services/*</exclude>
+ <exclude>src/main/python/AccumuloProxy.egg-info/*</exclude>
Review Comment:
Good idea. Maybe ill merge this in as-is, then create a follow on ticket for that change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org