You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildr.apache.org by "Marko Sibakov (JIRA)" <ji...@apache.org> on 2008/10/06 22:21:44 UTC
[jira] Created: (BUILDR-164) add possibility to download source
code attachments for downloaded artifact jars
add possibility to download source code attachments for downloaded artifact jars
--------------------------------------------------------------------------------
Key: BUILDR-164
URL: https://issues.apache.org/jira/browse/BUILDR-164
Project: Buildr
Issue Type: Improvement
Components: Core features, Dependency management
Affects Versions: 1.3.3
Reporter: Marko Sibakov
Fix For: 1.3.4
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BUILDR-164) add possibility to download source
code attachments for downloaded artifact jars
Posted by "Marko Sibakov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12638866#action_12638866 ]
Marko Sibakov commented on BUILDR-164:
--------------------------------------
i'm quite busy right now but trying to send patch for this issue as soon as possible.
> add possibility to download source code attachments for downloaded artifact jars
> --------------------------------------------------------------------------------
>
> Key: BUILDR-164
> URL: https://issues.apache.org/jira/browse/BUILDR-164
> Project: Buildr
> Issue Type: Improvement
> Components: Core features, Dependency management
> Affects Versions: 1.3.3
> Reporter: Marko Sibakov
> Fix For: 1.3.4
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (BUILDR-164) add possibility to
download source code attachments for downloaded artifact jars
Posted by "lacton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12642283#action_12642283 ]
lacton edited comment on BUILDR-164 at 10/25/08 8:14 AM:
---------------------------------------------------------
'artifacts:sources' task added on trunk.
was (Author: lacton):
'sources' task added on trunk.
> add possibility to download source code attachments for downloaded artifact jars
> --------------------------------------------------------------------------------
>
> Key: BUILDR-164
> URL: https://issues.apache.org/jira/browse/BUILDR-164
> Project: Buildr
> Issue Type: Improvement
> Components: Core features, Dependency management
> Affects Versions: 1.3.3
> Reporter: Marko Sibakov
> Assignee: lacton
> Fix For: 1.3.4
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (BUILDR-164) add possibility to
download source code attachments for downloaded artifact jars
Posted by "lacton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12638873#action_12638873 ]
lacton edited comment on BUILDR-164 at 10/12/08 10:41 AM:
----------------------------------------------------------
I understand the motivation for BUILDR-165 and having the right source path in the IDE files. In fact, it's something I was sure we would have to do someday.
Yet, modifying artifact.rb seems a little bit too much to me. If I understand correctly, it would double the number of artifact downloads for everybody, even for users that don't use the IDE tasks. Is that right?
Would downloading the source artifacts only when invoking the IDE task be enough for you?
was (Author: lacton):
I understand the motivation for BUILDR-165 and having the right source path in the IDE files. In fact, it's something I was sure we would have to do someday.
Yet, modifying artifact.rb seems a little bit too much to me. If I understand correctly, it would double the number of artifact downloads for everybody, even for users that don't use the IDE tasks. Is that right?
> add possibility to download source code attachments for downloaded artifact jars
> --------------------------------------------------------------------------------
>
> Key: BUILDR-164
> URL: https://issues.apache.org/jira/browse/BUILDR-164
> Project: Buildr
> Issue Type: Improvement
> Components: Core features, Dependency management
> Affects Versions: 1.3.3
> Reporter: Marko Sibakov
> Fix For: 1.3.4
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (BUILDR-164) add possibility to download source
code attachments for downloaded artifact jars
Posted by "lacton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
lacton updated BUILDR-164:
--------------------------
Fix Version/s: 1.3.4
> add possibility to download source code attachments for downloaded artifact jars
> --------------------------------------------------------------------------------
>
> Key: BUILDR-164
> URL: https://issues.apache.org/jira/browse/BUILDR-164
> Project: Buildr
> Issue Type: Improvement
> Components: Core features, Dependency management
> Affects Versions: 1.3.3
> Reporter: Marko Sibakov
> Assignee: lacton
> Fix For: 1.3.4
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BUILDR-164) add possibility to download source
code attachments for downloaded artifact jars
Posted by "Assaf Arkin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12639106#action_12639106 ]
Assaf Arkin commented on BUILDR-164:
------------------------------------
We're mixing two things here. How: downloading source files is not something the artifact method is supposed to do -- separation of concerns. When: you must run some task to make it happen, the question is then, which task. There's a wider audience for discussing this on the mailing list.
> add possibility to download source code attachments for downloaded artifact jars
> --------------------------------------------------------------------------------
>
> Key: BUILDR-164
> URL: https://issues.apache.org/jira/browse/BUILDR-164
> Project: Buildr
> Issue Type: Improvement
> Components: Core features, Dependency management
> Affects Versions: 1.3.3
> Reporter: Marko Sibakov
> Fix For: 1.3.4
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (BUILDR-164) add possibility to download source
code attachments for downloaded artifact jars
Posted by "Assaf Arkin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Assaf Arkin updated BUILDR-164:
-------------------------------
Fix Version/s: (was: 1.3.4)
> add possibility to download source code attachments for downloaded artifact jars
> --------------------------------------------------------------------------------
>
> Key: BUILDR-164
> URL: https://issues.apache.org/jira/browse/BUILDR-164
> Project: Buildr
> Issue Type: Improvement
> Components: Core features, Dependency management
> Affects Versions: 1.3.3
> Reporter: Marko Sibakov
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BUILDR-164) add possibility to download source
code attachments for downloaded artifact jars
Posted by "Assaf Arkin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12639161#action_12639161 ]
Assaf Arkin commented on BUILDR-164:
------------------------------------
then why don't we start by having the eclipse task download the source packages it intends to use -- if you can list them in the project than you're also able to download them. then let's extract and make it reusable for idea as well.
> add possibility to download source code attachments for downloaded artifact jars
> --------------------------------------------------------------------------------
>
> Key: BUILDR-164
> URL: https://issues.apache.org/jira/browse/BUILDR-164
> Project: Buildr
> Issue Type: Improvement
> Components: Core features, Dependency management
> Affects Versions: 1.3.3
> Reporter: Marko Sibakov
> Fix For: 1.3.4
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BUILDR-164) add possibility to download source
code attachments for downloaded artifact jars
Posted by "Timo Rantalaiho (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12638887#action_12638887 ]
Timo Rantalaiho commented on BUILDR-164:
----------------------------------------
I totally agree with Marko on this one. 999 builds out of a thousand are done by developers, whose work is a lot more productive when you have the sources of the libraries available.
> add possibility to download source code attachments for downloaded artifact jars
> --------------------------------------------------------------------------------
>
> Key: BUILDR-164
> URL: https://issues.apache.org/jira/browse/BUILDR-164
> Project: Buildr
> Issue Type: Improvement
> Components: Core features, Dependency management
> Affects Versions: 1.3.3
> Reporter: Marko Sibakov
> Fix For: 1.3.4
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (BUILDR-164) add possibility to download source
code attachments for downloaded artifact jars
Posted by "lacton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
lacton reassigned BUILDR-164:
-----------------------------
Assignee: lacton
> add possibility to download source code attachments for downloaded artifact jars
> --------------------------------------------------------------------------------
>
> Key: BUILDR-164
> URL: https://issues.apache.org/jira/browse/BUILDR-164
> Project: Buildr
> Issue Type: Improvement
> Components: Core features, Dependency management
> Affects Versions: 1.3.3
> Reporter: Marko Sibakov
> Assignee: lacton
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (BUILDR-164) add possibility to
download source code attachments for downloaded artifact jars
Posted by "Marko Sibakov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12639163#action_12639163 ]
msibakov edited comment on BUILDR-164 at 10/13/08 11:52 AM:
-----------------------------------------------------------------
I agree with Alex with IDE tasks.
Downloading goes ok with both ways, adding either new task or modifying artifact to download source.jars. If you are worried about performance issues it's ok for me to do extra task to handle it.
was (Author: msibakov):
I agree with Alex with IDE tasks.
Downloading goes ok with both ways, adding either new task or modifying artifact to download source.jars. If you are worried about performance issues it's ok for me to do extra task to handle it.
> add possibility to download source code attachments for downloaded artifact jars
> --------------------------------------------------------------------------------
>
> Key: BUILDR-164
> URL: https://issues.apache.org/jira/browse/BUILDR-164
> Project: Buildr
> Issue Type: Improvement
> Components: Core features, Dependency management
> Affects Versions: 1.3.3
> Reporter: Marko Sibakov
> Fix For: 1.3.4
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BUILDR-164) add possibility to download source
code attachments for downloaded artifact jars
Posted by "lacton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12638873#action_12638873 ]
lacton commented on BUILDR-164:
-------------------------------
I understand the motivation for BUILDR-165 and having the right source path in the IDE files. In fact, it's something I was sure we would have to do someday.
Yet, modifying artifact.rb seems a little bit too much to me. If I understand correctly, it would double the number of artifact downloads for everybody, even for users that don't use the IDE tasks. Is that right?
> add possibility to download source code attachments for downloaded artifact jars
> --------------------------------------------------------------------------------
>
> Key: BUILDR-164
> URL: https://issues.apache.org/jira/browse/BUILDR-164
> Project: Buildr
> Issue Type: Improvement
> Components: Core features, Dependency management
> Affects Versions: 1.3.3
> Reporter: Marko Sibakov
> Fix For: 1.3.4
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (BUILDR-164) add possibility to
download source code attachments for downloaded artifact jars
Posted by "lacton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12638856#action_12638856 ]
lacton edited comment on BUILDR-164 at 10/12/08 8:58 AM:
---------------------------------------------------------
Do you mean that when generating the IDE metadata files, buildr should always try to download the relevant sources and attach a reference to them?
What is the difference between this issue and BUILDR-165?
was (Author: lacton):
Do you mean that when generating the IDE metadata files, buildr should always try to download the relevant sources and attach a reference to them?
> add possibility to download source code attachments for downloaded artifact jars
> --------------------------------------------------------------------------------
>
> Key: BUILDR-164
> URL: https://issues.apache.org/jira/browse/BUILDR-164
> Project: Buildr
> Issue Type: Improvement
> Components: Core features, Dependency management
> Affects Versions: 1.3.3
> Reporter: Marko Sibakov
> Fix For: 1.3.4
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (BUILDR-164) add possibility to download source
code attachments for downloaded artifact jars
Posted by "lacton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
lacton resolved BUILDR-164.
---------------------------
Resolution: Fixed
'sources' task added on trunk.
> add possibility to download source code attachments for downloaded artifact jars
> --------------------------------------------------------------------------------
>
> Key: BUILDR-164
> URL: https://issues.apache.org/jira/browse/BUILDR-164
> Project: Buildr
> Issue Type: Improvement
> Components: Core features, Dependency management
> Affects Versions: 1.3.3
> Reporter: Marko Sibakov
> Assignee: lacton
> Fix For: 1.3.4
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Work started: (BUILDR-164) add possibility to download
source code attachments for downloaded artifact jars
Posted by "lacton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on BUILDR-164 started by lacton.
> add possibility to download source code attachments for downloaded artifact jars
> --------------------------------------------------------------------------------
>
> Key: BUILDR-164
> URL: https://issues.apache.org/jira/browse/BUILDR-164
> Project: Buildr
> Issue Type: Improvement
> Components: Core features, Dependency management
> Affects Versions: 1.3.3
> Reporter: Marko Sibakov
> Assignee: lacton
> Fix For: 1.3.4
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BUILDR-164) add possibility to download source
code attachments for downloaded artifact jars
Posted by "lacton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12638856#action_12638856 ]
lacton commented on BUILDR-164:
-------------------------------
Do you mean that when generating the IDE metadata files, buildr should always try to download the relevant sources and attach a reference to them?
> add possibility to download source code attachments for downloaded artifact jars
> --------------------------------------------------------------------------------
>
> Key: BUILDR-164
> URL: https://issues.apache.org/jira/browse/BUILDR-164
> Project: Buildr
> Issue Type: Improvement
> Components: Core features, Dependency management
> Affects Versions: 1.3.3
> Reporter: Marko Sibakov
> Fix For: 1.3.4
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BUILDR-164) add possibility to download source
code attachments for downloaded artifact jars
Posted by "Marko Sibakov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12638863#action_12638863 ]
Marko Sibakov commented on BUILDR-164:
--------------------------------------
This issue contains downloading mechanism for source code attachment jars.
This can be easily done by adding something like this to artifact.rb
+ remote.find do |repo_url|
+ begin
+ sources = name.sub(/\.jar$/, "-sources.jar")
+ path = "#{group_path}/#{id}/#{version}/#{File.basename(sources)}"
+ mkpath File.dirname(name), :verbose=>false
+ URI.download repo_url + path, sources
+ true
+ rescue
+ false
+ end
+ end
BUILDR-165 is for adding source code attachment reference to Eclipse .classpath and IDEA .iml like this:
Eclipse .classpath
<classpathentry kind="var" path="M2_REPO/org/apache/wicket/wicket/1.3.4/wicket-1.3.4.jar" sourcepath="M2_REPO/org/apache/wicket/wicket/1.3.4/wicket-1.3.4-sources.jar"/>
IDEA .iml
<library>
<CLASSES>
<root url="jar://$M2_REPO$/org/apache/wicket/wicket/1.3.4/wicket-1.3.4.jar!/" />
</CLASSES>
<JAVADOC />
<SOURCES>
<root url="jar://$M2_REPO$/org/apache/wicket/wicket/1.3.4/wicket-1.3.4-sources.jar!/" />
</SOURCES>
</library>
> add possibility to download source code attachments for downloaded artifact jars
> --------------------------------------------------------------------------------
>
> Key: BUILDR-164
> URL: https://issues.apache.org/jira/browse/BUILDR-164
> Project: Buildr
> Issue Type: Improvement
> Components: Core features, Dependency management
> Affects Versions: 1.3.3
> Reporter: Marko Sibakov
> Fix For: 1.3.4
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BUILDR-164) add possibility to download source
code attachments for downloaded artifact jars
Posted by "Alex Boisvert (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12639152#action_12639152 ]
Alex Boisvert commented on BUILDR-164:
--------------------------------------
Can we agree that the IDE tasks (Eclipse, Idea, ...) should automatically use source artifacts if they are available locally?
If so, then we could create a new task "download-sources" that would recursively download source artifacts based on compile and test tasks.
> add possibility to download source code attachments for downloaded artifact jars
> --------------------------------------------------------------------------------
>
> Key: BUILDR-164
> URL: https://issues.apache.org/jira/browse/BUILDR-164
> Project: Buildr
> Issue Type: Improvement
> Components: Core features, Dependency management
> Affects Versions: 1.3.3
> Reporter: Marko Sibakov
> Fix For: 1.3.4
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BUILDR-164) add possibility to download source
code attachments for downloaded artifact jars
Posted by "Marko Sibakov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12638877#action_12638877 ]
Marko Sibakov commented on BUILDR-164:
--------------------------------------
Yes, it doubles downloaded artifacts. I think that everyone who use Java would appreciate build tool that download sources automatically :-)
Downloading source jars by invoking IDE task is not good idea because i know that someone likes to maintain IDE metadata files (.classpath & .iml) manually.
If doubling downloaded artifacts sounds bad, we can also write new task, something like buildr sources.
My opinion is that downloading source artifacts and adding reference to IDE files should be separate operations but invoking IDE tasks (idea and eclipse) should anyway add source code attachment automatically.
> add possibility to download source code attachments for downloaded artifact jars
> --------------------------------------------------------------------------------
>
> Key: BUILDR-164
> URL: https://issues.apache.org/jira/browse/BUILDR-164
> Project: Buildr
> Issue Type: Improvement
> Components: Core features, Dependency management
> Affects Versions: 1.3.3
> Reporter: Marko Sibakov
> Fix For: 1.3.4
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BUILDR-164) add possibility to download source
code attachments for downloaded artifact jars
Posted by "Marko Sibakov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12639163#action_12639163 ]
Marko Sibakov commented on BUILDR-164:
--------------------------------------
I agree with Alex with IDE tasks.
Downloading goes ok with both ways, adding either new task or modifying artifact to download source.jars. If you are worried about performance issues it's ok for me to do extra task to handle it.
> add possibility to download source code attachments for downloaded artifact jars
> --------------------------------------------------------------------------------
>
> Key: BUILDR-164
> URL: https://issues.apache.org/jira/browse/BUILDR-164
> Project: Buildr
> Issue Type: Improvement
> Components: Core features, Dependency management
> Affects Versions: 1.3.3
> Reporter: Marko Sibakov
> Fix For: 1.3.4
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.