You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Evgeny Mandrikov (JIRA)" <ji...@codehaus.org> on 2010/02/10 15:07:55 UTC

[jira] Created: (SCM-532) Please add support for blame command

Please add support for blame command
------------------------------------

                 Key: SCM-532
                 URL: http://jira.codehaus.org/browse/SCM-532
             Project: Maven SCM
          Issue Type: New Feature
          Components: maven-scm-api, maven-scm-provider-bazaar, maven-scm-provider-cvs, maven-scm-provider-git, maven-scm-provider-mercurial (hg), maven-scm-provider-svn
            Reporter: Evgeny Mandrikov


I've made an extension for Maven SCM for blame command. This extension currently part of [Sonar SCM Activity Plugin|http://docs.codehaus.org/display/SONAR/SCM+Activity+Plugin] and supports Subversion (pure Java too), Git, CVS, Mercurial and Bazaar. For all of these providers I made unit-tests. It would be nice to include these command into Maven SCM. Source code can be found here: http://svn.codehaus.org/sonar-plugins/trunk/scm-activity/maven-scm-ext/

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (SCM-532) Please add support for blame command

Posted by "Mark Struberg (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/SCM-532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=255884#action_255884 ] 

Mark Struberg commented on SCM-532:
-----------------------------------

That sounds like we need both fields in the BlameLine. Will create a new Jiraffe for this feature.

> Please add support for blame command
> ------------------------------------
>
>                 Key: SCM-532
>                 URL: http://jira.codehaus.org/browse/SCM-532
>             Project: Maven SCM
>          Issue Type: New Feature
>          Components: maven-scm-api, maven-scm-provider-bazaar, maven-scm-provider-cvs, maven-scm-provider-git, maven-scm-provider-mercurial (hg), maven-scm-provider-svn
>            Reporter: Evgeny Mandrikov
>            Assignee: Olivier Lamy
>             Fix For: 1.4
>
>         Attachments: SCM-532.diff
>
>
> I've made an extension for Maven SCM for blame command. This extension currently part of [Sonar SCM Activity Plugin|http://docs.codehaus.org/display/SONAR/SCM+Activity+Plugin] and supports Subversion (pure Java too), Git, CVS, Mercurial and Bazaar. For all of these providers I made unit-tests. It would be nice to include these command into Maven SCM. Source code can be found here: http://svn.codehaus.org/sonar-plugins/trunk/scm-activity/maven-scm-ext/

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Reopened: (SCM-532) Please add support for blame command

Posted by "Olivier Lamy (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/SCM-532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Olivier Lamy reopened SCM-532:
------------------------------


Reopen as a tck-git failed 
{code}
mvn clean verify -Ptck-git -Dtest=GitExeBlameCommandTckTest -DfailIfNoTests=false -Dsurefire.useFile=false

junit.framework.ComparisonFailure: expected:<[92f139df]> but was:<[^92f139d]>
        at junit.framework.Assert.assertEquals(Assert.java:81)
        at junit.framework.Assert.assertEquals(Assert.java:87)
        at org.apache.maven.scm.provider.git.gitexe.command.blame.GitExeBlameCommandTckTest.verifyResult(GitExeBlameCommandTckTest.java:53)
        at org.apache.maven.scm.tck.command.blame.BlameCommandTckTest.testBlameCommand(BlameCommandTckTest.java:99)
        at org.apache.maven.scm.provider.git.gitexe.command.blame.GitExeBlameCommandTckTest.testBlameCommand(GitExeBlameCommandTckTest.java:44)
{code}

> Please add support for blame command
> ------------------------------------
>
>                 Key: SCM-532
>                 URL: http://jira.codehaus.org/browse/SCM-532
>             Project: Maven SCM
>          Issue Type: New Feature
>          Components: maven-scm-api, maven-scm-provider-bazaar, maven-scm-provider-cvs, maven-scm-provider-git, maven-scm-provider-mercurial (hg), maven-scm-provider-svn
>            Reporter: Evgeny Mandrikov
>            Assignee: Olivier Lamy
>             Fix For: 1.4
>
>         Attachments: SCM-532.diff
>
>
> I've made an extension for Maven SCM for blame command. This extension currently part of [Sonar SCM Activity Plugin|http://docs.codehaus.org/display/SONAR/SCM+Activity+Plugin] and supports Subversion (pure Java too), Git, CVS, Mercurial and Bazaar. For all of these providers I made unit-tests. It would be nice to include these command into Maven SCM. Source code can be found here: http://svn.codehaus.org/sonar-plugins/trunk/scm-activity/maven-scm-ext/

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (SCM-532) Please add support for blame command

Posted by "Evgeny Mandrikov (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/SCM-532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=209686#action_209686 ] 

Evgeny Mandrikov commented on SCM-532:
--------------------------------------

General question - where I should send it?

> Please add support for blame command
> ------------------------------------
>
>                 Key: SCM-532
>                 URL: http://jira.codehaus.org/browse/SCM-532
>             Project: Maven SCM
>          Issue Type: New Feature
>          Components: maven-scm-api, maven-scm-provider-bazaar, maven-scm-provider-cvs, maven-scm-provider-git, maven-scm-provider-mercurial (hg), maven-scm-provider-svn
>            Reporter: Evgeny Mandrikov
>            Assignee: Olivier Lamy
>             Fix For: 1.4
>
>
> I've made an extension for Maven SCM for blame command. This extension currently part of [Sonar SCM Activity Plugin|http://docs.codehaus.org/display/SONAR/SCM+Activity+Plugin] and supports Subversion (pure Java too), Git, CVS, Mercurial and Bazaar. For all of these providers I made unit-tests. It would be nice to include these command into Maven SCM. Source code can be found here: http://svn.codehaus.org/sonar-plugins/trunk/scm-activity/maven-scm-ext/

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (SCM-532) Please add support for blame command

Posted by "Mark Struberg (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/SCM-532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=255853#action_255853 ] 

Mark Struberg commented on SCM-532:
-----------------------------------

Evgeny, we had a discussion over in SCM-606 of scm:blame should report the 'author' or the 'committer'?
I now assume that the committer information is of better quality (at least for sonar), isn't? Need a quick confirm here ;) txs!

> Please add support for blame command
> ------------------------------------
>
>                 Key: SCM-532
>                 URL: http://jira.codehaus.org/browse/SCM-532
>             Project: Maven SCM
>          Issue Type: New Feature
>          Components: maven-scm-api, maven-scm-provider-bazaar, maven-scm-provider-cvs, maven-scm-provider-git, maven-scm-provider-mercurial (hg), maven-scm-provider-svn
>            Reporter: Evgeny Mandrikov
>            Assignee: Olivier Lamy
>             Fix For: 1.4
>
>         Attachments: SCM-532.diff
>
>
> I've made an extension for Maven SCM for blame command. This extension currently part of [Sonar SCM Activity Plugin|http://docs.codehaus.org/display/SONAR/SCM+Activity+Plugin] and supports Subversion (pure Java too), Git, CVS, Mercurial and Bazaar. For all of these providers I made unit-tests. It would be nice to include these command into Maven SCM. Source code can be found here: http://svn.codehaus.org/sonar-plugins/trunk/scm-activity/maven-scm-ext/

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (SCM-532) Please add support for blame command

Posted by "Olivier Lamy (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/SCM-532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=209685#action_209685 ] 

Olivier Lamy commented on SCM-532:
----------------------------------

As it can be a huge patch.
Could please send a CLA to ASF ? ( see [http://www.apache.org/licenses/icla.txt] )
I don't have issue for the one I have submitted through my patch in Sonar but for the others.

To others as the code is already ASF license granted do we really need a cla ?


> Please add support for blame command
> ------------------------------------
>
>                 Key: SCM-532
>                 URL: http://jira.codehaus.org/browse/SCM-532
>             Project: Maven SCM
>          Issue Type: New Feature
>          Components: maven-scm-api, maven-scm-provider-bazaar, maven-scm-provider-cvs, maven-scm-provider-git, maven-scm-provider-mercurial (hg), maven-scm-provider-svn
>            Reporter: Evgeny Mandrikov
>            Assignee: Olivier Lamy
>             Fix For: 1.4
>
>
> I've made an extension for Maven SCM for blame command. This extension currently part of [Sonar SCM Activity Plugin|http://docs.codehaus.org/display/SONAR/SCM+Activity+Plugin] and supports Subversion (pure Java too), Git, CVS, Mercurial and Bazaar. For all of these providers I made unit-tests. It would be nice to include these command into Maven SCM. Source code can be found here: http://svn.codehaus.org/sonar-plugins/trunk/scm-activity/maven-scm-ext/

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (SCM-532) Please add support for blame command

Posted by "Evgeny Mandrikov (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/SCM-532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Evgeny Mandrikov updated SCM-532:
---------------------------------

    Attachment: SCM-532.diff

Patch attached.

> Please add support for blame command
> ------------------------------------
>
>                 Key: SCM-532
>                 URL: http://jira.codehaus.org/browse/SCM-532
>             Project: Maven SCM
>          Issue Type: New Feature
>          Components: maven-scm-api, maven-scm-provider-bazaar, maven-scm-provider-cvs, maven-scm-provider-git, maven-scm-provider-mercurial (hg), maven-scm-provider-svn
>            Reporter: Evgeny Mandrikov
>            Assignee: Olivier Lamy
>             Fix For: 1.4
>
>         Attachments: SCM-532.diff
>
>
> I've made an extension for Maven SCM for blame command. This extension currently part of [Sonar SCM Activity Plugin|http://docs.codehaus.org/display/SONAR/SCM+Activity+Plugin] and supports Subversion (pure Java too), Git, CVS, Mercurial and Bazaar. For all of these providers I made unit-tests. It would be nice to include these command into Maven SCM. Source code can be found here: http://svn.codehaus.org/sonar-plugins/trunk/scm-activity/maven-scm-ext/

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (SCM-532) Please add support for blame command

Posted by "Evgeny Mandrikov (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/SCM-532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=210895#action_210895 ] 

Evgeny Mandrikov commented on SCM-532:
--------------------------------------

Ok, I'll try to prepare patch.

> Please add support for blame command
> ------------------------------------
>
>                 Key: SCM-532
>                 URL: http://jira.codehaus.org/browse/SCM-532
>             Project: Maven SCM
>          Issue Type: New Feature
>          Components: maven-scm-api, maven-scm-provider-bazaar, maven-scm-provider-cvs, maven-scm-provider-git, maven-scm-provider-mercurial (hg), maven-scm-provider-svn
>            Reporter: Evgeny Mandrikov
>            Assignee: Olivier Lamy
>             Fix For: 1.4
>
>
> I've made an extension for Maven SCM for blame command. This extension currently part of [Sonar SCM Activity Plugin|http://docs.codehaus.org/display/SONAR/SCM+Activity+Plugin] and supports Subversion (pure Java too), Git, CVS, Mercurial and Bazaar. For all of these providers I made unit-tests. It would be nice to include these command into Maven SCM. Source code can be found here: http://svn.codehaus.org/sonar-plugins/trunk/scm-activity/maven-scm-ext/

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (SCM-532) Please add support for blame command

Posted by "Olivier Lamy (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/SCM-532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Olivier Lamy closed SCM-532.
----------------------------

    Resolution: Fixed

so upgrading to git version 1.6.2.1 fix the issue.

> Please add support for blame command
> ------------------------------------
>
>                 Key: SCM-532
>                 URL: http://jira.codehaus.org/browse/SCM-532
>             Project: Maven SCM
>          Issue Type: New Feature
>          Components: maven-scm-api, maven-scm-provider-bazaar, maven-scm-provider-cvs, maven-scm-provider-git, maven-scm-provider-mercurial (hg), maven-scm-provider-svn
>            Reporter: Evgeny Mandrikov
>            Assignee: Olivier Lamy
>             Fix For: 1.4
>
>         Attachments: SCM-532.diff
>
>
> I've made an extension for Maven SCM for blame command. This extension currently part of [Sonar SCM Activity Plugin|http://docs.codehaus.org/display/SONAR/SCM+Activity+Plugin] and supports Subversion (pure Java too), Git, CVS, Mercurial and Bazaar. For all of these providers I made unit-tests. It would be nice to include these command into Maven SCM. Source code can be found here: http://svn.codehaus.org/sonar-plugins/trunk/scm-activity/maven-scm-ext/

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (SCM-532) Please add support for blame command

Posted by "Olivier Lamy (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/SCM-532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=210904#action_210904 ] 

Olivier Lamy commented on SCM-532:
----------------------------------

provide your patch

> Please add support for blame command
> ------------------------------------
>
>                 Key: SCM-532
>                 URL: http://jira.codehaus.org/browse/SCM-532
>             Project: Maven SCM
>          Issue Type: New Feature
>          Components: maven-scm-api, maven-scm-provider-bazaar, maven-scm-provider-cvs, maven-scm-provider-git, maven-scm-provider-mercurial (hg), maven-scm-provider-svn
>            Reporter: Evgeny Mandrikov
>            Assignee: Olivier Lamy
>             Fix For: 1.4
>
>
> I've made an extension for Maven SCM for blame command. This extension currently part of [Sonar SCM Activity Plugin|http://docs.codehaus.org/display/SONAR/SCM+Activity+Plugin] and supports Subversion (pure Java too), Git, CVS, Mercurial and Bazaar. For all of these providers I made unit-tests. It would be nice to include these command into Maven SCM. Source code can be found here: http://svn.codehaus.org/sonar-plugins/trunk/scm-activity/maven-scm-ext/

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (SCM-532) Please add support for blame command

Posted by "Olivier Lamy (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/SCM-532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=210894#action_210894 ] 

Olivier Lamy commented on SCM-532:
----------------------------------

ATM not enough spare time (ski holidays coming :-) ).
BTW if you provide a patch it will be faster :P.

> Please add support for blame command
> ------------------------------------
>
>                 Key: SCM-532
>                 URL: http://jira.codehaus.org/browse/SCM-532
>             Project: Maven SCM
>          Issue Type: New Feature
>          Components: maven-scm-api, maven-scm-provider-bazaar, maven-scm-provider-cvs, maven-scm-provider-git, maven-scm-provider-mercurial (hg), maven-scm-provider-svn
>            Reporter: Evgeny Mandrikov
>            Assignee: Olivier Lamy
>             Fix For: 1.4
>
>
> I've made an extension for Maven SCM for blame command. This extension currently part of [Sonar SCM Activity Plugin|http://docs.codehaus.org/display/SONAR/SCM+Activity+Plugin] and supports Subversion (pure Java too), Git, CVS, Mercurial and Bazaar. For all of these providers I made unit-tests. It would be nice to include these command into Maven SCM. Source code can be found here: http://svn.codehaus.org/sonar-plugins/trunk/scm-activity/maven-scm-ext/

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (SCM-532) Please add support for blame command

Posted by "Evgeny Mandrikov (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/SCM-532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=255865#action_255865 ] 

Evgeny Mandrikov commented on SCM-532:
--------------------------------------

Hi Mark,

Author is responsible for creation of patch, whereas committer responsible for acceptance of patch, so from my point of view they both responsible for quality of commit. Which means that for quality measures in Sonar it would be better to have access to both values.

> Please add support for blame command
> ------------------------------------
>
>                 Key: SCM-532
>                 URL: http://jira.codehaus.org/browse/SCM-532
>             Project: Maven SCM
>          Issue Type: New Feature
>          Components: maven-scm-api, maven-scm-provider-bazaar, maven-scm-provider-cvs, maven-scm-provider-git, maven-scm-provider-mercurial (hg), maven-scm-provider-svn
>            Reporter: Evgeny Mandrikov
>            Assignee: Olivier Lamy
>             Fix For: 1.4
>
>         Attachments: SCM-532.diff
>
>
> I've made an extension for Maven SCM for blame command. This extension currently part of [Sonar SCM Activity Plugin|http://docs.codehaus.org/display/SONAR/SCM+Activity+Plugin] and supports Subversion (pure Java too), Git, CVS, Mercurial and Bazaar. For all of these providers I made unit-tests. It would be nice to include these command into Maven SCM. Source code can be found here: http://svn.codehaus.org/sonar-plugins/trunk/scm-activity/maven-scm-ext/

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (SCM-532) Please add support for blame command

Posted by "Evgeny Mandrikov (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/SCM-532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=213574#action_213574 ] 

Evgeny Mandrikov commented on SCM-532:
--------------------------------------

And I can't reproduce this on my Linux box with git 1.6.4.4

> Please add support for blame command
> ------------------------------------
>
>                 Key: SCM-532
>                 URL: http://jira.codehaus.org/browse/SCM-532
>             Project: Maven SCM
>          Issue Type: New Feature
>          Components: maven-scm-api, maven-scm-provider-bazaar, maven-scm-provider-cvs, maven-scm-provider-git, maven-scm-provider-mercurial (hg), maven-scm-provider-svn
>            Reporter: Evgeny Mandrikov
>            Assignee: Olivier Lamy
>             Fix For: 1.4
>
>         Attachments: SCM-532.diff
>
>
> I've made an extension for Maven SCM for blame command. This extension currently part of [Sonar SCM Activity Plugin|http://docs.codehaus.org/display/SONAR/SCM+Activity+Plugin] and supports Subversion (pure Java too), Git, CVS, Mercurial and Bazaar. For all of these providers I made unit-tests. It would be nice to include these command into Maven SCM. Source code can be found here: http://svn.codehaus.org/sonar-plugins/trunk/scm-activity/maven-scm-ext/

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (SCM-532) Please add support for blame command

Posted by "Evgeny Mandrikov (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/SCM-532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=210903#action_210903 ] 

Evgeny Mandrikov commented on SCM-532:
--------------------------------------

Code in trunk now Java 1.4 compatible. Is it possible to create branch in maven-scm for me? If not, I'll attach huge patch here.

> Please add support for blame command
> ------------------------------------
>
>                 Key: SCM-532
>                 URL: http://jira.codehaus.org/browse/SCM-532
>             Project: Maven SCM
>          Issue Type: New Feature
>          Components: maven-scm-api, maven-scm-provider-bazaar, maven-scm-provider-cvs, maven-scm-provider-git, maven-scm-provider-mercurial (hg), maven-scm-provider-svn
>            Reporter: Evgeny Mandrikov
>            Assignee: Olivier Lamy
>             Fix For: 1.4
>
>
> I've made an extension for Maven SCM for blame command. This extension currently part of [Sonar SCM Activity Plugin|http://docs.codehaus.org/display/SONAR/SCM+Activity+Plugin] and supports Subversion (pure Java too), Git, CVS, Mercurial and Bazaar. For all of these providers I made unit-tests. It would be nice to include these command into Maven SCM. Source code can be found here: http://svn.codehaus.org/sonar-plugins/trunk/scm-activity/maven-scm-ext/

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (SCM-532) Please add support for blame command

Posted by "Evgeny Mandrikov (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/SCM-532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=210890#action_210890 ] 

Evgeny Mandrikov commented on SCM-532:
--------------------------------------

Is there progress? Maybe I can help somehow?

> Please add support for blame command
> ------------------------------------
>
>                 Key: SCM-532
>                 URL: http://jira.codehaus.org/browse/SCM-532
>             Project: Maven SCM
>          Issue Type: New Feature
>          Components: maven-scm-api, maven-scm-provider-bazaar, maven-scm-provider-cvs, maven-scm-provider-git, maven-scm-provider-mercurial (hg), maven-scm-provider-svn
>            Reporter: Evgeny Mandrikov
>            Assignee: Olivier Lamy
>             Fix For: 1.4
>
>
> I've made an extension for Maven SCM for blame command. This extension currently part of [Sonar SCM Activity Plugin|http://docs.codehaus.org/display/SONAR/SCM+Activity+Plugin] and supports Subversion (pure Java too), Git, CVS, Mercurial and Bazaar. For all of these providers I made unit-tests. It would be nice to include these command into Maven SCM. Source code can be found here: http://svn.codehaus.org/sonar-plugins/trunk/scm-activity/maven-scm-ext/

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (SCM-532) Please add support for blame command

Posted by "Evgeny Mandrikov (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/SCM-532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=209764#action_209764 ] 

Evgeny Mandrikov commented on SCM-532:
--------------------------------------

Sended.

> Please add support for blame command
> ------------------------------------
>
>                 Key: SCM-532
>                 URL: http://jira.codehaus.org/browse/SCM-532
>             Project: Maven SCM
>          Issue Type: New Feature
>          Components: maven-scm-api, maven-scm-provider-bazaar, maven-scm-provider-cvs, maven-scm-provider-git, maven-scm-provider-mercurial (hg), maven-scm-provider-svn
>            Reporter: Evgeny Mandrikov
>            Assignee: Olivier Lamy
>             Fix For: 1.4
>
>
> I've made an extension for Maven SCM for blame command. This extension currently part of [Sonar SCM Activity Plugin|http://docs.codehaus.org/display/SONAR/SCM+Activity+Plugin] and supports Subversion (pure Java too), Git, CVS, Mercurial and Bazaar. For all of these providers I made unit-tests. It would be nice to include these command into Maven SCM. Source code can be found here: http://svn.codehaus.org/sonar-plugins/trunk/scm-activity/maven-scm-ext/

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Issue Comment Edited: (SCM-532) Please add support for blame command

Posted by "Olivier Lamy (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/SCM-532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=213571#action_213571 ] 

Olivier Lamy edited comment on SCM-532 at 3/11/10 3:45 PM:
-----------------------------------------------------------

Reopen as a tck-git failed 
{code}
mvn clean verify -Ptck-git -Dtest=GitExeBlameCommandTckTest -DfailIfNoTests=false -Dsurefire.useFile=false

junit.framework.ComparisonFailure: expected:<[92f139df]> but was:<[^92f139d]>
        at junit.framework.Assert.assertEquals(Assert.java:81)
        at junit.framework.Assert.assertEquals(Assert.java:87)
        at org.apache.maven.scm.provider.git.gitexe.command.blame.GitExeBlameCommandTckTest.verifyResult(GitExeBlameCommandTckTest.java:53)
        at org.apache.maven.scm.tck.command.blame.BlameCommandTckTest.testBlameCommand(BlameCommandTckTest.java:99)
        at org.apache.maven.scm.provider.git.gitexe.command.blame.GitExeBlameCommandTckTest.testBlameCommand(GitExeBlameCommandTckTest.java:44)
{code}
This issue happen on solaris env (with git version 1.5.6.2)
But not on windauze (with git version 1.6.5.1.1367.gcd48)

      was (Author: olamy):
    Reopen as a tck-git failed 
{code}
mvn clean verify -Ptck-git -Dtest=GitExeBlameCommandTckTest -DfailIfNoTests=false -Dsurefire.useFile=false

junit.framework.ComparisonFailure: expected:<[92f139df]> but was:<[^92f139d]>
        at junit.framework.Assert.assertEquals(Assert.java:81)
        at junit.framework.Assert.assertEquals(Assert.java:87)
        at org.apache.maven.scm.provider.git.gitexe.command.blame.GitExeBlameCommandTckTest.verifyResult(GitExeBlameCommandTckTest.java:53)
        at org.apache.maven.scm.tck.command.blame.BlameCommandTckTest.testBlameCommand(BlameCommandTckTest.java:99)
        at org.apache.maven.scm.provider.git.gitexe.command.blame.GitExeBlameCommandTckTest.testBlameCommand(GitExeBlameCommandTckTest.java:44)
{code}
  
> Please add support for blame command
> ------------------------------------
>
>                 Key: SCM-532
>                 URL: http://jira.codehaus.org/browse/SCM-532
>             Project: Maven SCM
>          Issue Type: New Feature
>          Components: maven-scm-api, maven-scm-provider-bazaar, maven-scm-provider-cvs, maven-scm-provider-git, maven-scm-provider-mercurial (hg), maven-scm-provider-svn
>            Reporter: Evgeny Mandrikov
>            Assignee: Olivier Lamy
>             Fix For: 1.4
>
>         Attachments: SCM-532.diff
>
>
> I've made an extension for Maven SCM for blame command. This extension currently part of [Sonar SCM Activity Plugin|http://docs.codehaus.org/display/SONAR/SCM+Activity+Plugin] and supports Subversion (pure Java too), Git, CVS, Mercurial and Bazaar. For all of these providers I made unit-tests. It would be nice to include these command into Maven SCM. Source code can be found here: http://svn.codehaus.org/sonar-plugins/trunk/scm-activity/maven-scm-ext/

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (SCM-532) Please add support for blame command

Posted by "Evgeny Mandrikov (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/SCM-532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=255885#action_255885 ] 

Evgeny Mandrikov commented on SCM-532:
--------------------------------------

Note that this relates not only to balme, but also to changelog, which should include both authors and committers.

> Please add support for blame command
> ------------------------------------
>
>                 Key: SCM-532
>                 URL: http://jira.codehaus.org/browse/SCM-532
>             Project: Maven SCM
>          Issue Type: New Feature
>          Components: maven-scm-api, maven-scm-provider-bazaar, maven-scm-provider-cvs, maven-scm-provider-git, maven-scm-provider-mercurial (hg), maven-scm-provider-svn
>            Reporter: Evgeny Mandrikov
>            Assignee: Olivier Lamy
>             Fix For: 1.4
>
>         Attachments: SCM-532.diff
>
>
> I've made an extension for Maven SCM for blame command. This extension currently part of [Sonar SCM Activity Plugin|http://docs.codehaus.org/display/SONAR/SCM+Activity+Plugin] and supports Subversion (pure Java too), Git, CVS, Mercurial and Bazaar. For all of these providers I made unit-tests. It would be nice to include these command into Maven SCM. Source code can be found here: http://svn.codehaus.org/sonar-plugins/trunk/scm-activity/maven-scm-ext/

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (SCM-532) Please add support for blame command

Posted by "Evgeny Mandrikov (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/SCM-532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=210897#action_210897 ] 

Evgeny Mandrikov commented on SCM-532:
--------------------------------------

Yes, I know ;)

> Please add support for blame command
> ------------------------------------
>
>                 Key: SCM-532
>                 URL: http://jira.codehaus.org/browse/SCM-532
>             Project: Maven SCM
>          Issue Type: New Feature
>          Components: maven-scm-api, maven-scm-provider-bazaar, maven-scm-provider-cvs, maven-scm-provider-git, maven-scm-provider-mercurial (hg), maven-scm-provider-svn
>            Reporter: Evgeny Mandrikov
>            Assignee: Olivier Lamy
>             Fix For: 1.4
>
>
> I've made an extension for Maven SCM for blame command. This extension currently part of [Sonar SCM Activity Plugin|http://docs.codehaus.org/display/SONAR/SCM+Activity+Plugin] and supports Subversion (pure Java too), Git, CVS, Mercurial and Bazaar. For all of these providers I made unit-tests. It would be nice to include these command into Maven SCM. Source code can be found here: http://svn.codehaus.org/sonar-plugins/trunk/scm-activity/maven-scm-ext/

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (SCM-532) Please add support for blame command

Posted by "Olivier Lamy (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/SCM-532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=210896#action_210896 ] 

Olivier Lamy commented on SCM-532:
----------------------------------

note for maven-scm the code must be 1.4 compatible (not as in sonar where the code use generics)

> Please add support for blame command
> ------------------------------------
>
>                 Key: SCM-532
>                 URL: http://jira.codehaus.org/browse/SCM-532
>             Project: Maven SCM
>          Issue Type: New Feature
>          Components: maven-scm-api, maven-scm-provider-bazaar, maven-scm-provider-cvs, maven-scm-provider-git, maven-scm-provider-mercurial (hg), maven-scm-provider-svn
>            Reporter: Evgeny Mandrikov
>            Assignee: Olivier Lamy
>             Fix For: 1.4
>
>
> I've made an extension for Maven SCM for blame command. This extension currently part of [Sonar SCM Activity Plugin|http://docs.codehaus.org/display/SONAR/SCM+Activity+Plugin] and supports Subversion (pure Java too), Git, CVS, Mercurial and Bazaar. For all of these providers I made unit-tests. It would be nice to include these command into Maven SCM. Source code can be found here: http://svn.codehaus.org/sonar-plugins/trunk/scm-activity/maven-scm-ext/

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (SCM-532) Please add support for blame command

Posted by "Olivier Lamy (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/SCM-532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Olivier Lamy closed SCM-532.
----------------------------

    Resolution: Fixed

fixed in [rev 922015|http://svn.apache.org/viewvc?rev=922015&view=rev]
Thanks !

> Please add support for blame command
> ------------------------------------
>
>                 Key: SCM-532
>                 URL: http://jira.codehaus.org/browse/SCM-532
>             Project: Maven SCM
>          Issue Type: New Feature
>          Components: maven-scm-api, maven-scm-provider-bazaar, maven-scm-provider-cvs, maven-scm-provider-git, maven-scm-provider-mercurial (hg), maven-scm-provider-svn
>            Reporter: Evgeny Mandrikov
>            Assignee: Olivier Lamy
>             Fix For: 1.4
>
>         Attachments: SCM-532.diff
>
>
> I've made an extension for Maven SCM for blame command. This extension currently part of [Sonar SCM Activity Plugin|http://docs.codehaus.org/display/SONAR/SCM+Activity+Plugin] and supports Subversion (pure Java too), Git, CVS, Mercurial and Bazaar. For all of these providers I made unit-tests. It would be nice to include these command into Maven SCM. Source code can be found here: http://svn.codehaus.org/sonar-plugins/trunk/scm-activity/maven-scm-ext/

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (SCM-532) Please add support for blame command

Posted by "Olivier Lamy (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/SCM-532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Olivier Lamy updated SCM-532:
-----------------------------

    Fix Version/s: 1.4
         Assignee: Olivier Lamy

> Please add support for blame command
> ------------------------------------
>
>                 Key: SCM-532
>                 URL: http://jira.codehaus.org/browse/SCM-532
>             Project: Maven SCM
>          Issue Type: New Feature
>          Components: maven-scm-api, maven-scm-provider-bazaar, maven-scm-provider-cvs, maven-scm-provider-git, maven-scm-provider-mercurial (hg), maven-scm-provider-svn
>            Reporter: Evgeny Mandrikov
>            Assignee: Olivier Lamy
>             Fix For: 1.4
>
>
> I've made an extension for Maven SCM for blame command. This extension currently part of [Sonar SCM Activity Plugin|http://docs.codehaus.org/display/SONAR/SCM+Activity+Plugin] and supports Subversion (pure Java too), Git, CVS, Mercurial and Bazaar. For all of these providers I made unit-tests. It would be nice to include these command into Maven SCM. Source code can be found here: http://svn.codehaus.org/sonar-plugins/trunk/scm-activity/maven-scm-ext/

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira