[GitHub] [pulsar] MarvinCai commented on a change in pull request #10028: [Issue 10010][Client] fixed memory leak

[GitBox <gi...@apache.org>]

MarvinCai commented on a change in pull request #10028:
URL: https://github.com/apache/pulsar/pull/10028#discussion_r607585203



##########
File path: pulsar-client-api/src/main/java/org/apache/pulsar/client/api/PulsarClient.java
##########
@@ -281,7 +281,8 @@ static ClientBuilder builder() {
      * Perform immediate shutdown of PulsarClient.
      *
      * <p>Release all the resources and close all the producer, consumer and reader instances without waiting
-     * for ongoing operations to complete.
+     * for ongoing operations to complete. Resources passed from the outside like EventLoopGroup or ConnectionPool
+     * will not be closed.

Review comment:
       PulsarClientImpl's constructors are actually public(probably shouldn't be as we don't expect user direct create one themself?) 
   @abhilashmandaliya I was thinking about adding doc on PulsarClientImpl's constructor, but as it not intended to be used directly by user. And seems the ClientBuilder doesn't support pass in eventloopgroup and cnxpool for now, it doesn't make much sense to tell user about the internal of pulsarclient, we probably don't need that doc for now, and if in the future we support pass in eventloopgroup/cnxpool we can add them then. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org