You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "2010YOUY01 (via GitHub)" <gi...@apache.org> on 2025/11/11 10:15:12 UTC

[I] [Tracking] Refactor with `assert_or_internal_err!()` across the codebase [datafusion]

2010YOUY01 opened a new issue, #18613:
URL: https://github.com/apache/datafusion/issues/18613

   ### Is your feature request related to a problem or challenge?
   
   https://github.com/apache/datafusion/pull/18511 has introduced a macro for easier internal invariant check, this issue is tracking the progress to refactor with this macro.
   
   The potential places to refactor can be found with
   ```sh
   # under datafusion/
   # Find all patterns match: line k includes 'if', line k+1 includes 'internal_err'
   rg -U -P 'if.*\r?\n.*internal_err'
   ```
   There are 100+ matched patterns, we can update them incrementally to avoid merge conflicts. Here are the major paths to update:
   
   - [ ] datafusion/sql
   - [ ] datafusion/spark
   - [ ] datafusion/physical-plan
   - [ ] datafusion/physical-optimizer
   - [ ] datafusion/physical-expr-common
   - [ ] datafusion/physical-expr
   - [ ] datafusion/optimizer
   - [ ] datafusion/functions-nested
   - [ ] datafusion/functions-aggregate
   - [ ] datafusion/functions
   - [ ] datafusion/expr
   - [ ] datafusion/expr-common
   - [ ] datafusion/datasource
   - [ ] datafusion/common
   
   ### Describe the solution you'd like
   
   _No response_
   
   ### Describe alternatives you've considered
   
   _No response_
   
   ### Additional context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [I] [Tracking] Refactor with `assert_or_internal_err!()` across the codebase [datafusion]

Posted by "AryanBagade (via GitHub)" <gi...@apache.org>.
AryanBagade commented on issue #18613:
URL: https://github.com/apache/datafusion/issues/18613#issuecomment-3520758694

   take


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [I] [Tracking] Refactor with `assert_or_internal_err!()` across the codebase [datafusion]

Posted by "2010YOUY01 (via GitHub)" <gi...@apache.org>.
2010YOUY01 commented on issue #18613:
URL: https://github.com/apache/datafusion/issues/18613#issuecomment-3524980419

   > take
   
   @AryanBagade Hi, this is a tracking issue, not a task.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [I] [Tracking] Refactor with `assert_or_internal_err!()` across the codebase [datafusion]

Posted by "2010YOUY01 (via GitHub)" <gi...@apache.org>.
2010YOUY01 closed issue #18613: [Tracking] Refactor with  `assert_or_internal_err!()` across the codebase
URL: https://github.com/apache/datafusion/issues/18613


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [I] [Tracking] Refactor with `assert_or_internal_err!()` across the codebase [datafusion]

Posted by "kumarUjjawal (via GitHub)" <gi...@apache.org>.
kumarUjjawal commented on issue #18613:
URL: https://github.com/apache/datafusion/issues/18613#issuecomment-3533037320

   @2010YOUY01 I opened PR for few of them, mostly they are trivial but in one i got stuck with test failing, maybe you can take a look and provide any suggestions. In next couple of days i will try to tackle others. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [I] [Tracking] Refactor with `assert_or_internal_err!()` across the codebase [datafusion]

Posted by "Lori-Shu (via GitHub)" <gi...@apache.org>.
Lori-Shu commented on issue #18613:
URL: https://github.com/apache/datafusion/issues/18613#issuecomment-3522103864

   take datafusion/common.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [I] [Tracking] Refactor with `assert_or_internal_err!()` across the codebase [datafusion]

Posted by "2010YOUY01 (via GitHub)" <gi...@apache.org>.
2010YOUY01 commented on issue #18613:
URL: https://github.com/apache/datafusion/issues/18613#issuecomment-3535424193

   > [@2010YOUY01](https://github.com/2010YOUY01) I opened PR for few of them, mostly they are trivial but in one i got stuck with test failing, maybe you can take a look and provide any suggestions. In next couple of days i will try to tackle others.
   
   @kumarUjjawal Thank you so much! CI failures is likely due the the CI runner issue, I'll re-trigger it once we got them fixed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [I] [Tracking] Refactor with `assert_or_internal_err!()` across the codebase [datafusion]

Posted by "2010YOUY01 (via GitHub)" <gi...@apache.org>.
2010YOUY01 commented on issue #18613:
URL: https://github.com/apache/datafusion/issues/18613#issuecomment-3519458569

   This is a pretty straightforward task — would appreciate any help on it. Feel free to claim an individual task by replying here with “take datafusion/spark.”
   Here is a example PR on refactoring inside `datafusion/sql` https://github.com/apache/datafusion/pull/18614


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [I] [Tracking] Refactor with `assert_or_internal_err!()` across the codebase [datafusion]

Posted by "Lori-Shu (via GitHub)" <gi...@apache.org>.
Lori-Shu commented on issue #18613:
URL: https://github.com/apache/datafusion/issues/18613#issuecomment-3522097964

   take datafusion/common


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org