You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "stefan-egli (via GitHub)" <gi...@apache.org> on 2024/01/24 12:15:50 UTC
[PR] OAK-10595 : explicit invalidation journal entry after collsion rollback [jackrabbit-oak]
stefan-egli opened a new pull request, #1284:
URL: https://github.com/apache/jackrabbit-oak/pull/1284
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-10595 : explicit invalidation journal entry after collsion rollback [jackrabbit-oak]
Posted by "stefan-egli (via GitHub)" <gi...@apache.org>.
stefan-egli commented on code in PR #1284:
URL: https://github.com/apache/jackrabbit-oak/pull/1284#discussion_r1466410590
##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStore.java:
##########
@@ -2640,20 +2687,25 @@ private void invalidatePaths(@NotNull Set<Path> pathsToInvalidate) {
// nothing to do
return;
}
+ invalidatePaths0(pathsToInvalidate, "split",
+ " Will be retried with next background split operation.");
+ }
+
+ private void invalidatePaths0(@NotNull Iterable<Path> pathsToInvalidate, String type,
Review Comment:
`invalidatePaths1` ? ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-10595 : explicit invalidation journal entry after collsion rollback [jackrabbit-oak]
Posted by "stefan-egli (via GitHub)" <gi...@apache.org>.
stefan-egli commented on PR #1284:
URL: https://github.com/apache/jackrabbit-oak/pull/1284#issuecomment-1918879589
toggle introduced in [this commit](https://github.com/apache/jackrabbit-oak/pull/1284/commits/ad9f90ca178157ecfb9e0b82db221341c23d97eb)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-10595 : explicit invalidation journal entry after collsion rollback [jackrabbit-oak]
Posted by "stefan-egli (via GitHub)" <gi...@apache.org>.
stefan-egli commented on PR #1284:
URL: https://github.com/apache/jackrabbit-oak/pull/1284#issuecomment-1909689762
> I wonder if they could be more issues in different places where the root cause is a not properly updated/invalidated cache entry.
It should affect whenever a written revision is later reverted - which is what the rollback is doing. I'll revisit for other potential rollback cases that wouldn't go through the now fixed code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-10595 : explicit invalidation journal entry after collsion rollback [jackrabbit-oak]
Posted by "stefan-egli (via GitHub)" <gi...@apache.org>.
stefan-egli commented on PR #1284:
URL: https://github.com/apache/jackrabbit-oak/pull/1284#issuecomment-1918732436
@reschke RDB test added [here](https://github.com/apache/jackrabbit-oak/pull/1284/commits/d9566b56536dc6f9511458320ddf1b18ba1ba24a)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-10595 : explicit invalidation journal entry after collsion rollback [jackrabbit-oak]
Posted by "stefan-egli (via GitHub)" <gi...@apache.org>.
stefan-egli merged PR #1284:
URL: https://github.com/apache/jackrabbit-oak/pull/1284
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-10595 : explicit invalidation journal entry after collsion rollback [jackrabbit-oak]
Posted by "reschke (via GitHub)" <gi...@apache.org>.
reschke commented on code in PR #1284:
URL: https://github.com/apache/jackrabbit-oak/pull/1284#discussion_r1466320230
##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStore.java:
##########
@@ -2640,20 +2687,25 @@ private void invalidatePaths(@NotNull Set<Path> pathsToInvalidate) {
// nothing to do
return;
}
+ invalidatePaths0(pathsToInvalidate, "split",
+ " Will be retried with next background split operation.");
+ }
+
+ private void invalidatePaths0(@NotNull Iterable<Path> pathsToInvalidate, String type,
Review Comment:
this cries for a better method name :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-10595 : explicit invalidation journal entry after collsion rollback [jackrabbit-oak]
Posted by "stefan-egli (via GitHub)" <gi...@apache.org>.
stefan-egli commented on PR #1284:
URL: https://github.com/apache/jackrabbit-oak/pull/1284#issuecomment-1908557328
Added a description on the suggested fix in [this comment](https://issues.apache.org/jira/browse/OAK-10595?focusedCommentId=17810500&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17810500)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-10595 : explicit invalidation journal entry after collsion rollback [jackrabbit-oak]
Posted by "Joscorbe (via GitHub)" <gi...@apache.org>.
Joscorbe commented on code in PR #1284:
URL: https://github.com/apache/jackrabbit-oak/pull/1284#discussion_r1474406537
##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStore.java:
##########
@@ -2640,20 +2687,25 @@ private void invalidatePaths(@NotNull Set<Path> pathsToInvalidate) {
// nothing to do
return;
}
+ invalidatePaths0(pathsToInvalidate, "split",
+ " Will be retried with next background split operation.");
+ }
+
+ private void invalidatePaths0(@NotNull Iterable<Path> pathsToInvalidate, String type,
Review Comment:
What about `createInvalidationJournalEntry`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-10595 : explicit invalidation journal entry after collsion rollback [jackrabbit-oak]
Posted by "stefan-egli (via GitHub)" <gi...@apache.org>.
stefan-egli commented on code in PR #1284:
URL: https://github.com/apache/jackrabbit-oak/pull/1284#discussion_r1474450149
##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStore.java:
##########
@@ -2640,20 +2687,25 @@ private void invalidatePaths(@NotNull Set<Path> pathsToInvalidate) {
// nothing to do
return;
}
+ invalidatePaths0(pathsToInvalidate, "split",
+ " Will be retried with next background split operation.");
+ }
+
+ private void invalidatePaths0(@NotNull Iterable<Path> pathsToInvalidate, String type,
Review Comment:
thx, renamed in https://github.com/apache/jackrabbit-oak/pull/1284/commits/e0bd8a1c1ec567ab551c787fea9f67a052fe6b44
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-10595 : explicit invalidation journal entry after collsion rollback [jackrabbit-oak]
Posted by "stefan-egli (via GitHub)" <gi...@apache.org>.
stefan-egli commented on code in PR #1284:
URL: https://github.com/apache/jackrabbit-oak/pull/1284#discussion_r1466411609
##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStore.java:
##########
@@ -2640,20 +2687,25 @@ private void invalidatePaths(@NotNull Set<Path> pathsToInvalidate) {
// nothing to do
return;
}
+ invalidatePaths0(pathsToInvalidate, "split",
+ " Will be retried with next background split operation.");
+ }
+
+ private void invalidatePaths0(@NotNull Iterable<Path> pathsToInvalidate, String type,
Review Comment:
(open for suggestions!)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-10595 : explicit invalidation journal entry after collsion rollback [jackrabbit-oak]
Posted by "stefan-egli (via GitHub)" <gi...@apache.org>.
stefan-egli commented on PR #1284:
URL: https://github.com/apache/jackrabbit-oak/pull/1284#issuecomment-1910733473
still planning on generalizing for any DocumentStore as [discussed here|https://issues.apache.org/jira/browse/OAK-10595?focusedCommentId=17810916&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17810916]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org