You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by "castorqin (via GitHub)" <gi...@apache.org> on 2024/02/27 07:23:03 UTC
[PR] [INLONG-9696][Manager] Manager client support delete inlong tenant [inlong]
castorqin opened a new pull request, #9732:
URL: https://github.com/apache/inlong/pull/9732
### Prepare a Pull Request
*(Change the title refer to the following example)*
- Title Example: [INLONG-XYZ][Component] Title of the pull request
*(The following *XYZ* should be replaced by the actual [GitHub Issue](https://github.com/apache/inlong/issues) number)*
- Fixes #9696
### Motivation
Manager client support delete inlong tenant
### Modifications
The details can be found at [#9696 ](https://github.com/apache/inlong/issues/9696).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-9696][Manager] Manager client support delete inlong tenant and role [inlong]
Posted by "castorqin (via GitHub)" <gi...@apache.org>.
castorqin commented on code in PR #9732:
URL: https://github.com/apache/inlong/pull/9732#discussion_r1503835575
##########
inlong-manager/manager-client/src/main/java/org/apache/inlong/manager/client/api/service/InlongTenantApi.java:
##########
@@ -43,6 +43,9 @@ public interface InlongTenantApi {
@GET("tenant/get/{name}")
Call<Response<InlongTenantInfo>> get(@Path("name") String name);
+ @GET("tenant/delete/{name}")
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-9696][Manager] Manager client support delete inlong tenant and role [inlong]
Posted by "dockerzhang (via GitHub)" <gi...@apache.org>.
dockerzhang commented on code in PR #9732:
URL: https://github.com/apache/inlong/pull/9732#discussion_r1503823833
##########
inlong-manager/manager-client/src/main/java/org/apache/inlong/manager/client/api/service/InlongTenantApi.java:
##########
@@ -43,6 +43,9 @@ public interface InlongTenantApi {
@GET("tenant/get/{name}")
Call<Response<InlongTenantInfo>> get(@Path("name") String name);
+ @GET("tenant/delete/{name}")
Review Comment:
GET->DELETE ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-9696][Manager] Manager client support delete inlong tenant and role [inlong]
Posted by "dockerzhang (via GitHub)" <gi...@apache.org>.
dockerzhang merged PR #9732:
URL: https://github.com/apache/inlong/pull/9732
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-9696][Manager] Manager client support delete inlong tenant and role [inlong]
Posted by "fuweng11 (via GitHub)" <gi...@apache.org>.
fuweng11 commented on code in PR #9732:
URL: https://github.com/apache/inlong/pull/9732#discussion_r1503770560
##########
inlong-manager/manager-client/src/main/java/org/apache/inlong/manager/client/api/service/InlongTenantRoleApi.java:
##########
@@ -40,6 +40,9 @@ public interface InlongTenantRoleApi {
@POST("role/tenant/update")
Call<Response<Boolean>> update(@Body TenantRoleRequest request);
+ @GET("role/tenant/delete/{id}")
Review Comment:
@DELETE("role/tenant/delete/{id}")
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org