You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by mg...@apache.org on 2014/12/13 21:47:49 UTC

wicket git commit: Factory method for the hours TextField.

Repository: wicket
Updated Branches:
  refs/heads/wicket-6.x c4f1f6f40 -> 57b6db28e


Factory method for the hours TextField.


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/57b6db28
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/57b6db28
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/57b6db28

Branch: refs/heads/wicket-6.x
Commit: 57b6db28e054baac7a08423d6daaa47c99351e22
Parents: c4f1f6f
Author: astrapi69 <as...@gmx.net>
Authored: Sat Dec 13 17:31:21 2014 +0100
Committer: Martin Tzvetanov Grigorov <mg...@apache.org>
Committed: Sat Dec 13 22:47:06 2014 +0200

----------------------------------------------------------------------
 .../extensions/yui/calendar/DateTimeField.java  | 25 ++++++++++++++++----
 1 file changed, 20 insertions(+), 5 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/wicket/blob/57b6db28/wicket-datetime/src/main/java/org/apache/wicket/extensions/yui/calendar/DateTimeField.java
----------------------------------------------------------------------
diff --git a/wicket-datetime/src/main/java/org/apache/wicket/extensions/yui/calendar/DateTimeField.java b/wicket-datetime/src/main/java/org/apache/wicket/extensions/yui/calendar/DateTimeField.java
index 7a6c046..9a7e48d 100644
--- a/wicket-datetime/src/main/java/org/apache/wicket/extensions/yui/calendar/DateTimeField.java
+++ b/wicket-datetime/src/main/java/org/apache/wicket/extensions/yui/calendar/DateTimeField.java
@@ -143,11 +143,7 @@ public class DateTimeField extends FormComponentPanel<Date>
 		dateField.add(newDatePicker());
 
 		// Create and add the "hours" TextField
-		add(hoursField = new TextField<Integer>(HOURS, new PropertyModel<Integer>(this, HOURS),
-			Integer.class));
-		hoursField.add(getMaximumHours() == 24 ? RangeValidator.range(0, 23) : RangeValidator
-			.range(1, 12));
-		hoursField.setLabel(new Model<String>(HOURS));
+		add(hoursField = newHoursTextField(HOURS, new PropertyModel<Integer>(this, HOURS), Integer.class));
 
 		// Create and add the "minutes" TextField
 		add(minutesField = new TextField<Integer>(MINUTES,
@@ -189,6 +185,25 @@ public class DateTimeField extends FormComponentPanel<Date>
 	}
 
 	/**
+	 * create a new {@link TextField} instance for hours to be added to this panel.
+	 * 
+	 * @param id
+	 *            the component id
+	 * @param model
+	 *            model that should be used by the {@link TextField}
+	 * @param type
+	 *            the type of the text field
+	 * @return a new text field instance
+	 */
+	protected TextField<Integer> newHoursTextField(final String id, IModel<Integer> model, Class<Integer> type) {
+		TextField<Integer> hoursTextField = new TextField<Integer>(id, model, type);
+		hoursTextField.add(getMaximumHours() == 24 ? RangeValidator.range(0, 23) : RangeValidator
+			.range(1, 12));
+		hoursTextField.setLabel(new Model<String>(HOURS));
+		return hoursTextField;
+	}
+
+	/**
 	 * 
 	 * @return The date TextField
 	 */