You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/12/23 14:08:39 UTC
[GitHub] [arrow-datafusion] alamb opened a new pull request, #4717: Minor: refactor streaming CSV inference code
alamb opened a new pull request, #4717:
URL: https://github.com/apache/arrow-datafusion/pull/4717
# Which issue does this PR close?
re https://github.com/apache/arrow-datafusion/issues/3658
# Rationale for this change
I spent some time messing with this code as part of review https://github.com/apache/arrow-datafusion/pull/4661#issuecomment-1363824177 trying to make it easier to read, so I figured I would put it up for review
# What changes are included in this PR?
Move some code around into functions with comments to avoid double nested loops
# Are these changes tested?
covered by existing tests
# Are there any user-facing changes?
no
cc @Jefffrey
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #4717: Minor: refactor streaming CSV inference code
Posted by GitBox <gi...@apache.org>.
alamb merged PR #4717:
URL: https://github.com/apache/arrow-datafusion/pull/4717
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #4717: Minor: refactor streaming CSV inference code
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #4717:
URL: https://github.com/apache/arrow-datafusion/pull/4717#issuecomment-1364332276
Benchmark runs are scheduled for baseline = af9cd58751288f495b47f0585c6fa182d270e11d and contender = 2f5b25d8aa8089232f395aa9a7ac15c715eaaa83. 2f5b25d8aa8089232f395aa9a7ac15c715eaaa83 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/f2dd2648f8f543fba06d45fd9575caee...541588476e8340f4b292e4a1a7022cd6/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/394a7655c62040a38f70ffb25c1d6a9c...cb6b0d4799e741389be1f7cf2f80ae6d/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/1a5f88f73f834d5986c9085d8c3056f6...23c060321f014788b2e5f7c418cf2b0f/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/d2a89b1e8b7045198525c7a80a3eee7c...897f5b193cd848dc9313e7a9cfe7f763/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org