[GitHub] [spark] MaxGekk commented on a diff in pull request #42616: [SPARK-44840][SQL][3.5] Make `array_insert()` 1-based for negative indexes

["MaxGekk (via GitHub)" <gi...@apache.org>]

MaxGekk commented on code in PR #42616:
URL: https://github.com/apache/spark/pull/42616#discussion_r1302157936


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala:
##########
@@ -4674,23 +4674,34 @@ case class ArrayExcept(left: Expression, right: Expression) extends ArrayBinaryL
 @ExpressionDescription(
   usage = """
     _FUNC_(x, pos, val) - Places val into index pos of array x.
-      Array indices start at 1, or start from the end if index is negative.
+      Array indices start at 1. The maximum negative index is -1 for which the function inserts

Review Comment:
   >  Is it mathematically to indicate -1 is the biggest among all negative values for pos parameter?
   
   Correct.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org