[GitHub] [airflow] shankarcb commented on pull request #16754: Only allow webserver to request from the worker log server

[GitBox <gi...@apache.org>]

shankarcb commented on pull request #16754:
URL: https://github.com/apache/airflow/pull/16754#issuecomment-963222750


   This push has introduced another bug of 403 client error when DAG logs are fetched from Airflow WebUI. This bug appears to impact when Airflow is setup in cluster mode. We have setup Airflow in cluster mode with Celery - One master and multiple worker nodes. [Not Celery kubernetes]
   Error message was that secret_key is not matching which was not the case since identical copies of airflow.cfg was used in master and worker nodes. 
   
   **After increasing the default fallback value to 120 seconds in below code snippet, this has fixed the 403 client error issue.** 
    We added "log_request_clock_grace" under [webserver] section on airflow.cfg to override this value which did not work. We had to manually change the code in airflow installation to fix the issue. However, this is not recommended/permanent solution. **Please fix this in future releases.**
   
   def create_app():
       flask_app = Flask(__name__, static_folder=None)
       max_request_age = conf.getint('webserver', 'log_request_clock_grace', **fallback=30**)
   
   Code: https://github.com/apache/airflow/blob/main/airflow/utils/serve_logs.py
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org