You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by kelvindart <gi...@git.apache.org> on 2017/10/18 16:23:12 UTC
[GitHub] cordova-plugin-media pull request #150: CB-13294 Remove cordova-plugin-compa...
GitHub user kelvindart opened a pull request:
https://github.com/apache/cordova-plugin-media/pull/150
CB-13294 Remove cordova-plugin-compat and include cordova-android dep…
### Platforms affected
cordova-android@6.3.0
### What does this PR do?
Removes the dependency on cordova-plugin-compat, and includes checks for min platform version.
### What testing has been done on this change?
Testing 1:
- Add local plugin to project containing cordova-android@6.3.0
- Verify plugin installs, and app runs.
Testing 2:
- Add local plugin to project containing cordova-android@6.2.3
- Verify plugin does not install.
- Console log as follows:
```
Plugin doesn't support this project's cordova-android version. cordova-android: 6.2.3, failed version requirement: >=6.3.0
Skipping 'cordova-plugin-media' for android
```
This is desirable - this change stops the plugin being installed on `<cordova-android@6.3.0`
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kelvindart/cordova-plugin-media master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-media/pull/150.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #150
----
commit 6289cfbd9dcdbd57c780fc710661cd3b0b5589d9
Author: Kelvin Dart <ke...@crimsontide.co.uk>
Date: 2017-10-18T15:52:44Z
CB-13294 Remove cordova-plugin-compat and include cordova-android dependency
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] cordova-plugin-media pull request #150: CB-13294 Remove cordova-plugin-compa...
Posted by kelvindart <gi...@git.apache.org>.
Github user kelvindart closed the pull request at:
https://github.com/apache/cordova-plugin-media/pull/150
---
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org