You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by ah...@apache.org on 2024/07/08 11:17:06 UTC

(commons-numbers) 04/07: Drop TODO for additional Complex edge cases

This is an automated email from the ASF dual-hosted git repository.

aherbert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-numbers.git

commit fd81e017f42059576d0d032d49fba4a80e61f811
Author: Alex Herbert <ah...@apache.org>
AuthorDate: Mon Jul 8 11:44:04 2024 +0100

    Drop TODO for additional Complex edge cases
    
    The edge cases for pow are not defined for extreme values (MAX_VALUE,
    MIN_VALUE), thus comparison to other implementations is arbitrary.
---
 .../java/org/apache/commons/numbers/complex/ComplexEdgeCaseTest.java   | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/commons-numbers-complex/src/test/java/org/apache/commons/numbers/complex/ComplexEdgeCaseTest.java b/commons-numbers-complex/src/test/java/org/apache/commons/numbers/complex/ComplexEdgeCaseTest.java
index 95a39520..9055ac48 100644
--- a/commons-numbers-complex/src/test/java/org/apache/commons/numbers/complex/ComplexEdgeCaseTest.java
+++ b/commons-numbers-complex/src/test/java/org/apache/commons/numbers/complex/ComplexEdgeCaseTest.java
@@ -686,9 +686,6 @@ class ComplexEdgeCaseTest {
 
         // pow(Complex) is log().multiply(Complex).exp()
         // All are overflow safe and handle infinities as defined in the C99 standard.
-        // TODO: Test edge cases with:
-        // Double.MAX_VALUE, Double.MIN_NORMAL, Inf
-        // using other library implementations.
 
         // Test NaN
         assertComplex(1, 1, nan, nan, name, operation, nan, nan);