You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/08/27 16:37:48 UTC

[GitHub] [superset] ktmud commented on pull request #16483: refactor: Changes the DatabaseSelector and TableSelector to use the new Select component

ktmud commented on pull request #16483:
URL: https://github.com/apache/superset/pull/16483#issuecomment-907330381


   Some UX issues found during local testing:
   
   1. For db types, can we use the same tag style instead of just text?
      ### Now
      <img width="522" alt="Xnip2021-08-27_09-27-41" src="https://user-images.githubusercontent.com/335541/131159469-7d2dc7a7-a960-4829-aea7-7ac372961379.png">
   
      ### Before
      <img width="460" alt="Xnip2021-08-27_09-30-45" src="https://user-images.githubusercontent.com/335541/131159577-7061bac5-444d-48b9-bfc9-2ecd91aa2be5.png">
   
   2. Loading state should show "Loading..." instead of "No data"
      ### Now
      <img width="537" alt="Xnip2021-08-27_09-28-10" src="https://user-images.githubusercontent.com/335541/131159773-4a587801-f100-4aa6-b274-50282d6f0dfc.png">
   
      ### Before
      <img width="442" alt="Xnip2021-08-27_09-33-32" src="https://user-images.githubusercontent.com/335541/131159865-145e2d2a-27e1-43eb-81b5-2f1848538a65.png">
   
      I think we should keep the same placeholder text as well.
   
   3. Previously the Select will automatically load tables list of current selected schema when you refresh the page, now you have to focus on the tables select. I think we should keep the pre-load behavior because it can be quite slow to load the table list for some databases.
   4. Scrolling tables list to the end will trigger an unnecessary new query----probably trying to fetch the next page?
      <img width="654" alt="Xnip2021-08-27_09-29-39" src="https://user-images.githubusercontent.com/335541/131160300-1c2aed71-dea8-4921-b5d5-2300728071d6.png">
   
   
   Will take a look at the code once these issues are fixed.
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org