You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@grails.apache.org by "matrei (via GitHub)" <gi...@apache.org> on 2025/07/22 07:55:51 UTC
[PR] M5 another take [grails-redis]
matrei opened a new pull request, #190:
URL: https://github.com/apache/grails-redis/pull/190
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Prep for M5 [grails-redis]
Posted by "matrei (via GitHub)" <gi...@apache.org>.
matrei merged PR #190:
URL: https://github.com/apache/grails-redis/pull/190
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] M5 another take [grails-redis]
Posted by "jdaugherty (via GitHub)" <gi...@apache.org>.
jdaugherty commented on code in PR #190:
URL: https://github.com/apache/grails-redis/pull/190#discussion_r2223550972
##########
plugin/src/test/groovy/grails/plugins/redis/RedisServiceSpec.groovy:
##########
@@ -33,6 +34,7 @@ import java.util.concurrent.*
import static grails.plugins.redis.RedisService.NO_EXPIRATION_TTL
@Integration
+@SpringBootTest
Review Comment:
The AST plugin is supposed to add these by default, why add them? Does this cause the test libraries to be pulled in or something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Prep for M5 [grails-redis]
Posted by "jdaugherty (via GitHub)" <gi...@apache.org>.
jdaugherty commented on code in PR #190:
URL: https://github.com/apache/grails-redis/pull/190#discussion_r2225649709
##########
plugin/src/test/groovy/grails/plugins/redis/RedisServiceSpec.groovy:
##########
@@ -33,6 +34,7 @@ import java.util.concurrent.*
import static grails.plugins.redis.RedisService.NO_EXPIRATION_TTL
@Integration
+@SpringBootTest
Review Comment:
We effectively made these unit tests by using the MOCK type, and yet they're in the integration test. We really should move these tests if they're going to remain as a unit test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Prep for M5 [grails-redis]
Posted by "matrei (via GitHub)" <gi...@apache.org>.
matrei commented on code in PR #190:
URL: https://github.com/apache/grails-redis/pull/190#discussion_r2226278493
##########
plugin/src/test/groovy/grails/plugins/redis/RedisServiceSpec.groovy:
##########
@@ -33,6 +34,7 @@ import java.util.concurrent.*
import static grails.plugins.redis.RedisService.NO_EXPIRATION_TTL
@Integration
+@SpringBootTest
Review Comment:
> We effectively made these unit tests by using the MOCK type, and yet they're in the integration test. We really should move these tests if they're going to remain as a unit test.
No, these are integration tests that require a running Redis server and an injected configured `RedisService`. But they are actually located in `src/test`. Looks like apache/grails-redis@d51909d7dc9325d3aa4dfbcd3ea191dbc65f3cdf moved it to the `src/test` folder when updating the project for Grails 3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] M5 another take [grails-redis]
Posted by "sbglasius (via GitHub)" <gi...@apache.org>.
sbglasius commented on code in PR #190:
URL: https://github.com/apache/grails-redis/pull/190#discussion_r2225136032
##########
plugin/src/test/groovy/grails/plugins/redis/RedisServiceSpec.groovy:
##########
@@ -33,6 +34,7 @@ import java.util.concurrent.*
import static grails.plugins.redis.RedisService.NO_EXPIRATION_TTL
@Integration
+@SpringBootTest
Review Comment:
I agree, that being able to pass arguments into `@Integration` that mimics `@SpringBootTest` would eliminate the average Grails users use of `@SpringBootTest` altogether.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] M5 another take [grails-redis]
Posted by "matrei (via GitHub)" <gi...@apache.org>.
matrei commented on code in PR #190:
URL: https://github.com/apache/grails-redis/pull/190#discussion_r2224603340
##########
plugin/src/test/groovy/grails/plugins/redis/RedisServiceSpec.groovy:
##########
@@ -33,6 +34,7 @@ import java.util.concurrent.*
import static grails.plugins.redis.RedisService.NO_EXPIRATION_TTL
@Integration
+@SpringBootTest
Review Comment:
The `@Integration` annotation adds the `@SpringBootTest` annotation with param `webEnvironment = RANDOM_PORT`. In this case where it is integration tests and not functional tests, we don't need a real web environment. Adding `@SpringBootTest` will replace the one from `@Integration` and use it's default `webEnvironment = MOCK`.
We should probably add a param to `@Integration` to be able to set this directly on `@Integration` instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org