[GitHub] [solr] epugh commented on a diff in pull request #1067: SOLR-16409: Admin UI - Expose all highlighting parameters in the Query UI

[GitBox <gi...@apache.org>]

epugh commented on code in PR #1067:
URL: https://github.com/apache/solr/pull/1067#discussion_r1017848134


##########
solr/webapp/web/js/angular/controllers/query.js:
##########
@@ -165,13 +165,21 @@ solrAdminApp.controller('QueryController',
                   return param.indexOf(argParam) === 0;
               });
       }
+
+      var getHighlighterFieldsToPurge = function(hlMethod){
+          // first, select the fieldsets which ng-show includes val['hl.method'] but not val['hl.method']==${hlMethod}
+          // then, select their descendants that have ng-model
+          const selector = `div.fieldset[ng-show*="val['hl.method']"]:not([ng-show*="val['hl.method']=='${hlMethod}'"])

Review Comment:
   if this works, great..   it's pretty gnarly css code!  I appreciate the comment explaining it ;-)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org