You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/12/04 10:18:50 UTC

[GitHub] [pulsar] congbobo184 opened a new pull request #8829: Fix bit set recycle repeat in client ack message

congbobo184 opened a new pull request #8829:
URL: https://github.com/apache/pulsar/pull/8829


   link #8825 
   
   ## Motivation
   In order to handle the bit set recycle.
   ![image](https://user-images.githubusercontent.com/39078850/101150361-1b20f280-365b-11eb-850a-4d73b3fd7477.png)
   the cumulative ack bit set recycle by this while, and the PR #8161 recycle the bit set in new ack command, cause the bit set recycle repeat.
   when the ack command recycle first it and then the while process, it will not throw exception, because the while catch the exception.
   when the while recycle first and then the ack command recycle, it will recycle repeat.
   ![image](https://user-images.githubusercontent.com/39078850/101151250-566ff100-365c-11eb-911c-2b67f13baf41.png)
   because of the environment is different from github ci and local so it will produce different result.
   
   
   when aborting and committing finish we should change the status in transaction coordinator.
   
   Does this pull request potentially affect one of the following parts:
   If yes was chosen, please highlight the changes
   
   Dependencies (does it add or upgrade a dependency): (no)
   The public API: (no)
   The schema: (no)
   The default values of configurations: (no)
   The wire protocol: (no)
   The rest endpoints: (no)
   The admin cli options: (no)
   Anything that affects deployment: (no)
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] jiazhai commented on pull request #8829: Fix bit set recycle repeat in client ack message

Posted by GitBox <gi...@apache.org>.
jiazhai commented on pull request #8829:
URL: https://github.com/apache/pulsar/pull/8829#issuecomment-738846687


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] merlimat merged pull request #8829: Fix bit set recycle repeat in client ack message

Posted by GitBox <gi...@apache.org>.
merlimat merged pull request #8829:
URL: https://github.com/apache/pulsar/pull/8829


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org