[jira] [Commented] (PROTON-2056) [proton-python] on_settled callback not called when disposition arrives in 2 frames

["Robbie Gemmell (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PROTON-2056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16849610#comment-16849610 ] 

Robbie Gemmell commented on PROTON-2056:
----------------------------------------

{quote}The on_settled must be called when a settlement arrives for every delivery.{quote}
I'd say not necessarily, if it is already locally settled. Then, the binding not calling on_settled would actually seem the correct thing to do.

Of course the questions would then become: is that perhaps happening, should it be, and does it actually have that effect?

Following that guess onward a bit, I think this line in the binding looks suspect:
[https://github.com/apache/qpid-proton/blob/0.28.0/python/proton/_handlers.py#L69]

It seems like it would locally settle the message even upon arrival of a non-settling disposition, which I'd say is typically going to be the wrong thing to do (i.e unless the link was negotiated as receiver settles second). That might then have a knock on effect which stops the on_settled handler firing when the remotely-settling disposition arrives (though as above, that would actually seem ok if the local settlement had been deliberate). The behaviour might also be different whether the second disposition occurs in the same or later TCP read as the first disposition.

> [proton-python]  on_settled callback not called when disposition arrives in 2 frames
> ------------------------------------------------------------------------------------
>
>                 Key: PROTON-2056
>                 URL: https://issues.apache.org/jira/browse/PROTON-2056
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: proton-c, python-binding
>    Affects Versions: proton-c-0.28.0
>            Reporter: Ganesh Murthy
>            Priority: Major
>
> When very large anonymous messages are sent to the router and these messages have no receiver, they are immediately released. The router waits for the entire large message to arrive in the router before settling it. Due to this, in some cases, two disposition frames are sent for the same delivery, the first has state=released and the second has settled=true as seen below
>  
> {noformat}
> 0x56330c891430]:0 <- @disposition(21) [role=true, first=315, state=@released(38) []]
> [0x56330c891430]:0 <- @disposition(21) [role=true, first=315, settled=true, state=@released(38) []]{noformat}
>  
> When this case happens, the on_settled is not called for the python binding. The on_released is called. The on_settled must be called when a settlement arrives for every delivery. I observed this behavior in a python system test in Dispatch Router. The test called
> test_51_anon_sender_mobile_address_large_msg_edge_to_edge_two_interior can be found in tests/system_tests_edge_router.py
> The test does not fail all the time but when it does it is due to the on_settled not being called for deliveries that have this two part disposition.
>  
> I tried in vain to write a standalone python reproducer. I could not do it.
>  
> To run the specific system test run the following from the qpid-dispatch/build folder
>  
> {noformat}
>  /usr/bin/python "/home/gmurthy/opensource/qpid-dispatch/build/tests/run.py" "-m" "unittest" "-v" "system_tests_edge_router.RouterTest.test_51_anon_sender_mobile_address_large_msg_edge_to_edge_two_interior"{noformat}
>  
> The following is the test failure
> {noformat}
> test_51_anon_sender_mobile_address_large_msg_edge_to_edge_two_interior (system_tests_edge_router.RouterTest) ... FAIL
> ======================================================================
> FAIL: test_51_anon_sender_mobile_address_large_msg_edge_to_edge_two_interior (system_tests_edge_router.RouterTest)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
>   File "/home/gmurthy/opensource/qpid-dispatch/tests/system_tests_edge_router.py", line 964, in test_51_anon_sender_mobile_address_large_msg_edge_to_edge_two_interior
>     self.assertEqual(None, test.error)
> AssertionError: None != u'Timeout Expired - n_sent=350 n_accepted=300 n_modified=0 n_released=48'
> ----------------------------------------------------------------------
> Ran 1 test in 17.661s
> FAILED (failures=1)
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org